Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <fe077251fea010af59214049eea9681b8008852a.camel@linux.ibm.com>
Subject: Re: [PATCH] [scsi] lasi700: Add error handling in lasi700_probe
From:   James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To:     Haoran Liu <liuhaoran14@163.com>
Cc:     martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 29 Nov 2023 11:14:24 -0500
In-Reply-To: <20231129145200.34596-1-liuhaoran14@163.com>
References: <20231129145200.34596-1-liuhaoran14@163.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2023-11-29 at 06:52 -0800, Haoran Liu wrote:
> This patch introduces improved error handling for the dma_set_mask
> and ioremap calls in the lasi700_probe function within
> drivers/scsi/lasi700.c. Previously, the function did not properly
> handle the potential failure of these calls, which could lead to
> improper device initialization and unpredictable behavior.

I have to ask what the point of this is?  There was once an
architecture that couldn't support 32 bit DMA masks (the altix), but
it's long gone.  The structural assumption is that a 32 bit DMA mask
can always be set, so drivers with simple DMA requirements (32 or 64
bit) usually only check 64 and assume they can fallback to 32.

> Although the error addressed by this patch may not occur in the
> current environment, I still suggest implementing these error
> handling routines if the function is not highly time-sensitive. As
> the environment evolves or the code gets reused in different
> contexts, there's a possibility that these errors might occur.
> Addressing them now can prevent potential debugging efforts in the
> future, which could be quite resource-intensive.

This particular operation can never fail on the PA-RISC GSC device,
which is the only one this driver supports, so the driver currently has
no error handling because this is something that can't happen.

James