Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 29 Nov 2023 17:47:22 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Marco Felsch <m.felsch@pengutronix.de>, richard@nod.at,
        vigneshr@ti.com, arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [RFC PATCH] mtd: devices: add AT24 eeprom support
Message-ID: <20231129174722.7d4e768c@xps-13>
In-Reply-To: <CAMRc=MdsEWxJLHL__zYXGEMYvvLSH99GsTRv_NTaVXt2fGtNvg@mail.gmail.com>
References: <20231127164623.1008176-1-m.felsch@pengutronix.de>
        <CAMRc=MdsEWxJLHL__zYXGEMYvvLSH99GsTRv_NTaVXt2fGtNvg@mail.gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello,

brgl@bgdev.pl wrote on Wed, 29 Nov 2023 10:10:28 +0100:

> On Mon, Nov 27, 2023 at 5:46=E2=80=AFPM Marco Felsch <m.felsch@pengutroni=
x.de> wrote:
> > =20
>=20
> [snip]
>=20
> >
> > I dropped the backward compatibility since this is a new driver not
> > having to deal with it. The old and the new driver can not be used by
> > the same kernel config. So it is either using the MTD eeprom driver
> > supporting partitioning and NVMEM or the older one which does not
> > support partitioning but keeps the backward compatibility.
> >
> > Comments and suggestions are very welcome :) =20
>=20
> I skimmed through the code. Nothing obviously wrong. What I would
> suggest - if we're going to have two at24 drivers - is a lot more code
> reuse. I dislike the idea of having basically the same code in two
> places in the kernel and having to fix bugs in both.

Agreed.

> Though if I'm being honest - I would prefer a single driver with
> backwards compatibility. Have you estimated the effort it would take
> to abstract both nvmem and mtd?

Also agreed :-)

Thanks,
Miqu=C3=A8l