Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4750146rdh; Wed, 29 Nov 2023 09:33:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnDCrihrV5l2ksEXq2FZSL+RGgLSoBR/G/4jyQ+ZMP3EL1d/wKToWlW39zJQVL3fGRnaex X-Received: by 2002:a05:6a20:918e:b0:188:28e:5a75 with SMTP id v14-20020a056a20918e00b00188028e5a75mr19462855pzd.5.1701279238578; Wed, 29 Nov 2023 09:33:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701279238; cv=none; d=google.com; s=arc-20160816; b=mMwff9Lr6ax+jch52t6iv+nLjCBPjJX1m1UUFsOYXk+Q2W42FQbo2yffIBOa02y6VA p4wFkidllqKRzPGusGRDudc71v4HnIWmoEiYDg4817HgDzaaF463MT5GMb8B19doKFvS 45wvXgV1r5rUEQMvCBKZEGshVM9XjHJ06wvXQXdvQfelhFRQryqMFWEurfu0kTUvIdPY YElDeJAukTvTEk61baSa6WsTwld1516ZCL7uGSLMBxByeon5JTqOBrmcbyPQYBUuyLwo SP4/SMEB+rYZuEI8s3wSmcnIUq5no3e7KA3Xi/PcTbuxZG2Xd9Qj1Iti6uyP8Cmh3CYm n7wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=De1+etvyMj4qbGKndNSJbMRzBLfz1+C2FxgVhXNAEvo=; fh=LqdyX/PVRxwjXAspLOiEp+EjBKrmlMxrgVv9J62qDK0=; b=XLIy6j9tzWCggTfwax/HtJi+8ZqCpoZudJ7g9X1+ZjcGrKvDbeedg1yKxF/Ijy+2CY I/kyBQsfvMXoB+DGVOEIMETTR/iHr74DbVI2OHccySYwAfHI12nEe3qBAJBJtnJDH329 NM0lo124K8PpPgMlSj2wdKvCgOl3PAsJom8hg7nGcnm2Dm8M3JpYOqhNFCHP4yPEAx+e EFO1veABj6h06XczyBM+f4yTmhil3AsWXEf6jJ9QOkqju+2wgx7ux6Qlb04OP4n6YV2L PPkSBSKxxVUbOwSWkc+kyHEk4yrXNG9oXfTpwrOyeXLZ58qPxzN39zsdxvqaPEr4tNd1 jRgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=USgwQzTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g14-20020a63200e000000b005be14925624si14741271pgg.714.2023.11.29.09.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:33:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=USgwQzTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 39EF1802F187; Wed, 29 Nov 2023 09:33:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230081AbjK2Rdh (ORCPT + 99 others); Wed, 29 Nov 2023 12:33:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjK2Rdg (ORCPT ); Wed, 29 Nov 2023 12:33:36 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6A5CA for ; Wed, 29 Nov 2023 09:33:43 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86921C433CD; Wed, 29 Nov 2023 17:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701279223; bh=zQQtQnUHucJiwN/RgIyJnqMuBd9OdTTF4L4XnghdVhM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USgwQzTaJOoS5e7xNqNJZYaQJgsm4DYEqgxPQkGiNGMQ9bYiU3rSdOdAKhOorK1Hd sAF10PwyYmAceKrI9fZfeEGjxvuXj5AeqWrKzr3UgzpHW5OEj9eoWAUJDn5MUd/7YU H8TJCT5AxiHc68DVNQc+hjedUEZDe8Tczed+byys= Date: Wed, 29 Nov 2023 09:33:41 -0800 From: Andrew Morton To: Dmitry Rokosov Cc: Michal Hocko , , , , , , , , , , , , Subject: Re: [PATCH v3 2/2] mm: memcg: introduce new event to trace shrink_memcg Message-Id: <20231129093341.02605a16142fc3e04384c52e@linux-foundation.org> In-Reply-To: <20231129152057.x7fhbcvwtsmkbdpb@CAB-WSD-L081021> References: <20231123193937.11628-1-ddrokosov@salutedevices.com> <20231123193937.11628-3-ddrokosov@salutedevices.com> <20231127113644.btg2xrcpjhq4cdgu@CAB-WSD-L081021> <20231127161637.5eqxk7xjhhyr5tj4@CAB-WSD-L081021> <20231129152057.x7fhbcvwtsmkbdpb@CAB-WSD-L081021> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 09:33:57 -0800 (PST) On Wed, 29 Nov 2023 18:20:57 +0300 Dmitry Rokosov wrote: > Okay, I will try to prepare a new patch version with memcg printing from > lruvec and slab tracepoints. > > Then Andrew should drop the previous patchsets, I suppose. Please advise > on the correct workflow steps here. This series is present in mm.git's mm-unstable branch. Note "unstable". So dropping the v3 series and merging v4 is totally not a problem. It's why this branch exists - it's daily rebasing, in high flux. When a patchset is considered stabilized and ready, I'll move it into the mm-stable branch, which is (supposed to be) the non-rebasing tree for next merge window. If you have small fixes then I prefer little fixup patches against what is presently in mm-unstable. If you send replacement patches then no problem, I'll check to see whether I should turn them into little fixup deltas. I prefer little fixups so that people can see what has changed, so I can see which review/test issues were addressed and so that people don't feel a need to re-review the whole patchset. If generation of little fixups is impractical, I'll drop the old series entirely and I'll merge the new one. Each case is a judgement call, please send whatever you think makes most sense given the above.