Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     =?utf-8?B?5L2V5pWP57qi?= <heminhong@kylinos.cn>,
        "ville.syrjala" <ville.syrjala@linux.intel.com>,
        "uma.shankar" <uma.shankar@intel.com>
Cc:     airlied <airlied@gmail.com>,
        "animesh.manna" <animesh.manna@intel.com>,
        "ankit.k.nautiyal" <ankit.k.nautiyal@intel.com>,
        daniel <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        "joonas.lahtinen" <joonas.lahtinen@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "rodrigo.vivi" <rodrigo.vivi@intel.com>,
        "tvrtko.ursulin" <tvrtko.ursulin@linux.intel.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: =?utf-8?B?5Zue5aSNOg==?= [PATCH v2] drm/i915: correct the input
 parameter on
 _intel_dsb_commit()
In-Reply-To: <1lagfvi0ner-1laizr4ur2c@nsmail7.0.0--kylin--1>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <1lagfvi0ner-1laizr4ur2c@nsmail7.0.0--kylin--1>
Date:   Wed, 29 Nov 2023 19:37:17 +0200
Message-ID: <87cyvs5ulu.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 29 Nov 2023, =E4=BD=95=E6=95=8F=E7=BA=A2 <heminhong@kylinos.cn> wro=
te:
> Friendly ping. I think this patch was forgotten.

Pushed, thanks for the patch.

>
> ----
>
> =E4=B8=BB=E3=80=80=E9=A2=98=EF=BC=9A[PATCH v2] drm/i915: correct the inpu=
t parameter on _intel_dsb_commit()=20
> =E6=97=A5=E3=80=80=E6=9C=9F=EF=BC=9A2023-11-14 10:43=20
> =E5=8F=91=E4=BB=B6=E4=BA=BA=EF=BC=9A=E4=BD=95=E6=95=8F=E7=BA=A2=20
> =E6=94=B6=E4=BB=B6=E4=BA=BA=EF=BC=9A=E4=BD=95=E6=95=8F=E7=BA=A2;
>
> Current, the dewake_scanline variable is defined as unsigned int,
> an unsigned int variable that is always greater than or equal to 0.
> when _intel_dsb_commit function is called by intel_dsb_commit function,
> the dewake_scanline variable may have an int value.
> So the dewake_scanline variable is necessary to defined as an int.
>
> Fixes: f83b94d23770 ("drm/i915/dsb: Use DEwake to combat PkgC latency")
> Reported-by: kernel test robot=20
> Closes: https://lore.kernel.org/oe-kbuild-all/202310052201.AnVbpgPr-lkp@i=
ntel.com/
> Cc: Ville Syrj=C3=A4l=C3=A4=20
> Cc: Uma Shankar=20
>
> Signed-off-by: heminhong=20
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i=
915/display/intel_dsb.c
> index 78b6fe24dcd8..7fd6280c54a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -340,7 +340,7 @@ static int intel_dsb_dewake_scanline(const struct int=
el_crtc_state *crtc_state)
> }
>
> static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
> - unsigned int dewake_scanline)
> + int dewake_scanline)
> {
> struct intel_crtc *crtc =3D dsb->crtc;
> struct drm_i915_private *dev_priv =3D to_i915(crtc->base.dev);

--=20
Jani Nikula, Intel