Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4753330rdh; Wed, 29 Nov 2023 09:39:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IH93PQXtlLuum1XyMvx5b98RfMwWHVRmnAbbYN/z2bNoMcLAsKGXDcI8xc1uagtO8QPR+8f X-Received: by 2002:a17:902:d50e:b0:1cf:cd35:f823 with SMTP id b14-20020a170902d50e00b001cfcd35f823mr11072849plg.65.1701279551880; Wed, 29 Nov 2023 09:39:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701279551; cv=none; d=google.com; s=arc-20160816; b=xcnjIHJ9FOJrvVcFwzw0T6Twp/3l5a9ELsEG2rjWAh1dq7o/keedsndU9Rzr1iFP+m jSXAQnuvxB4eWwRYVBcEPtyTrqbUVBwrAlNa4Q0ghY31DW1VilxHzvUqhbqZ0GBT/C5W iHPuvT2X+BTaF0li7lL2bFzjcUNPYR5qa4JUHXurisfvEjWp74F8dXOazNhl2Ohin1mj KuIc07VLhp+oWJSHejEKp7Nu0iDLSIN3mDN63MAlX+8cZkn006wQLvAt1ZoyZySx/drU rZKwW29nJDcr/pXRRMBUSLeyWxaGtLyUhzmYnlTnodsM4NrRNjKS//mEGmEk5+Xs+UFL 7A7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ujQjK1ILR+2hLI6PlT06tIQvStPdR3UqqG1p8t5orBQ=; fh=X1lxrGLA7V3PBg9NtHG1M9vtBdBLI2mDk4lzNRfgcS0=; b=gSDF2O9u1Gsu02j+n3cUmKBNYmeLn39yjr4wRGeIZwsXBTLoT0dn5Xe9OAp84q6xPd VX7tp7dKsUKLB77oLIMzWgR86E1ixUO/Jx5DqGz/40i0gLWORdQT204HtSQfOeTGH8z5 crt3ilOwEHjxvRHxTAENSiDocyQgv6RPUtcWxHJ0p0m8CjRFpeUwLqXOsxG+jg3dcUio 6BmsdSq0JzVl72s3Z7bCx4pyhL8kkn59WL/uHzhhzAWTvf20hd/38mwD9+qGN8dl7XiG 2JlHsWLWVEZSpr8jfo8i+vwLIrmyWeELSkpRPNP4lJJtFsLMvhvsY1xaGMzBJNZW4sno sTyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="ro/PLRKk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id h9-20020a170902f54900b001d00ff4bf78si2695118plf.50.2023.11.29.09.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 09:39:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="ro/PLRKk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id ABABF804399D; Wed, 29 Nov 2023 09:39:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbjK2Riz (ORCPT + 99 others); Wed, 29 Nov 2023 12:38:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjK2Riy (ORCPT ); Wed, 29 Nov 2023 12:38:54 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B748FF4 for ; Wed, 29 Nov 2023 09:39:00 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-54b0c368d98so12690a12.1 for ; Wed, 29 Nov 2023 09:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701279539; x=1701884339; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ujQjK1ILR+2hLI6PlT06tIQvStPdR3UqqG1p8t5orBQ=; b=ro/PLRKkE8LWnXJks1ZNTl1ynGKa1l6+lyH3Rq2Q7wznfNbSHjozi+1i4V7kjOp5Ru GwphosNpDpSs6tBo+ou3GRA5nb8bvXilZkCzczVfFSyg+xJ0AgR+y/ZKZm+o7wZDP7U0 /LALdwPSYeif02FY4l48R4wvfjMBeDKDX6cegYcqHOrPFow+Qh1CxAEiFs2qiO1inKA6 iF37i4TooYRVR8EnJlXTMKegTbVRrISULSwM4BYt1NhjZDvQClqwpj4QawPWyJn4yPkG b0Ydr0PWjsyinbLzXeWWMJG5KuGFGYs0JvCKQy9r4SZZMuX/V8sb8S353gJ5rRJZOWYJ XE1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701279539; x=1701884339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ujQjK1ILR+2hLI6PlT06tIQvStPdR3UqqG1p8t5orBQ=; b=wbqzmgA4MJ7Y9nUqUAB8j6j37PVZIVfq3hkXEZeJNnLpbry5dLffXdn3bNp9gJiCwc Et3IbMNn3dZcM9LA7FmiFma8aZctIAAPJVSD/FYpwf9Ixr0g0K3+fanXVS/Q4DvJiFpi ESI6lOJon42OyJKnF8siKWg/h4jilwCyVpt1LpP+XAOh00ZnJUh3S9c9DnRCV9AqiIqV LZ4GsUJfnvdSq99Je9yiP7OZlG+Zu28A6dWQ4JbCRvWlJhcoPiy+zSvugYqv4/s7JKaU Yxai46gtOueJtDDw59TtHeO05TaGJ2PKTOFykuRvZySKZ/OF9WtYeum81F/9w5vVsUtW n5zQ== X-Gm-Message-State: AOJu0YyZsd6J4dDrd7akJrwpwcL8xsVlk84Zim/N/J//vW1DlsNUvZRk lWKIVODkoGv0fgj3c0ovP3JgC4IC39Wrez9v90YyPw== X-Received: by 2002:a05:6402:540a:b0:545:279:d075 with SMTP id ev10-20020a056402540a00b005450279d075mr1069425edb.1.1701279539029; Wed, 29 Nov 2023 09:38:59 -0800 (PST) MIME-Version: 1.0 References: <20231129165721.337302-1-dima@arista.com> <20231129165721.337302-4-dima@arista.com> In-Reply-To: <20231129165721.337302-4-dima@arista.com> From: Eric Dumazet Date: Wed, 29 Nov 2023 18:38:45 +0100 Message-ID: Subject: Re: [PATCH v4 3/7] net/tcp: Limit TCP_AO_REPAIR to non-listen sockets To: Dmitry Safonov Cc: David Ahern , Paolo Abeni , Jakub Kicinski , "David S. Miller" , linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Francesco Ruggeri , Salam Noureddine , Simon Horman , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 29 Nov 2023 09:39:09 -0800 (PST) On Wed, Nov 29, 2023 at 5:57=E2=80=AFPM Dmitry Safonov wr= ote: > > Listen socket is not an established TCP connection, so > setsockopt(TCP_AO_REPAIR) doesn't have any impact. > > Restrict this uAPI for listen sockets. > > Fixes: faadfaba5e01 ("net/tcp: Add TCP_AO_REPAIR") > Signed-off-by: Dmitry Safonov Reviewed-by: Eric Dumazet