Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 29 Nov 2023 15:58:04 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: Re: [PATCH v6 2/6] iommufd: Add IOMMU_HWPT_INVALIDATE
Message-ID: <20231129195804.GF436702@nvidia.com>
References: <BN9PR11MB527659462CCB7280055858D98CB4A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZVuZOYFzAaCuJjXZ@Asurada-Nvidia>
 <BN9PR11MB5276C8EACE2C300A646EA8A18CBBA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZVw/BXxgGCuCZCA6@Asurada-Nvidia>
 <BN9PR11MB52761A9B48A25E89BEECE6308CB8A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZWTzoBTDDEWAKMs9@Asurada-Nvidia>
 <BN9PR11MB5276FD60A0EDF8E3F231FCC88CBCA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZWaLCSAMIOXTlghk@Asurada-Nvidia>
 <20231129005715.GS436702@nvidia.com>
 <ZWaPM4p7yjJ0sEKk@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWaPM4p7yjJ0sEKk@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wk6RMyyfmUj7c+6yPj6fdNMNPj9Zne2uPvWxAmjvTg1wtXUgQekTo/8N5uyj?=
 =?us-ascii?Q?rOcpBk3yhK5Ms4018Ffr62kIPw1h0ekx1mUX2szna+v+zqpdpohhxYYqd03D?=
 =?us-ascii?Q?7kQe3NdpxoCOS9patNVDhyFAHcwsqcAsmCwWVvHQfHiD6rCQJR0/sHgg4pZQ?=
 =?us-ascii?Q?BScgSLntdGX4kSuo5nInh8q31509fSec5NNglQZZFziHwSz+MDjp6Wwlsm46?=
 =?us-ascii?Q?ltEWF8Eog+TNds6cYwwRMLxaBWRxWiGrgL2z+Cqnlk9L+LYYJkxxdi8HJkKI?=
 =?us-ascii?Q?i25Qv1G8/Smd1ARCCuOAOB3FcJhWiaHwEDxRpdkrKQth8yYr/gAtxXc6oKjm?=
 =?us-ascii?Q?/B8Z/4h7oxQSjNvoFxS+gYm1oCL05kER+rCZDJQXF1N3dw8wwVZbkZbmEBBx?=
 =?us-ascii?Q?gXQvz0ZplI5rqwe/U7Epp5/EorYl0Qf7jzzaJlqEylGd1TIUwjQzjhTPFXRF?=
 =?us-ascii?Q?MFRf6n2cy+dkqI7+wf5P25rzGP+ju4XhKL5wnm/x2zxTRVviHuLRehjytlDI?=
 =?us-ascii?Q?8hxgJIPFEaB49ug1ASY7TMc4vHTVSYMRy8XJQfzt6g7gOhYZJKrd7rn0jc64?=
 =?us-ascii?Q?6/FJQk/IqRyHmc3h+6BVHuKtubsQr05l5itul4XAAw2cyXLEwhGEO2SNEfBN?=
 =?us-ascii?Q?4n0D+MTo4NTxPKUFzPhB38J6mOX/IsWr6vJOfa6JyZNSZ5GXD7VL59Al32Nk?=
 =?us-ascii?Q?AgQvt4ao9tktntsFzCBsADWRPptA3jZNc2KaGjg8ktwZnxP4i+Mk31l8P4zZ?=
 =?us-ascii?Q?ap4Ol3iZng8g7mlAtHAOmQYRNYmk/dIjp7CUq0C3QLBA0CmahRJ8u/6sRi3z?=
 =?us-ascii?Q?MxjJR7NsWLKQcbJnO84/ioE8AkcZFm7SNcqexoZDJ+NfOK3GRjp+WuyQ5cJs?=
 =?us-ascii?Q?+HET7MQwevxbMX6Cc2EeEXrgTjMo9sDKT20x9APBxBam9NLEE1AgG1u/i9oD?=
 =?us-ascii?Q?QQt1newzO8MMOuU2xNBEum6B1G5KWRl8uB5PGt4iXgdAZMDRCiYhm1qWIpEC?=
 =?us-ascii?Q?tBW3GawVv9Uq7sDHPAStpmCPWLdo76rTz4FR4oT4bPCThD7D8VZvDrGdEHEb?=
 =?us-ascii?Q?uFzqUE8PpdxDIgAjgJMBvy1P17k+CBRRBy9pHOVK0+cDZIZydu+2YG0ItNSe?=
 =?us-ascii?Q?boFwFjQfNyciJfv8Pf4qSYs6kVU7C+u9zkvg8yjH+Vq4DjyppjPLlkiELRsd?=
 =?us-ascii?Q?2YmkuoBIaE+CKM9GOtaVjgHhphRbDes6sE92dIDZl44IvUv0llgBm1ySMp6M?=
 =?us-ascii?Q?hzTYPuqKT62/56sgTOXM+R4OAt9ffaCjA5INiSRnjKjhqvPownCeHxJpOxXu?=
 =?us-ascii?Q?AEEgB3fHB43C7ptLn0+2VAG2Eh3GJTpCLA3kfkHl39+WEUFFF90irzYgOKOK?=
 =?us-ascii?Q?2v75eDWRAsIS7TSodFtCdsrp5AMJnZt3zHnNR6QFVGudmJsef33YMAuXAKNF?=
 =?us-ascii?Q?eITEvOWYCM/HyXjh/uGVPH1S0cBnxGAzpBnBOWwKUl3DhPX1FB/lmJ6/DYn1?=
 =?us-ascii?Q?IY1Ld4UD1qdEXYfnDbUYi+f9hLroefB/jRKODwE1+QXFXv9eid5p0qpLIzVD?=
 =?us-ascii?Q?NNaavvw1VvWblrJu7J2qCR9lFZEDjgT25LBd/cWw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01d87845-c4a2-483c-ed8e-08dbf11580cf
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 19:58:06.2047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: izIl6WKOX7mY4j7pcm4kS3fD1+DWcY9X+MuQPTPI3WoYv/uGZKfUB7uwO7nsld9M
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7006
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 29 Nov 2023 11:58:48 -0800 (PST)

On Tue, Nov 28, 2023 at 05:09:07PM -0800, Nicolin Chen wrote:

> > > With that being said, I think errno (-EIO) could do the job,
> > > as you suggested too.
> > 
> > Do we have any idea what HW failures can be generated by the commands
> > this will execture? IIRC I don't remember seeing any smmu specific
> > codes related to invalid invalidation? Everything is a valid input?
> 
> "7.1 Command queue errors" has the info.

Hmm CERROR_ATC_INV_SYNC needs to be forwarded to the guest somehow

Jason