Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4843879rdh; Wed, 29 Nov 2023 12:16:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKes8wPulg4AnITA4VI5v/UdiwblDjVG50wio38f+irSeixERMH+/5BWq9EDctJFJWxjNz X-Received: by 2002:a05:6a00:93a7:b0:6be:4228:6970 with SMTP id ka39-20020a056a0093a700b006be42286970mr22375948pfb.21.1701288963610; Wed, 29 Nov 2023 12:16:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701288963; cv=none; d=google.com; s=arc-20160816; b=YC4RihmLf+Q23AQiSjdtqJ6yWBfA6aPBQUP/0t4gVljrBaYk3Ja2aT+bywEktP+jwz b4vMK9YX+ObeVUstNf+tZEeJcim5ZLhPCfuGr27h+7CjZjObYL8spjEa2DZx+vBC4rGG v3Xr7iwoWuPyyALbi4Zmh3YUOgqSMEiaZ508TrYTz3FF3N15B8hLm/mK91xhfL0XRngX cIAoRdT3RRhDvzwAENEEGqSOOIBH3NtYVGeOfjZG58koX96gVAdc4nC9f2Q/+7dCN/4t r+kFSU2TtSbPw2gkR3NxlskzWbS1bG+qPtaiI/b3L1Wc7eZf2j+V1lAP/EBBULoshhWi +FXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jotP4vYpPJo//cpTI3uXY4V9lpzWkYj/fK6F2WyIseA=; fh=iiYfDobHY2MINwdFncWE4AyogtZJ8OG7kkW3c73+dMQ=; b=JN8o9VJy3yoJkPK0ADh8fsTPtJg4nQIIUZkWll3+9832oSseMfvbdWc5ObpLwVKB7E UvhaJe158o8EuTBnfPK9ESOsUxXIHkkMYsNvZbdZXigpQCZlfOEWw7redrsLb3p7Lmr/ 9y1+PUtqv+blPowu7pzqvpbGQuiBAkkKRlwQuQPC/CZyMhDKi8VhPgIBhh2RWVyAYBXA rdkYrwD2KLDNUINZ7zgxfcVI0eblW7KhQhSz4RQAcrILN5izOxKEZN30GwaxucuBxisb 6TCr/9+9F/7eOIh6BfmIBvYhrusp/rAxo78zBgfBqpb5oy2UtdVI7gTZPEPn6uwQ4p0J qjQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hcdfwa4T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id y6-20020a056a00180600b006cdd83f45c0si1379968pfa.229.2023.11.29.12.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 12:16:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hcdfwa4T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 019FF805746B; Wed, 29 Nov 2023 12:16:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231523AbjK2UPn (ORCPT + 99 others); Wed, 29 Nov 2023 15:15:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjK2UPm (ORCPT ); Wed, 29 Nov 2023 15:15:42 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66671D69 for ; Wed, 29 Nov 2023 12:15:48 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5c5fb06b131so148163a12.0 for ; Wed, 29 Nov 2023 12:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1701288948; x=1701893748; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jotP4vYpPJo//cpTI3uXY4V9lpzWkYj/fK6F2WyIseA=; b=hcdfwa4TYcjUsd4YezCO6cbH/PkKleuvxCuGnZoxGifuXLSJvfQZOm/1KrNR32M4CY TzKCy+vq+86ljb5r9bxSkTOK/rwW8sUqP023BbJ0FDV+beFBFTstZ49SRNuEFe99uSdW 2K3KvdnptVVMNAWbLYfloZ86JP7odnEBhv8pI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701288948; x=1701893748; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jotP4vYpPJo//cpTI3uXY4V9lpzWkYj/fK6F2WyIseA=; b=kjmF5r+juyK09cKZCTxZqYd39wlR9aUdu4WcZeQ7hZWHESrEOwgCes5RpO6pfWgmR4 v0b7PawYDSFXjueBH/8ZErLURMpYXTiy6Zh82mGvsGOBRuZo7czyftBNibeDqT6KiU0V YkESnME+1/j4oGWBUU8tSYSaTfPtd6ZMDar7u09UEHfQ2S4Gw5Cpg1thkW9+awX7v9g8 NnMC8rD/1xO40L8EsTBm1/x8obd3TOecZmKHPY4uYRchu9zokXBlCs4sZyI18BLB7fvi IeTO+o7hP6Ex9tJeL6jZxSlcf8Z22x/t/grsRZX/1FINvdcl0duBcNEM6SZR8A1Us2ul cT3w== X-Gm-Message-State: AOJu0Yxvi5LulPS0nPzZnCBu0CwlDnYopqpsHyyghFOe8OUWyW5cVViT UGJ7vs0IgUNq5RyCRphX7BYhzA== X-Received: by 2002:a05:6a20:e113:b0:18c:5c04:a55e with SMTP id kr19-20020a056a20e11300b0018c5c04a55emr17283060pzb.49.1701288947811; Wed, 29 Nov 2023 12:15:47 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id v15-20020aa7850f000000b006cde291d429sm194972pfn.39.2023.11.29.12.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 12:15:47 -0800 (PST) Date: Wed, 29 Nov 2023 12:15:46 -0800 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] bcachefs: Replace zero-length arrays with flexible-array members Message-ID: <202311291215.9BBCD8E@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 12:16:01 -0800 (PST) On Tue, Nov 28, 2023 at 12:22:55PM -0600, Gustavo A. R. Silva wrote: > Fake flexible arrays (zero-length and one-element arrays) are > deprecated, and should be replaced by flexible-array members. > > So, replace zero-length arrays with flexible-array members > in multiple structures. > > Signed-off-by: Gustavo A. R. Silva These look like straight-forward conversions. Thanks! Reviewed-by: Kees Cook -- Kees Cook