Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Wed, 29 Nov 2023 16:28:51 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Kevin Tian <kevin.tian@intel.com>, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] iommu/vt-d: Add support for static identity domain
Message-ID: <20231129202851.GG436702@nvidia.com>
References: <20231120112944.142741-1-baolu.lu@linux.intel.com>
 <20231120112944.142741-5-baolu.lu@linux.intel.com>
 <20231129202615.GN1312390@ziepe.ca>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231129202615.GN1312390@ziepe.ca>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?koLiAOgpS/jjU57/H6hSuOOe8JB8FQKed3i3uSJP1mboeDPppxfRqC8hCy4B?=
 =?us-ascii?Q?GQc7HQD74xFAckYeCqqh/cgRxX+Ws4ekHS5Xs9Hi6/bwWaPfOWHGdg27pKDL?=
 =?us-ascii?Q?juYAVpy1o3d0bIwUehhFIUQ88i2EBgt95sh8ST0HSuaYoijqw+nHVF7xkvzz?=
 =?us-ascii?Q?somCHrpJEf4IouU4MItlbVlLOcbSFYZC7EzVy4CVk52QFpJr1fAVB3c9STp3?=
 =?us-ascii?Q?UOhZphKzwDDnPuHnciuazOdb0CZohf25kxZ9sFz3GgN1hnHhMmkBX4U3Zmzl?=
 =?us-ascii?Q?Zc6cQIrTfhChr7hq99UHDrQn+HyWAahMyN4x3v0Oo1xcJ0p7pnDi4rLjG7dJ?=
 =?us-ascii?Q?WLnB7kyRlh8tUOdbtGzRkSQyEV/kWDHCy0SMzpacmw41Ffe2TINLTebm5xgJ?=
 =?us-ascii?Q?wqE5ivFvc+22Xr3KnBiAxYw+8+tkxGjRF6vYNyt9nQIrNbDJQ5PoNhlBNeqU?=
 =?us-ascii?Q?Xp0JK5VW4o/uJww2vKGZZGQh1B4ReDinF3Ohzg+I4izSNv/nOqPskHA5VMmv?=
 =?us-ascii?Q?hR+2KZBmo7dNPZSM6J1v+r5+G4kjt0ULNPcKu3Zkco6L+PcwGMLr2xTZB7tg?=
 =?us-ascii?Q?5d9w/pXRvBvVknp1lZCITUWmpSt44lKdoxDh+aCTsARQt5KdJCnOWF4cBb8U?=
 =?us-ascii?Q?fUeWtpTbVD4d6i1lh2iGrQEdTGMOh6rTe3ye02Oc39X0U4ArWyIwfTnMyLcI?=
 =?us-ascii?Q?9/JsmDvFB6Nh/fmecr2x0F6MJQid/zXgVp173SQNxXRctvVm/BzRdeG8RPj3?=
 =?us-ascii?Q?11T9Bmuj1r2QsX1FYw/XW6K/WRriYt2yVgExVeL8KgdzmEorCuDO4zBhNo1H?=
 =?us-ascii?Q?VtGvFaF1MoYiEMJJQ8fKy77FVhv8vOvVhWDkGMLmEKx8IOYIKT2+ulrhCiJZ?=
 =?us-ascii?Q?ovgSm6NVp/Zd0+I+n9aOktG0WE4wsP7urvJ34p2Fu3wK5Tm6wUTUcHBR602j?=
 =?us-ascii?Q?+enpPgaAYjALRa7yqSAoDBHF4CA4swM7nE2eauhIkMqeGAULzYzI7vcycIEs?=
 =?us-ascii?Q?iPgPAzR0n7eX3PzRf9nIVC+3owOSPT29g/noDlJ3i4dpCQE/4DJOnb0RGPop?=
 =?us-ascii?Q?GZWip/nv+QL+3ACw4US+UqFYW05jRfB38Qg2Wiw5XAUsxBLRmxnjcobVmRzh?=
 =?us-ascii?Q?mFjDq8iyQGAEcfdjUjrIO4lFYZTRt7VluVPGhNuWwUyU4n9mDE42ZQLL+XTE?=
 =?us-ascii?Q?pJVBal/Hl0aw7rIcvCf1MRuT8lvHHhUgJ6zEQ4KLSAPXoZ2V62vgh4QXrfYp?=
 =?us-ascii?Q?Z+GLeIUQ4Y0f1fr3qEdEWA5yasg/YeUETX/9FsjKRH87XopxfXiBCXRUU1SQ?=
 =?us-ascii?Q?kowsouQdURZ1dP02GRZq3LmqU0pYN0ySkQrsKDAuNb/cTE8Jij1y0w/h8UsD?=
 =?us-ascii?Q?WG/z9lHD/PLE44TFbbALBTOdHZBb/vf4pPK5KiogfEuGoCcZTwcq1rakIPAq?=
 =?us-ascii?Q?bfIDwV6U1OyP9P4gOGDfNpIXqNtOoq/dxqPmQNPteps8b5+AYHGVD+0vZ201?=
 =?us-ascii?Q?NvsIaIfu/aOiYKGZLQwE0Z85nwLkX7g16VeUmBtXRBWooU7CAAEGo9KFjt/K?=
 =?us-ascii?Q?3pD/5+WAoYi7V0a7dF/LKcCfwN+6CMDkSOfYSA5r?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc0a2993-f3be-4fb9-6432-08dbf119cda2
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 20:28:53.1538
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GwROXKCyqbaWWeJYBLgXId+7VpuW1Y+iLLcRUMxqdT2ReWAKoQmShkUpxuXKjx6D
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8541
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 29 Nov 2023 12:29:11 -0800 (PST)

On Wed, Nov 29, 2023 at 04:26:15PM -0400, Jason Gunthorpe wrote:
> On Mon, Nov 20, 2023 at 07:29:43PM +0800, Lu Baolu wrote:
> 
> > @@ -2311,6 +2316,13 @@ static int device_def_domain_type(struct device *dev)
> >  			return IOMMU_DOMAIN_IDENTITY;
> >  	}
> >  
> > +	/*
> > +	 * Hardware does not support the passthrough translation mode.
> > +	 * Always use a dynamaic mapping domain.
> > +	 */
> > +	if (!ecap_pass_through(iommu->ecap))
> > +		return IOMMU_DOMAIN_DMA;
> > +
> 
> Doesn't this return from def_domain_type completely prevent using an
> identity domain?
> 
> I thought the point of this was to allow the identity domain but have
> it be translating?

I suppose the answer is the next patch deletes that stuff.

I would probably have structured this in the other order, first add
this hunk and say that old HW is being de-supported. Remove all the
now-dead code creating the 1:1 page table, then refactor the remainder
to create the global static.

Jason