Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4872159rdh; Wed, 29 Nov 2023 13:13:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7U0Vx1Ac36OhkU0RPkgY8yRhyCpnVx8MMf5j/pbH93bbOKsrIznIKZzhxmkf255L9nXvY X-Received: by 2002:a05:6a20:e121:b0:18b:e49:fdd2 with SMTP id kr33-20020a056a20e12100b0018b0e49fdd2mr27016472pzb.9.1701292390874; Wed, 29 Nov 2023 13:13:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701292390; cv=none; d=google.com; s=arc-20160816; b=yKbue/x46In2jDISqQv8xHQK4Hay7CLLyaSx/rgAvCoN7UIeAQdpZJRebbJrpoi2sz z9rdkXueJn9ZAimPjZs/UBWk0iR9zkUQbnAppmOFS07W4RYqy7bInAJk8rVXewiUYEgt YP1jFRr89f7ZooYFh+BLKmKncLG8WQc9tM5jJ+sWtKDdeaRMbveZskM3jxmG6mMc2nYb ha09lu4s5cr60z4SMYI7kG3YHwjIH6YVOUdxET670yQZGur4Fq2+1qWE+ZvHSgpGozTi ivmF8UWtAR2en0++uciwS07xloETsTG/1IkMmFHubjj1LRptLn9V6o0Hid5TFTJ/GcDk DNnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=j6B/ppfbw4nVXEGkOzTBY61+qsKBAI4aamGlzoAAChk=; fh=JjcAvHxS6hpqkRs3zIePpzkkm6zBlhkKawt7dBhhK4o=; b=eN56/W4Lhv/AWMAgi7pHDJMoYX2dA+q9g5vFwnfRYJdh0Cuhd7YlCEGo63+G/4J48h kIwDHWFAADUDkFN4/b7Xpsxu0fhM3SoLny89Jhi6zqaMD4y2i2tJ7deaQh9aq4MZ3XZK p4J9pB5DAYoG4zuwVt11lsxJxELmCYdNICvzZs61baHkKVbVRs47HGJy9JOH8dzVVVPR Gcn3GC+f6+zBqHfsqmzYcH2Jkh1BwoYOo0t6v5WUIjC90BjE/xF4vosRqawfvKTWPA+r l5SzSGZqG6nGo7lvGFjA2lu04BKjyYtevks0r7Hk/o8xSaDb9LOq3JH3zwWC4FYXEi/p oJXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=g08wS+Lc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t13-20020a62d14d000000b006cd8a31b002si7808492pfl.375.2023.11.29.13.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:13:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=g08wS+Lc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8B01A802DAA1; Wed, 29 Nov 2023 13:13:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234270AbjK2VM7 (ORCPT + 99 others); Wed, 29 Nov 2023 16:12:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230053AbjK2VM6 (ORCPT ); Wed, 29 Nov 2023 16:12:58 -0500 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59883D69 for ; Wed, 29 Nov 2023 13:13:00 -0800 (PST) Date: Wed, 29 Nov 2023 16:12:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1701292378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j6B/ppfbw4nVXEGkOzTBY61+qsKBAI4aamGlzoAAChk=; b=g08wS+LcBoeVtI3QYrYcOsZQXBygvg5pMvS+dVnu6jxoEA+GXUqudxD23qKR5gzB8//Lxi F2IVANic5JJvOm5/Jl4BTG4DtwivVoETi48bAzvTDApA5+M7Oxdc1uQ8TMh60nvJ7DFYFg bJrkjK7Fhs33eiTginub9jRpgc4v2fI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: "Gustavo A. R. Silva" Cc: Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook Subject: Re: [PATCH][next] bcachefs: Replace zero-length arrays with flexible-array members Message-ID: <20231129211254.45yu4ghc2wg5d4w5@moria.home.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 13:13:09 -0800 (PST) On Tue, Nov 28, 2023 at 12:22:55PM -0600, Gustavo A. R. Silva wrote: > Fake flexible arrays (zero-length and one-element arrays) are > deprecated, and should be replaced by flexible-array members. > > So, replace zero-length arrays with flexible-array members > in multiple structures. > > Signed-off-by: Gustavo A. R. Silva There are some ZLAs I hadn't converted because they led to new warnings - in particular, array of flexible members. I don't think that applies to any of the ones you changed (replicas_delta_list, maybe?) - but it's something we need to figure out if we're getting serious about this.