Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4927336rdh; Wed, 29 Nov 2023 15:11:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIBWZePSrNo+lNtcWxhDtJNfkNxv+jRY7MR2fXjHf0Z3h1aIhVWYm3LIaOOoy9CxkKvmV2 X-Received: by 2002:a05:6a21:a5a5:b0:187:a119:908f with SMTP id gd37-20020a056a21a5a500b00187a119908fmr28733489pzc.3.1701299492711; Wed, 29 Nov 2023 15:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701299492; cv=none; d=google.com; s=arc-20160816; b=Ec6/fhr6zxH1YGkfPlLo0IU7fkoZAljbP+17qTzuA1Is9QfZ0zZh2pO0eDtJhjiNBC vjDZrBkuXcFPnc72OFeSaHmc2LOroJbB8+yvXdJ5VP//IdQTTHZce6Ke0S6hqWXngaq6 eL6+s1fT+sVZQtkgvDE4jxX4xEmlO5qD0jGtELrRDsg6LFMDM/a3FmdSSgAYPjD8NW5U UDtBBnwkCvgAwlu0ocz1QVlpN7LdcZQ4YL2YcjhxnFA+KYVkf5Gp3WDPXxKmFGp3XYpT Q+fRIRFniMGUkyVTZa0wYwwU7TofkpVXwNtQuniWz1c1FypFPW2si2qalljRDBpg8efD 0ExA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ArvZ0yRE6vk7iq9dOI1ee17t6aoO5hfss98sJpj6j3c=; fh=9wh+wnCN4ga7UQK5njeklTum63BlwLa2B79WrxDwu7c=; b=GEe8+itvtP3TznIiOv+YzFpaigi8+lQ3MM0ws929nWJtQkJJGQJN09SRRFNgjW7hyK h1tM6hjVllc1Y91gs+EKOXr4QnlThS5IBsX6pBNGIHC1Hz/AKN1aPssM0DFkYfupT9c+ SRoLvr+TFLU4d+z2renGs5+8ZSEPrapaykCajUDRmeF7iWbOXuSR1f4UqiVvptQutJ1i O5Utdriu5CbAia4s/c2lcNGjf9/FNsK+jJGZhrdXrq/nJ1pjiDec3pnaSwK0PPZDsmuU mkwjnbJ4b3mV2J99I2PL1ozoPTvyEJkUaUQYB2xtAY8IuDUOu69PGvz/SZ6JKxSSbaCP VmCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=YDok8f25; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id e28-20020a63545c000000b005bd3d377a54si15187416pgm.123.2023.11.29.15.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 15:11:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=YDok8f25; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DA835808FA27; Wed, 29 Nov 2023 15:10:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343638AbjK2XKZ (ORCPT + 99 others); Wed, 29 Nov 2023 18:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343640AbjK2XKY (ORCPT ); Wed, 29 Nov 2023 18:10:24 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E146D7F for ; Wed, 29 Nov 2023 15:10:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96778C433C7; Wed, 29 Nov 2023 23:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701299430; bh=N/H0WI8OOAZg5IsWZvaQQHP/VpfSznz5JRrpi05DQq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YDok8f2518AVgQG+4UbU1jDVslt6EdxIDQcEA9vP/gGtXvaGokTj3clVuawA/cGXw 4aqQWtzWKem2vtw5Ub1sBn+3QvIq/SfJ6ogTJQYOko4tZoMau1Nb4B9Y/lpe+yocnu PEvzSJk+c3KNAvWZP7c0XdWMiPiaqvlDul7kElLw= Date: Wed, 29 Nov 2023 15:10:30 -0800 From: Andrew Morton To: "Arnd Bergmann" Cc: "Stephen Rothwell" , linux-next , "Linux Kernel Mailing List" , "Thomas Bogendoerfer" , "David S. Miller" , sparclinux@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: linux-next: lots of errors/warnings from the -Werror=missing-prototypes addition Message-Id: <20231129151030.24b807f1d2b43be301a533b7@linux-foundation.org> In-Reply-To: References: <20231130075838.05e5bc9b@oak> <20231129131003.d2c1078847c3865c1ac2dfd5@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 15:10:41 -0800 (PST) On Wed, 29 Nov 2023 23:51:04 +0100 "Arnd Bergmann" wrote: > I did all my testing with CONFIG_WERROR force-enabled, so > the bit I missed here is that at least three architectures > that are missing fixes also set -Werror: mips, sparc and alpha. > > How about adding a patch to no longer force -Werror for > these? These architectures are doing it wrong, aren't they? They should be using the CONFIG_WERROR infrastructure rather than hard-coding it? If so then sure, a standalone patch to clean that up sounds sounds appropriate. I guess it should precede "Makefile.extrawarn: turn on missing-prototypes globally".