Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231129221140.614713-1-npache@redhat.com>
In-Reply-To: <20231129221140.614713-1-npache@redhat.com>
From:   Joel Savitz <jsavitz@redhat.com>
Date:   Wed, 29 Nov 2023 18:44:22 -0500
Message-ID: <CAL1p7m5H7YoQFg6BJ1zhPGyvfoL4BP1Tn1t-NYv=g2cuEQwJfg@mail.gmail.com>
Subject: Re: [PATCH] selftests/mm: dont run ksm_functional_tests twice
To:     Nico Pache <npache@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-mm@kvack.org, shuah@kernel.org, akpm@linux-foundation.org,
        David Hildenbrand <david@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 29, 2023 at 5:11=E2=80=AFPM Nico Pache <npache@redhat.com> wrot=
e:
>
> ksm functional test is already being run.
> Remove the duplicate call to ./ksm_functional_tests.
>
> Fixes: 93fb70aa5904 ("selftests/vm: add KSM unmerge tests")
> Signed-off-by: Nico Pache <npache@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/se=
lftests/mm/run_vmtests.sh
> index 00757445278e..c0212258b852 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -334,8 +334,6 @@ CATEGORY=3D"ksm_numa" run_test ./ksm_tests -N -m 0
>
>  CATEGORY=3D"ksm" run_test ./ksm_functional_tests
>
> -run_test ./ksm_functional_tests
> -
>  # protection_keys tests
>  if [ -x ./protection_keys_32 ]
>  then
> --
> 2.41.0
>

Acked-by: Joel Savitz <jsavitz@redhat.com>