Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 29 Nov 2023 17:43:15 -0800 (PST)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Shuai Xue <xueshuai@linux.alibaba.com>
cc:     ilkka@os.amperecomputing.com, kaishen@linux.alibaba.com,
        helgaas@kernel.org, yangyicong@huawei.com, will@kernel.org,
        Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com,
        robin.murphy@arm.com, chengyou@linux.alibaba.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pci@vger.kernel.org, rdunlap@infradead.org,
        mark.rutland@arm.com, zhuo.song@linux.alibaba.com,
        renyu.zj@linux.alibaba.com
Subject: Re: [PATCH v11 4/5] drivers/perf: add DesignWare PCIe PMU driver
In-Reply-To: <20231121013400.18367-5-xueshuai@linux.alibaba.com>
Message-ID: <aaf365bf-ada5-a52-c35-d7dd2d598b49@os.amperecomputing.com>
References: <20231121013400.18367-1-xueshuai@linux.alibaba.com> <20231121013400.18367-5-xueshuai@linux.alibaba.com>
Content-Type: text/plain; format=flowed; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ugnLTXI03PJ22oKRtsObFlQ1aD2s/60NgRXwAc2pcZCzWnyfFTJ3M6VWoH2b?=
 =?us-ascii?Q?SeLNMS13qqPznFwONAfQVFACBNgZv13VcmUqT6KT7++U8oXDtM3UMI09aAwo?=
 =?us-ascii?Q?nZjcyLGMiVhE7lENtBCKPYwCO9iWEPSy7K12NeN64D+AMXeG/lo5d039AD9D?=
 =?us-ascii?Q?5ZVnILwToLa113KUsKJsvKNoCyQq26YDSwd8XDUpP1kpBOgaXjjOrLchng3P?=
 =?us-ascii?Q?HxbQWwO8tdG82vJlB4T0EkkePMhLb8rd10KO2aKdccO/7w+1Ktj7piRgq0be?=
 =?us-ascii?Q?3KOBufCb8bSUN9jqZXI+xDVN5wzNIpGc/BPqvAyQHqcDkq5gVt311zi8LfZY?=
 =?us-ascii?Q?8LR4H1QLJj/X1BaOIyaQUSjmc2LhftdnCQdB35Ia6cPRf0ANOkBQ6+cs9jHF?=
 =?us-ascii?Q?cMslca6YTg8n1rOJJ3WYp2CLpTWCcX0zOXHZ6KRhWmbKVf6OpC+l6nwXZQ5N?=
 =?us-ascii?Q?7qzxV9mlI02Z1MfQ10qCZMsxhuDrOEdlj+/9y6CUcJbDUcC39LetdwqsOWLW?=
 =?us-ascii?Q?Yz2V80eln6CvlMnmKL+6kymQsBOG0Ybz2w8b5bXpYTyia4vlz8ttx3XdDUsG?=
 =?us-ascii?Q?IxeF7/17KV3vFowF8q1Mk4A+LSW79aZoU7pjJOuoe38sfmbnLyCtvtKbEQkX?=
 =?us-ascii?Q?9cDrUpXSecIqe73BA1Tju7bL80NXX3l3VNEvMSPkBjDOqFPq8rJvxh3zA4ak?=
 =?us-ascii?Q?jeqg2SK/yKBubMptsK4uAaVTdmGM2X6aZ0VujG5Z75tzlidm5mb4hulXVmC5?=
 =?us-ascii?Q?yFcjonbKyaT8/tazYiukbZlkpJ1yrHdcFi0ZveJ3LHunDYVujXOkUId1DoyM?=
 =?us-ascii?Q?Q2PpRdWlzn3jpGcwVu620AkvXB5aw9h5mAlFUQghFPbNaVUR46edRRRWK3wP?=
 =?us-ascii?Q?6sLuiGXPDp1/ABOmOle2m3T4tMlj5HXI0+7BryVUFkFeRmmqkgsehj62PDHp?=
 =?us-ascii?Q?uDD3PjIj/kQAfN5iSBG+ZEAhoKYasLNEnj3fssAQgNmnrR1GMiCay6OHxSsX?=
 =?us-ascii?Q?bs0oKSSmvXjb6/FdQqsD+ir1e5+RMk3MBMsfHbhYQ+nL4EiDDHqW8qd1Damd?=
 =?us-ascii?Q?U/1al4FyvKoUGqJHV2BlOcYpqSuJL1Knj7wLYoa6IepYgw1DxxoLyAbb6yiQ?=
 =?us-ascii?Q?bjT9eRUJNUCxY+qIWek9jjP12xpPknF7GyzLosUtHzneGm73dlYHxdoVCJhb?=
 =?us-ascii?Q?1rtmt0o3fY0DpCFygfIITrFqjut80RbzVd1Qp9Ao76V+nq5rRjIg9RJ3YSEQ?=
 =?us-ascii?Q?urtMn0kQP1UyAwU6wOhz1kZIQtc6JJ6M2wnW2VtdaxzanbBS5XBZttxrjOWu?=
 =?us-ascii?Q?62b5KylbgbLONeCuxhbJJOW1mFzH2ulLeqX+kOL6naEgfOkyrlQ0gdBQeonr?=
 =?us-ascii?Q?TNEDj9AiLGct/1pdo/CswSrWXuutpqNr5YFBTiISnlFLk39xmPyBNZqu95pQ?=
 =?us-ascii?Q?dNeXRsoS2akU1E764Gre9n95CkH12K41LvnDlsYOhaQJJf/GDofs/fcxAM05?=
 =?us-ascii?Q?alpwCfu1OCcMEWdQ6rhv/bDFt4cHexjvQUSCYzvVnBaN7LrLCFR/YLtkFTfG?=
 =?us-ascii?Q?7r3TObUape5KTp67OhoAmNQsvfKS7wBmkAtSVN5SrONbZGaLxqZWUoLb1/W8?=
 =?us-ascii?Q?0AHZE0UYtXCFKIMx/CShRGs=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e137b57-2f9e-4fb5-6f2c-08dbf145c182
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 01:43:31.0137
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fmE09Af18vNgfnDFusU0j+wMeSj3/Z4No+3f8TrlMEVUnLTfWpoaSJfiIxI68/80l1Kr4rp3ZxA6Ht8zRyIkDGQRgCupxGZUYlNSoQEvkFx7jMxZOf/2rd2Lwl/zSToA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR01MB7179
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 29 Nov 2023 17:43:40 -0800 (PST)


On Tue, 21 Nov 2023, Shuai Xue wrote:
> This commit adds the PCIe Performance Monitoring Unit (PMU) driver support
> for T-Head Yitian SoC chip. Yitian is based on the Synopsys PCI Express
> Core controller IP which provides statistics feature. The PMU is a PCIe
> configuration space register block provided by each PCIe Root Port in a
> Vendor-Specific Extended Capability named RAS D.E.S (Debug, Error
> injection, and Statistics).
>
> To facilitate collection of statistics the controller provides the
> following two features for each Root Port:
>
> - one 64-bit counter for Time Based Analysis (RX/TX data throughput and
>  time spent in each low-power LTSSM state) and
> - one 32-bit counter for Event Counting (error and non-error events for
>  a specified lane)
>
> Note: There is no interrupt for counter overflow.
>
> This driver adds PMU devices for each PCIe Root Port. And the PMU device is
> named based the BDF of Root Port. For example,
>
>    30:03.0 PCI bridge: Device 1ded:8000 (rev 01)
>
> the PMU device name for this Root Port is dwc_rootport_3018.
>
> Example usage of counting PCIe RX TLP data payload (Units of bytes)::
>
>    $# perf stat -a -e dwc_rootport_3018/Rx_PCIe_TLP_Data_Payload/
>
> average RX bandwidth can be calculated like this:
>
>    PCIe TX Bandwidth = Rx_PCIe_TLP_Data_Payload / Measure_Time_Window
>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
> Tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>

Looks good to me and seems to work fine. Thus,

   Reviewed-and-tested-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>


You can keep my "Tested-by: ..." in the other patches.

Cheers, Ilkka