Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 30 Nov 2023 03:29:27 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     zhiguojiang <justinjiang@vivo.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue
Message-ID: <ZWgBl07bJqrLTpzZ@casper.infradead.org>
References: <20231129130126.2130-1-justinjiang@vivo.com>
 <ZWdWFx1mXl29dP5U@casper.infradead.org>
 <dc01e0d2-17db-4531-bc7d-7d637d96c2f1@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dc01e0d2-17db-4531-bc7d-7d637d96c2f1@vivo.com>
Precedence: bulk

On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote:
> > > -		 * If kswapd scans pages marked for immediate
> > > +		 * If kswapd scans massive pages marked for immediate
> > I don't understand why you've added the word "massive".  Do you mean
> > that the pages are large, or that kswapd has scanned a lot of pages?
> The added "massive" means that there are a large number of pages marked for
> immediate reclaim on evictable LRUs.

Then the word "many" communicates your meaning better.  "massive" would
mean that each page is very big, while "many" means that there are a
lot of pages.

It was foolish to send out a v2 so swiftly.  Best wait for someone who's
familiar with this code to respond to it now that you've clarified what
you were doing.