Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <620915e2-7b4d-40b0-9af3-71abbc18d586@vivo.com>
Date:   Thu, 30 Nov 2023 11:40:06 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm:vmscan: fix shrink sc->nr counter values issue
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
References: <20231129130126.2130-1-justinjiang@vivo.com>
 <ZWdWFx1mXl29dP5U@casper.infradead.org>
 <dc01e0d2-17db-4531-bc7d-7d637d96c2f1@vivo.com>
 <ZWgBl07bJqrLTpzZ@casper.infradead.org>
From:   zhiguojiang <justinjiang@vivo.com>
In-Reply-To: <ZWgBl07bJqrLTpzZ@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmFqREpibFZiM29DejJrWGpEOVo0aGlqK1RiM2FDWEZReFFLdElDQWpvVTJ2?=
 =?utf-8?B?dCtTeFNYZmNxekQ0YmZLcENjRm14eUxZMkZTRXBuczJCbGJkQXVVTU1Jd0pk?=
 =?utf-8?B?aGUvSTlrL1hmWVFxdDI1SS9YaVhYRGQzNGFEZDNRQ0lIaCtSUUVFcFI5clhQ?=
 =?utf-8?B?NUVnNFFNOVh4dEZlcUw5eHgvNzFwWkVKY240Tzd3TmgxWVJINHN0aDFXWm1p?=
 =?utf-8?B?cXlRR1FiVEFFYk5TWlhyVFd0Tk9VOVh5Vy83MUdFajFDcE9CUGFEOFZRVnp4?=
 =?utf-8?B?N254U3A2ZkpleHl6bFJwNFluenN5bmdBK3BLQUZpNzBVcFBPWVlwUXFYMmcy?=
 =?utf-8?B?NXJsM2Y1UVp0NFVhcFpPSEs4ZGswd1I2cVJpa1dIL1BCU1kyMndrNGJTcXQw?=
 =?utf-8?B?RWlWTGN4TTUxek11MlQycmpMWmJwRjdXKzJ6c3Vways3UXhVN1hRWGxleEhC?=
 =?utf-8?B?UmRUZWwrSHpSUDlUSk8rZE1NTG9UcUYvSHgybmxvSGFLNk1IcVdFUGNzTVUr?=
 =?utf-8?B?Zk1CYVdUR2I3dUEwYXducDVjN2tFV0J2anNsbUJ4UGZkQ0EyTmpHQmtHVkRK?=
 =?utf-8?B?ZkN5NWNuK2l4Y2daT21ZVjlGdGJhWTVKK1JWSDgrbVI3VGpGb3NsdEQxWWt5?=
 =?utf-8?B?NHRyZE9SZ1FKMU9NM2hMNjh5ZkhKOENtRHRQcDg5UTNHUUJYY0VlZTc4TWw4?=
 =?utf-8?B?eFdmMGJRUkE5S1N3VTJmL3c0cUloNjdNQjJjN3FqcFl4YXJoN2ZLM1JCN2pN?=
 =?utf-8?B?OTcwY1k1MzI0aEMvUVYwYWpFaWlUWTNXdVV1WXVISW96cmlTV1J0eWl3SWVh?=
 =?utf-8?B?dTJlSXcwaDZSSmlESFRqOTV0QjNSb0RyczZUQzUxeTFoQm80R3c4bHVQOS9Q?=
 =?utf-8?B?M2Z5eGZRcTFMRzV3TzlQZk12UGlBZ1lGQnlkNWRpZ244VEhVbno0SUR3Ui9z?=
 =?utf-8?B?WXpoUzlEbDA5NEpqSlY0ODJadkh2VTFON245RzFqM08wNVMvb3kxU01oZEJ1?=
 =?utf-8?B?T3ZsQ2xSUk9hMnMrL2lHdXpGQzlwYWxBZ3M5a05JL0lBRDJ1b3lYUmszdW41?=
 =?utf-8?B?WkxLZWR4d25RSktueHJhc1BtOVUvN0dPWEx1WWQzUEtiWUd5VlJBVERmOTZE?=
 =?utf-8?B?bjh2OHZzb2FZMUo5eERPdmR0RE8vQ3Z4V0dHdlhjbUY4UFloV0xFdWdLYktH?=
 =?utf-8?B?OHllcWJiVUJrRGJLMnEzaCtWeVFmeGlIcHpHRis5RUxldFRmcXVkSEZXa084?=
 =?utf-8?B?Mk5yZG8rZEdRbFgzNUtURWFkYTEwZ2hmNzA1MG04eWJWV25JZGhoVEdBelBT?=
 =?utf-8?B?SmZDZWgrVTdNdng4WmNlc25pS0I5ODV4RDQ0VVkwU1RHaUdPT1hJV0xTWUsy?=
 =?utf-8?B?R1VIbVFlRkY5N2VETWErNWlibjlwTkFXQmZrTThlNEhRL1FMOXYxMmczM1lN?=
 =?utf-8?B?T2FBcG9WSjdWWEM0Q1M3QXlMRlIzaFJyOFZpMlVPcTlOYTZITXN1Z0NERVll?=
 =?utf-8?B?STk5d0ZpQUdsYXpWaC9EN0JLT1NZSzRtQ01SSXg4VEJDWnQ0T3g3U1pMd0xG?=
 =?utf-8?B?cnRpd2EreUUzNlROYnVRNnkxenBXRFo1ZU44YTVnTGhrZFM1VjNJcXQrcSsy?=
 =?utf-8?B?OVU4a2tGb1JWSjdSWldIb1A2Y2hPZU9mQUpxdDNseTlOMjFqRFZDOVByZDFS?=
 =?utf-8?B?VTJuZUc5MlBNS1A0MVkxclM3YVliQzBLYk1QbEtOcWVSZDhjTVNKZFd3Q0xQ?=
 =?utf-8?B?cVdCOUF3MHc1ZjJlYUFYR0ZoRnJaMkQ1dHB6TWMxTFAzcVpZNlA0b1JiWGFK?=
 =?utf-8?B?Q2RvSk5MN1pZcmk0eVI4QnJmcURkcW1LUmhYY0xtTVhQeU9xV1pLRFBOZ0Er?=
 =?utf-8?B?TVBvZElrZFNmUDBxZ1lFVm02aFBabkNmU2tvNVhUMGcyb2tiUCsxMmVTZ2Jr?=
 =?utf-8?B?cjFYYXhMdnN2d29OdU84c2Fwdm5idko1T1o1NzJwK0FsZUNkTk5JRGJhOEFP?=
 =?utf-8?B?cDdrNjNEa1I5YWM1VHZxQXZBWUw0UVVoR2NGUWkrMU5odkVENm1IektvSWdz?=
 =?utf-8?B?Z2ZUaDhtbFlZSTFrTG8rSDBDa2NsMjgwYnU3bDQ1SGowdUExTVNZRHRYZGZW?=
 =?utf-8?Q?bowi6uyD/oq9gpl2AOFFctWg6?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9f5afe3-76f6-4b8e-5e07-08dbf1560d34
X-MS-Exchange-CrossTenant-AuthSource: JH0PR06MB6849.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 03:40:09.4887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ei111plG9vGR44NBEkyo2z7Frcx2A/nNijYGzfRsfHrZjEdjmnl4eVdLdlrdwXGqKQFbdapXmLVNGJ4YyuEBPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5644
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 29 Nov 2023 19:40:31 -0800 (PST)


在 2023/11/30 11:29, Matthew Wilcox 写道:
> On Thu, Nov 30, 2023 at 09:56:59AM +0800, zhiguojiang wrote:
>>>> -		 * If kswapd scans pages marked for immediate
>>>> +		 * If kswapd scans massive pages marked for immediate
>>> I don't understand why you've added the word "massive".  Do you mean
>>> that the pages are large, or that kswapd has scanned a lot of pages?
>> The added "massive" means that there are a large number of pages marked for
>> immediate reclaim on evictable LRUs.
> Then the word "many" communicates your meaning better.  "massive" would
> mean that each page is very big, while "many" means that there are a
> lot of pages.
>
> It was foolish to send out a v2 so swiftly.  Best wait for someone who's
> familiar with this code to respond to it now that you've clarified what
> you were doing.
Thanks for you suggestions, I will update the newer version patch later.