Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 30 Nov 2023 04:15:22 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Su Hui <suhui@nfschina.com>
Cc:     nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com,
        akpm@linux-foundation.org, fmdefrancesco@gmail.com,
        ira.weiny@intel.com, tony.luck@intel.com, jiaqiyan@google.com,
        pcc@google.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] highmem: fix a memory copy problem in memcpy_from_folio
Message-ID: <ZWgMWricKKnwhWPh@casper.infradead.org>
References: <20231130034017.1210429-1-suhui@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231130034017.1210429-1-suhui@nfschina.com>
Precedence: bulk

On Thu, Nov 30, 2023 at 11:40:18AM +0800, Su Hui wrote:
> Clang static checker complains that value stored to 'from' is never read.
> And memcpy_from_folio() only copy the last chunk memory from folio to
> destination.
> Using 'to += chunk' to replace 'from += chunk' to fix this typo problem.
> 
> Fixes: b23d03ef7af5 ("highmem: add memcpy_to_folio() and memcpy_from_folio()")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>