Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "Drewek, Wojciech" <wojciech.drewek@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        Simon Horman <horms@kernel.org>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for
 floating VEBs
Thread-Topic: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for
 floating VEBs
Thread-Index: AQHaHueb3TthdEMi20K/mTgaHAM96rCSWP4A
Date:   Thu, 30 Nov 2023 05:23:12 +0000
Message-ID: <BL0PR11MB312217E7D7C7AF4B57DE691CBD82A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231124150343.81520-1-ivecera@redhat.com>
 <20231124150343.81520-5-ivecera@redhat.com>
In-Reply-To: <20231124150343.81520-5-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gV8O6vHmHS2nahERGounrTS0imQV4JnkRCOYYp7LcRpm+fX/6JeyXVt2Y0Vn?=
 =?us-ascii?Q?pc2o/CzGJAVGXazZmag95DGhxn2MpQnQ9Ztd7oiaan1552FLwKoVtnmpua5+?=
 =?us-ascii?Q?RGsTOJdtm1f/s04SRY4ntYtX/QW+VIUsIQN0JhoECt3H6lzzXbD98Dz1HT5N?=
 =?us-ascii?Q?748P86KiV76g8FfFi6dFRIFxWy95YdAobGBTNHl2thr1Pc5FCASGZMp8ltwo?=
 =?us-ascii?Q?CR7xqrIay2sdrsocU9aMpvdPjJlgCW0amVk1Vl3Yitq16aBd73q8tAA65c+b?=
 =?us-ascii?Q?3JyJ0lO+T7IIuk6eMb+OwSJz6GzsnvsJLUNLan9mUXCkLnkKeLHNQlFpPeEd?=
 =?us-ascii?Q?Uo3/moaW9hAB3XIbNCTmQITBpjghKDTUr1MS66dN9GDiIU7+uSqLqvZnENVO?=
 =?us-ascii?Q?+O1efT6pIjfRxe1rNGHADmD/l4wLbDMW9RtQy3pu2z8AdDgqOCg8hSOuyeVl?=
 =?us-ascii?Q?2Lgvr3Sr3sYuVRCjDV3+HisdSkhxjPXapyEe2M8u4dDRm4rEFEcShddSp9Ag?=
 =?us-ascii?Q?YZayibyAqAV4RhF/dmPT47r9WUCxcf8Tmh9V6rqOQpn33GOzj9co/DZVAU9o?=
 =?us-ascii?Q?sM8cgOkodrUWykmfJjME3WI4u8VrqZ3i6Y0xl1D6qgtAKfK3HUXSjoqIpR20?=
 =?us-ascii?Q?SP8WHh/9Bmk0Q//l6F79lYGo8DbZAh7UCkz9BHbrjptJm/H/stg0LqXBtcqF?=
 =?us-ascii?Q?2i2lVRVC+7RnYiCneHzJNqok/zNMI0IwC7TDyEpMj/y7Qo1uYhQtRLzC5WBA?=
 =?us-ascii?Q?DfMZhLp+u4xPUp2jSidG9xjr7M2kjVH1RtUYjNnlh8JHZiIvP35NLDCazvAx?=
 =?us-ascii?Q?cUwXhk/pBPcmuyfwI90/7ALlyjblUcmxSI7XDtR5N8/oF2TSc0/4qhQuZxHs?=
 =?us-ascii?Q?1NjcbNv9rfZARRvb+ZT2Tlf0aQXHBXNFXfne7NPoCpdxNPyZfxb6f3kx3Fwy?=
 =?us-ascii?Q?tZQHszOx3xfyL6fPW2gW3jJa2pE7Z0DnXzd4NvzZ8VW8Q1ciBkKfEfs9Pzvr?=
 =?us-ascii?Q?IUXIJuJeiEzIdzfCwTPSOG7l/q3GFoATAv3EKXOOoHvpzGB/v3CBZHVnfEyz?=
 =?us-ascii?Q?JzA81gYg5A3T5jX6TVvc5qjmijAQEIgMThw5k1LHSg82ejgFWmvjnQ21pesY?=
 =?us-ascii?Q?YRd9RwUH6oSXLWmywfb9OiSTrKxs3cf+y88QFwQGRtO/3az2IJldtNX27mTQ?=
 =?us-ascii?Q?37jN2OTZJTKjfaYgfIAXL2rcemHKsebRbaGGQW5ZEmkVokKy5CkCzqIY50VX?=
 =?us-ascii?Q?qfo3uMP/lY33GQRFWP0mxBzAHDm9AkME5n0pr3BC1Bla25eTTBqh4wD1kepu?=
 =?us-ascii?Q?y7HV2oPrMlGgNULeK+li8FQljnFTMjr/V/mFhYFWzGDc2QlPhZX+A+mR95QR?=
 =?us-ascii?Q?cOTks6Im6oDaYowmXSscdA0PNdNkYrqkFTNa+26W+85JvKBS77qjxYCSqdg5?=
 =?us-ascii?Q?mSJuJWdbCbL3drC0nVJeSlMbsxQam8f4esTJ2f3lZRt5JfDOrx3CvZbt0APl?=
 =?us-ascii?Q?Cm3tIQVoMiEKke/tWgOq8WG5NNwodorkAlrjxM3CBIO3aJWhNXaX/xBKd0Qq?=
 =?us-ascii?Q?+ZIUE3C0appWk9P+NHxSEYTDFdz94ymc79Um2+93dsMpuhMML1NDr02IcCnB?=
 =?us-ascii?Q?7g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee2a90e-b25c-44f2-b806-08dbf16472ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 05:23:12.5905
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AQAsJXMLJNqxxSjHKbOjAMvbK3t83dbPIv0R70lRdE+3xUEseEOKARQEYO3NQNVTPi9ytnU/GuEUkiC/SnPyaq+/VbdD92ZwAF0R6nUaS+tRYe9+86SHcGpLqKI+PiG8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6198
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 21:23:47 -0800 (PST)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of I=
van Vecera
> Sent: Friday, November 24, 2023 8:34 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; netdev@vger.kernel.org;=
 Brandeburg, Jesse <jesse.brandeburg@intel.com>; linux-kernel@vger.kernel.o=
rg; Eric Dumazet <edumazet@google.com>; Nguyen, Anthony L <anthony.l.nguyen=
@intel.com>; Simon Horman <horms@kernel.org>; Keller, Jacob E <jacob.e.kell=
er@intel.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat=
.com>; David S . Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH v5 4/5] i40e: Fix broken support for fl=
oating VEBs
>
> Although the i40e supports so-called floating VEB (VEB without
> an uplink connection to external network), this support is
> broken. This functionality is currently unused (except debugfs)
> but it will be used by subsequent series for switchdev mode
> slow-path. Fix this by following:
>
> 1) Handle correctly floating VEB (VEB with uplink_seid =3D=3D 0)
>    in i40e_reconstitute_veb() and look for owner VSI and
>    create it only for non-floating VEBs and also set bridge
>    mode only for such VEBs as the floating ones are using
>    always VEB mode.
> 2) Handle correctly floating VEB in i40e_veb_release() and
>    disallow its release when there are some VSIs. This is
>    different from regular VEB that have owner VSI that is
>    connected to VEB's uplink after VEB deletion by FW.
> 3) Fix i40e_add_veb() to handle 'vsi' that is NULL for floating
>    VEBs. For floating VEB use 0 for downlink SEID and 'true'
>    for 'default_port' parameters as per datasheet.
> 4) Fix 'add relay' command in i40e_dbg_command_write() to allow
>    to create floating VEB by 'add relay 0 0' or 'add relay'
>
> Tested using debugfs:
> 1) Initial state
> [root@host net-next]# echo dump switch > $CMD
> [root@host net-next]# dmesg -c
> [  173.701286] i40e 0000:02:00.0: header: 3 reported 3 total
> [  173.706701] i40e 0000:02:00.0: type=3D19 seid=3D392 uplink=3D160 downl=
ink=3D16
> [  173.713241] i40e 0000:02:00.0: type=3D17 seid=3D160 uplink=3D2 downlin=
k=3D0
> [  173.719507] i40e 0000:02:00.0: type=3D19 seid=3D390 uplink=3D160 downl=
ink=3D16
>
> 2) Add floating VEB
> [root@host net-next]# CMD=3D"/sys/kernel/debug/i40e/0000:02:00.0/command"
> [root@host net-next]# echo add relay > $CMD
> [root@host net-next]# dmesg -c
> [  245.551720] i40e 0000:02:00.0: added relay 162
> [root@host net-next]# echo dump switch > $CMD
> [root@host net-next]# dmesg -c
> [  276.984371] i40e 0000:02:00.0: header: 4 reported 4 total
> [  276.989779] i40e 0000:02:00.0: type=3D19 seid=3D392 uplink=3D160 downl=
ink=3D16
> [  276.996302] i40e 0000:02:00.0: type=3D17 seid=3D160 uplink=3D2 downlin=
k=3D0
> [  277.002569] i40e 0000:02:00.0: type=3D19 seid=3D390 uplink=3D160 downl=
ink=3D16
> [  277.009091] i40e 0000:02:00.0: type=3D17 seid=3D162 uplink=3D0 downlin=
k=3D0
>
> 3) Add VMDQ2 VSI to this new VEB
> [root@host net-next]# echo add vsi 162 > $CMD
> [root@host net-next]# dmesg -c
> [  332.314030] i40e 0000:02:00.0: added VSI 394 to relay 162
> [  332.337486] enp2s0f0np0v0: NIC Link is Up, 40 Gbps Full Duplex, Flow C=
ontrol: None
> [root@host net-next]# echo dump switch > $CMD
> [root@host net-next]# dmesg -c
> [  387.284490] i40e 0000:02:00.0: header: 5 reported 5 total
> [  387.289904] i40e 0000:02:00.0: type=3D19 seid=3D394 uplink=3D162 downl=
ink=3D16
> [  387.296446] i40e 0000:02:00.0: type=3D17 seid=3D162 uplink=3D0 downlin=
k=3D0
> [  387.302708] i40e 0000:02:00.0: type=3D19 seid=3D392 uplink=3D160 downl=
ink=3D16
> [  387.309234] i40e 0000:02:00.0: type=3D17 seid=3D160 uplink=3D2 downlin=
k=3D0
> [  387.315500] i40e 0000:02:00.0: type=3D19 seid=3D390 uplink=3D160 downl=
ink=3D16
>
> 4) Try to delete the VEB
> [root@host net-next]# echo del relay 162 > $CMD
> [root@host net-next]# dmesg -c
> [  428.749297] i40e 0000:02:00.0: deleting relay 162
> [  428.754011] i40e 0000:02:00.0: can't remove VEB 162 with 1 VSIs left
>
> 5) Do PF reset and check switch status after rebuild
> [root@host net-next]# echo pfr > $CMD
> [root@host net-next]# echo dump switch > $CMD
> [root@host net-next]# dmesg -c
> [  738.056172] i40e 0000:02:00.0: header: 5 reported 5 total
> [  738.061577] i40e 0000:02:00.0: type=3D19 seid=3D394 uplink=3D162 downl=
ink=3D16
> [  738.068104] i40e 0000:02:00.0: type=3D17 seid=3D162 uplink=3D0 downlin=
k=3D0
> [  738.074367] i40e 0000:02:00.0: type=3D19 seid=3D392 uplink=3D160 downl=
ink=3D16
> [  738.080892] i40e 0000:02:00.0: type=3D17 seid=3D160 uplink=3D2 downlin=
k=3D0
> [  738.087160] i40e 0000:02:00.0: type=3D19 seid=3D390 uplink=3D160 downl=
ink=3D16
>
> 6) Delete VSI and delete VEB
> [root@host net-next]# echo del vsi 394 > $CMD
> [root@host net-next]# echo del relay 162 > $CMD
> [root@host net-next]# echo dump switch > $CMD
> [root@host net-next]# dmesg -c
> [ 1233.081126] i40e 0000:02:00.0: deleting VSI 394
> [ 1239.345139] i40e 0000:02:00.0: deleting relay 162
> [ 1244.886920] i40e 0000:02:00.0: header: 3 reported 3 total
> [ 1244.892328] i40e 0000:02:00.0: type=3D19 seid=3D392 uplink=3D160 downl=
ink=3D16
> [ 1244.898853] i40e 0000:02:00.0: type=3D17 seid=3D160 uplink=3D2 downlin=
k=3D0
> [ 1244.905119] i40e 0000:02:00.0: type=3D19 seid=3D390 uplink=3D160 downl=
ink=3D16
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  .../net/ethernet/intel/i40e/i40e_debugfs.c    | 29 ++++---
>  drivers/net/ethernet/intel/i40e/i40e_main.c   | 87 ++++++++++---------
>  2 files changed, 67 insertions(+), 49 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)