Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <fc2390cf-bdf9-590e-d078-4bb616d5feb6@amd.com>
Date:   Thu, 30 Nov 2023 11:58:15 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] perf/x86/amd: Reject branch stack for IBS events
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ingo Molnar <mingo@kernel.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230602194513.1589179-1-namhyung@kernel.org>
 <c5a40920-0b14-b9b5-19ee-48c965bd12e3@amd.com> <ZV9lfJyyC7xawHBC@kernel.org>
 <3d70b52f-2042-328c-6dc7-37fcbb3510a2@amd.com> <ZWSombzfCkxHc7lC@kernel.org>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <ZWSombzfCkxHc7lC@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmpGNFBhaWhEb2Y0VXJVUVhKNHVRMmYxWnFiSXZpUUtrRkhnYW9Vcnd0Wm9s?=
 =?utf-8?B?Ymd1aXpMbVBjUnVjSVZudzU3TmdrVkgrbFlNaVlkbVFwQ2JvcTJCemNWblBs?=
 =?utf-8?B?MWk5QU9Gak8zUVZkdVMzU2UxdWVjRStQWUt2VnVGRHlwZFk2Qk9BUFNqVHQ5?=
 =?utf-8?B?enBDcHA0N2ZSVE1GTVNza0U5cHRtTzVlMUo5bWIraXJRenAraGtWSmFXT0tv?=
 =?utf-8?B?SDROVkg3d2hCbTgwaXdTWms3MngzUE5qZkw3S2FMdDAxYmVlZno1S3F4eW43?=
 =?utf-8?B?U2NnUE9GdzYxSEtrZk45clByOXdBd3ZHSzNvalR6YVhPYlhSN3EyU25KejIy?=
 =?utf-8?B?L1hZb2MrTUt2TjloeExPc2U2Wm0yRDh1Nkx6WlFCbVdackU4TzJHZUlnY3Jy?=
 =?utf-8?B?dENCWnJrbzRNUDhRcXN5azdTV0ZqajR1eDRpaVU3dDRuRHgweGN6WVRnNGF4?=
 =?utf-8?B?Vkc2d2JpdnUwWkNraVF5T0JRcTZYeFVodDRvNyttWWdBVTI1QUcramt5MEdP?=
 =?utf-8?B?TlVueE9LUkNxT29CWjRIRTlIUkNadk5TdzFZSTA1UEdBNWZKSmtVUFVwYXpm?=
 =?utf-8?B?K3BMTDVGR3JRbTUrSUhCOGhpZGFsbHAxc3cvWEp2L2xrT3MzYnU0U3NCWTh0?=
 =?utf-8?B?cVcxRzExd05DOVZVRHlwSWZVVXFvalRvVEhmQWJ3V0IrRzVXTGpZN3dMRXFp?=
 =?utf-8?B?VS9UOGpuUWg3YksyQUVyRkkrTzc0UDNIWnBuTTMxenN1d3ZZQ1dDZ2lYZHBY?=
 =?utf-8?B?QTl2dkxaaUpQS05KdEVhRE9BYUNZdWNqeWhSUEpIVEtIYWR3aEsvaWRlZVRr?=
 =?utf-8?B?UGdid0Rxc2VmVnljdjAvdWs0LytlYXJMV3VCZUlPVnBvdkVKaFkyVER4ZEdW?=
 =?utf-8?B?NDJMWGMxbHpFN2VtMVdISHpvZmZ5ZktkMkxGQVhqb1RsNW5JYlU4S0VRMWlm?=
 =?utf-8?B?MjBmV0RYS3FrMHMyZjgwME5uUnFsVUY4TDVvQmxGSXJrcnNiMXoxbHMvT1Fa?=
 =?utf-8?B?U1MvZlpoS0FmUHhnTXRVUk8zcERYczhXSG1yTnZmYjFPUGNwNzBBVmdoZHYw?=
 =?utf-8?B?a011WlVBdEMrTnlwVDNkczY2TmJ2UHlLcm44YWwyN2JVWk9LKzNWcThuam5J?=
 =?utf-8?B?YmlTczlFVnVDVEErU3VEbjVMUFZHYnY0ZGVWcjkvVWs3dlIvODJmang3cmlz?=
 =?utf-8?B?WVQrQThRTi9oMXpScFJONng2VEI0WndFbFpTZDdtamgwTmZ2RkcvT3FEeG0y?=
 =?utf-8?B?b2lKVXhZL0c2OTZPZGZ1V1pLK1ZKUSttdFpKT3NtQnNuYUpNYnc5MFVqVlZq?=
 =?utf-8?B?MktPNmI5K2tQaUZ6NWl4ZzF1a3FwQ1lHc3BaUFBwa3ozVmJCZHMwYTc1SlZT?=
 =?utf-8?B?UHBWV2ZRdXNuZ1lIVUxEejFKWjM4djI1cm50RkRraVV1V1IrYytWNUxsbklo?=
 =?utf-8?B?YVhOTE10MEJHVmErcFJxSmNpOGUxRFowdDluWE9PeVVxRkl3ZlZFazJ4bVhX?=
 =?utf-8?B?N01rUFVTYjFvaTZMUExKM01mS3c2dVMvRldIWldBZ0RweTNHQUg0cGZUOVJv?=
 =?utf-8?B?aXBuUGhtbWxOSFlLbTJER0NMdDNZeU9uZVVzVUNZaEVmbDJkT0gzWVBqYUsy?=
 =?utf-8?B?ckN1SVk0RWt1b2prUUtldTJJZG5GVzdxV1RlMFEweDhKd3VvS3pJbHBMVDVQ?=
 =?utf-8?B?V0lybkYzWlY3M2hoRWwxMFNZZ1lMa0ZqWnBHdjR5VlYxNXB0QXdkTGlWNVdv?=
 =?utf-8?B?QjUzU1dVZEFXOENrd3hhODFMaWg1VEVHQjJMQ205TGUxeXNseGJWZExFRUpC?=
 =?utf-8?B?TkVhZ0xZYnY2QS9leTBObEpzQlp5Y3IzR1RiTC9aVFhzQkFhdnpucExPZ2Yw?=
 =?utf-8?B?OHkxN3YrMmZtd0ovRXJkSVVxUG9WeUttc2YzVDhWblhaemNxdlhRS21FSXM5?=
 =?utf-8?B?dXNVS2ZyRVZTa0NMS1pMcWJHakhTYWV6K2I4YVRvZlF0cGQ1eXlXTkRha3Aw?=
 =?utf-8?B?azBxVTAzcUhFYThmNWpPSXJpYmVmc1RvVTBqaStPa3lXcjBrekxNR2lhcUJ6?=
 =?utf-8?B?S2cvWGdveG5PdFViUTdGYzVRV2RnckZ4VWJGeEVzSTVnaHphblZ3UGM3TE8y?=
 =?utf-8?Q?+h04QYvuq6lbyydznSLVNnT1h?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a3792ff-a722-41a1-a453-08dbf16d8df1
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 06:28:24.1809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Uv9xUfP0ZdECbvCI8VgTlXJWRg4Uakbefoi4bVgoF5AYGfrjc0eI4KJSq8SfwBUdRca6/bRSRo5x4pw7OmT0lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6495
X-Spam-Status: No, score=-3.0 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 29 Nov 2023 22:28:45 -0800 (PST)

On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu:
>> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu:
>>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote:
>>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept
>>>>> events with brstack.
>>>>>
>>>>> Cc: Ravi Bangoria <ravi.bangoria@amd.com>
>>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>>>>
>>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>>
>>> It seems this patch was not merged, can you please check?
>>
>> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since
>> surrounding code has changed.
> 
> Can you please refresh it if PeterZ has nothing against?

Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com 

Thanks.