Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Corey Minyard <minyard@acm.org>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>
Cc:     Phong Vo <phong@os.amperecomputing.com>,
        Thang Nguyen <thang@os.amperecomputing.com>,
        Quan Nguyen <quan@os.amperecomputing.com>
Subject: [PATCH] ipmi: ssif_bmc: Refrain warning printout when aborting request
Date:   Thu, 30 Nov 2023 14:28:49 +0700
Message-Id: <20231130072849.3075741-1-quan@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gKf4R/VhNC/5lwIhUsittu0Mig3idFm5IpzTjJhiVab7vp91ZomJkl0Up94J?=
 =?us-ascii?Q?4cDt2bnsy63/AbgKRhnpWH64mjml7YVjCiMw4NMqOwmDhgbvV/Dq3kPqjtRu?=
 =?us-ascii?Q?lwNy1rRpW9XNGtgYMRkW5qJjDvjMaLuJ/IZYeWzZLD/ivUWFL4qjZnrTfzbK?=
 =?us-ascii?Q?/sQYQDN+H87NTiNnPEnSkakl7+OruIBdkLnn6E2Eq1bxGcNhLd6MnPvUg687?=
 =?us-ascii?Q?mcwyKsLWIqHZghVHHh1XCf5mKzRtEhs5nSyktCcZMVyeZAxGn36SvLie8pE3?=
 =?us-ascii?Q?kJ8DfA1321v1xoo+62J52KPoGeKDqAY3zakrBZLj6aT5QKb8Sp5zDP+zi8sI?=
 =?us-ascii?Q?mV38gCzr3hhmzFInzaWBVaE7K3tsuZ/7zePIX97ie6qvX3Gmcwiok4ojCalS?=
 =?us-ascii?Q?Hc7nnJMYtfnacyvFAJUhkdRwQ/ly7sud6oTs/+waN/XW+1Ir7Z4Fu0eLAE0p?=
 =?us-ascii?Q?luEl1Yh+0wDBzjjZAP+Mk+xbQkkTny86jQem7Ls6R8vj6jOEz/tLwty9iw5T?=
 =?us-ascii?Q?uZYFq3VDAmbD59SrsiWWpeancWb2cfLUa5Y+7W3yfR7vtrBwDbbmZAgBnUQE?=
 =?us-ascii?Q?Pba4nhY2yuQaT3e2pjJldawBszsI52gEsvZRzD+Pys4bt6klSp6dLG/2d0iy?=
 =?us-ascii?Q?7k/8TITVCI0GM4lE310gGgPEKLMEW7KnWzDG/tnaNhx4z9QINJl++Iq8soza?=
 =?us-ascii?Q?aw+kMwzazBu+2YPRMRoK9CpLhsXlLEbYpJbi11Zp9RSlb6cXvUO10ayaq03G?=
 =?us-ascii?Q?flrAeY4TW9vd2R6R4DmHYQoYxd8zmog24zgFE3MXEaeGGYpv3vwAXvrLJFEZ?=
 =?us-ascii?Q?ztYxLFm2EG3et4fTFkoK7SHJ+NcauctgrTwv444kOqsVGVdYTVNYpdzqweAL?=
 =?us-ascii?Q?zxdFhyVYCdbwqUz98aRzDi40/1PhT6SzG6vqhFaa/COTWrN8bdM3Mavn0p3y?=
 =?us-ascii?Q?GfyT03mvb80kWxUULlmqdpMwSu8+kCY2DW7sP1hh7bIPQk9p5HL31y/N6r6H?=
 =?us-ascii?Q?5ey4ZSOnkb13s6U6Z00NwLiaUI89viT0fmkh8DMPj+ldRhC8aCAbYa/y9Lja?=
 =?us-ascii?Q?3TwALvfeXUTZILkclSqBkgRnscTkg2nWMyR2juZHe5IjIxknqBXV48ZnMBOU?=
 =?us-ascii?Q?dPF1FL4iNdLdu5OX+MB0LPHSryz665DqxqFMA4jiOdkvuABHisaWLPYqHGXs?=
 =?us-ascii?Q?pau8Kb2ZVCFKVIMTDy65U6NRdFaBWU9wMN96De8V7H8bRI4FNHblF6XaQLlz?=
 =?us-ascii?Q?wZL+qeXuOJ0e3/NKZQLHUkTui07Y6sxCrIEOiLmmvWa8cnTpblCTvSYzMEB7?=
 =?us-ascii?Q?QfEwoDgzVXhVTuXWhua36/NMN6GOCyqb56pu3M/kRQ6l0gzSVLOXl5lpJ1k4?=
 =?us-ascii?Q?IdEs836xXgcVkfx/OIJJdw647lTPYgDe10P2TMX63nZqV48VnfU3nKpAJdo0?=
 =?us-ascii?Q?AHUHShqp7l1Xmp4H39mZwL7acWr0TGHcfbopKlwQwdRzg204JH0QHDBW0ds/?=
 =?us-ascii?Q?ofz4S0Vpir0TRc88pGh8RrzXe0Kkx9K1bkUEjeDxsNocHf6F1Q285RJR+iXY?=
 =?us-ascii?Q?EjPWB6RNvQaKTzQsMT3LZk8OsI+M+ZTvcAYYbSNBY25iElTUSOgSFAnRnQ9F?=
 =?us-ascii?Q?oKjRB1p5N/V1B+misGe2KkE=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1e96be1-7384-471a-a85b-08dbf17610d0
X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 07:29:19.9207
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8cmUevkypJzaOxUwHmESvtnd+MbRmMgblSTwU2j6/KKlRWZPXQICt6RKgKIesomSDJK7Ezsg0AfDAWEjgZCe1leOtXwY1/3+djMHh9od4BM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6137
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 29 Nov 2023 23:29:37 -0800 (PST)

Ssif_bmc driver discards the current request if there is no response
provided until the new request comes, during that period, there are
multiple warning printed out as below:

"ipmi-ssif-host 0-0010: Warn: on_stop_event unexpected SLAVE STOP in state=SSIF_ABORTING
 ipmi-ssif-host 0-0010: Warn: on_stop_event unexpected SLAVE STOP in state=SSIF_ABORTING
 ipmi-ssif-host 0-0010: Warn: on_stop_event unexpected SLAVE STOP in state=SSIF_ABORTING
 ..."

This commit fixes the issue by refrain from printing that warning

Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver")
Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
---
 drivers/char/ipmi/ssif_bmc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index 56346fb32872..2857e7341d65 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -718,13 +718,15 @@ static void on_stop_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
 {
 	if (ssif_bmc->state == SSIF_READY ||
 	    ssif_bmc->state == SSIF_START ||
-	    ssif_bmc->state == SSIF_SMBUS_CMD ||
-	    ssif_bmc->state == SSIF_ABORTING) {
+	    ssif_bmc->state == SSIF_SMBUS_CMD) {
 		dev_warn(&ssif_bmc->client->dev,
 			 "Warn: %s unexpected SLAVE STOP in state=%s\n",
 			 __func__, state_to_string(ssif_bmc->state));
 		ssif_bmc->state = SSIF_READY;
 
+	} else if (ssif_bmc->state == SSIF_ABORTING) {
+		ssif_bmc->state = SSIF_READY;
+
 	} else if (ssif_bmc->state == SSIF_REQ_RECVING) {
 		if (validate_request_part(ssif_bmc)) {
 			process_request_part(ssif_bmc);
-- 
2.35.1