Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <a9db1de5ab4d2c8fc289654053615a53b9ffc20d.camel@linux.intel.com>
Subject: Re: [PATCH] intel_idle: add Cometlake support
From:   Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To:     Doug Smythies <dsmythies@telus.net>,
        "'Rafael J. Wysocki'" <rafael@kernel.org>,
        'Jiang Yihe' <jiangyihe042@gmail.com>
Cc:     'Jacob Pan' <jacob.jun.pan@linux.intel.com>,
        'Len Brown' <lenb@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, "'Zhang, Rui'" <rui.zhang@intel.com>
Date:   Thu, 30 Nov 2023 10:24:19 +0200
In-Reply-To: <001701da22db$180872c0$48195840$@telus.net>
References: <20231129143132.32155-1-jiangyihe042@gmail.com>
         <CAJZ5v0jfEsNVu=fg+Xa118F=hCGGB33U5SbiqWeCMaVMqNpUEA@mail.gmail.com>
         <001701da22db$180872c0$48195840$@telus.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-11-29 at 07:45 -0800, Doug Smythies wrote:
> Hi All,
>=20
> This proposed patch has been submitted at least once before.
> (I think more than once, but only found 1)
> Reference:
> https://lore.kernel.org/linux-pm/20200227013411.1.Ica3bb9fa898499d94e0b0a=
2bfa08ec46c89d84fa@changeid/
>=20
> I have a Cometlake processor and am not in favor of this patch.
> Reference at to why not:
> https://bugzilla.kernel.org/show_bug.cgi?id=3D210741

CometLake is a platform from 2020, so I'd classified it as "legacy" and wou=
ld
not apply this patch without a plausible justification in form of measureme=
nt
data.

Comet lake has been used with ACPI C-states for quite a long time, and swit=
ching
it to intel_idle now may cause unwelcome changes in user workloads.

Artem.=20