Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp148787rdb; Thu, 30 Nov 2023 00:28:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2ZNqPZ1bIv+uXw5arLDR/0lqWfmQQ46CP6NLKltfkGBfmQAWKOvm2N1QSg1GVnWCkBuRD X-Received: by 2002:a17:902:6b44:b0:1cf:f026:df34 with SMTP id g4-20020a1709026b4400b001cff026df34mr8774284plt.15.1701332886074; Thu, 30 Nov 2023 00:28:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701332886; cv=none; d=google.com; s=arc-20160816; b=so9pmicOYF/0Nw9n3uza3eQarkFuS24MURRV/pKzNyL4XxEsg99/j3UAztOCxUYzCE H5JUazwgTzSKMPwUz2071sY5nfMotmNrgyHYukVwraYlcc5Ri+M33h0evz6FLM+cRE7i UpQNy9YWBdKlCh7iIC4hvBt+s/einZ+FywyUPzLhYeOrjpBLHspKy5NPRwy/SrEGAAYI F0m3QCqaPfq5gN2TuE/86TCmkl4mLqudXcV+wiU8SiatZoVcpflO7iBk4a6g0TzXidb/ xoenZVFPc65AxylGogxeS1HcvHPpLRuRDadwipMW7uxsAz2JEvN4xhAcg3PspfGhvpC5 kgAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=m1L7Ha7ttqaI2G5WE2aF7pMdPSZvf285nvdgjpNpWs8=; fh=gc+93XFgVBL0fDzxBF+A6PmLPDPtkmQqDF6cV111T9k=; b=mVYgJCujrKLDwf/32pIV26UYK5tz5PpW4oCwV7+jXLYfBNBCX/vY+m/xq9UdCnu3dH f9a5zxiZsQvNNvlFzvRACiJkucqH6swiYoEfXm7YykRiU3CWHXMjHRltW3Vn7ua6HWWI 9R6u9/nscF8n1Zey1G3/bMtLWsPWL0ukZDOTbIq4wxLvZfVNlDIE0ovp3NvMDwEB/qXT 1LtKS6vFijqt5x/DLbJXbBACf9Er0bhExTZU3X2a+YOOpSi7LStoRn3dwLkOc4qRbiXg VCqe0aohqt36m29/AxfBB2WOdctcq8Jx3ITAat7Wmduquxqi8WK4G9p0JCv5AgEgtix9 5TrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n4-20020a170903110400b001cfba111acasi771613plh.372.2023.11.30.00.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 00:28:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CAC44802D1EA; Thu, 30 Nov 2023 00:28:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234988AbjK3I1u convert rfc822-to-8bit (ORCPT + 99 others); Thu, 30 Nov 2023 03:27:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231753AbjK3I1r (ORCPT ); Thu, 30 Nov 2023 03:27:47 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040BE10E5; Thu, 30 Nov 2023 00:27:51 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AU8R1Zn83390710, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AU8R1Zn83390710 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Nov 2023 16:27:01 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 30 Nov 2023 16:27:01 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 30 Nov 2023 16:27:00 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 30 Nov 2023 16:27:00 +0800 From: Hayes Wang To: Douglas Anderson , Jakub Kicinski , "David S . Miller" CC: "linux-usb@vger.kernel.org" , Grant Grundler , Laura Nao , Edward Hill , Alan Stern , Simon Horman , =?iso-8859-1?Q?Bj=F8rn_Mork?= , "Eric Dumazet" , Paolo Abeni , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net v3 2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops Thread-Topic: [PATCH net v3 2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops Thread-Index: AQHaIwq1MymGLXN5NEmSvndbZQxPZbCSgm9w Date: Thu, 30 Nov 2023 08:27:00 +0000 Message-ID: <72e1773d60c94a43ba9d97fa89a8dd1c@realtek.com> References: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> <20231129132521.net.v3.2.I79c8a6c8cafd89979af5407d77a6eda589833dca@changeid> In-Reply-To: <20231129132521.net.v3.2.I79c8a6c8cafd89979af5407d77a6eda589833dca@changeid> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.22.228.6] x-kse-serverinfo: RTEXMBS03.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 00:28:04 -0800 (PST) Douglas Anderson [...] > > Previous commits added checks for RTL8152_INACCESSIBLE in the loops in > the driver. There are still a few more that keep tripping the driver > up in error cases and make things take longer than they should. Add > those in. > > All the loops that are part of this commit existed in some form or > another since the r8152 driver was first introduced, though > RTL8152_INACCESSIBLE was known as RTL8152_UNPLUG before commit > 715f67f33af4 ("r8152: Rename RTL8152_UNPLUG to RTL8152_INACCESSIBLE") > > Fixes: ac718b69301c ("net/usb: new driver for RTL8152") > Reviewed-by: Grant Grundler > Signed-off-by: Douglas Anderson Acked-by: Hayes Wang Best Regards, Hayes