Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp148824rdb; Thu, 30 Nov 2023 00:28:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8YmpGiZuzich4Lut7FveT++TuoPVBFYn1CfjaCQ/yeR7aDWRA3hBmwEGZ+kyHn2kruNz2 X-Received: by 2002:a17:902:c60b:b0:1cf:5746:7ad0 with SMTP id r11-20020a170902c60b00b001cf57467ad0mr27750180plr.14.1701332890479; Thu, 30 Nov 2023 00:28:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701332890; cv=none; d=google.com; s=arc-20160816; b=x2zJrLZGf20OzeZP9Ez9235l8cHzZ7lmZjkQ63jsDg5notLKzQWEHVxK6ekWtv8t4D SzgnlinTVHVOzrM6kmhfSZUHe9xtr0N3roa2iwCHpIMxpRaGPxKGec2AzHUiHa9EmOhW IR0GmRpvQxN22pjkJYFNOkau3qKTW5F+dj7fzBEpXYNZSuHB6KaQzcR2KYXxTD7BKoXZ YYIPA2xPwOPNb9wPiqILk2CTJ62Sj7m1+q/8SQMHcEqQp9yIcz0tFqpzOUImmNPeXqmj qyq/nbeHC6pmbtjyCewvFObxnrnOv1OrmBLSNZ+klWDWgN27zrCSuqsWsA8s4/VM9lw1 Joyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=2gSk+A5EabPoLa7+7tH5efJ9ZF9nQkQtjfououOKrGs=; fh=gc+93XFgVBL0fDzxBF+A6PmLPDPtkmQqDF6cV111T9k=; b=jYh385Ht7R2KA6Xd/Gy67dQ11k/9YHSTgEg6HxseCfpM3nLiRKS5pfzzKlQCfY4A3w yJphveCuOpErH5/meNfDbO2ufuETzr3RbxYEoKpyEK0m6nScvOwFXpgHEogTTjCC1VLA VTRuMjiM1wXJriE3Sa58Yz6Am9W4KnwHZxXI+Upr7JICjrg7WXnDqRqRs/3WZkMpbI1U zQ0kDkU31Xk0mpQ/TYJNPcnXJdCNEUOyc74Phx0mfXtDVZNK3/3kQgb9y+/vpkPZSGaJ Tm4uOIz9RIBQgmm+ErMYwMkIiQ0LFVbf8XnncMUyxFtM5JzRLiB18K5puVOGEHkJ87Bx MquQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id n189-20020a6327c6000000b005898db9d676si829678pgn.260.2023.11.30.00.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 00:28:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 27E24802A6CA; Thu, 30 Nov 2023 00:28:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344889AbjK3I1x convert rfc822-to-8bit (ORCPT + 99 others); Thu, 30 Nov 2023 03:27:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231846AbjK3I1r (ORCPT ); Thu, 30 Nov 2023 03:27:47 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031FD10D0; Thu, 30 Nov 2023 00:27:51 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AU8R2vsC3390733, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AU8R2vsC3390733 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 30 Nov 2023 16:27:02 +0800 From: Hayes Wang To: Douglas Anderson , Jakub Kicinski , "David S . Miller" CC: "linux-usb@vger.kernel.org" , Grant Grundler , Laura Nao , Edward Hill , Alan Stern , Simon Horman , =?iso-8859-1?Q?Bj=F8rn_Mork?= , "Eric Dumazet" , Paolo Abeni , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net v3 5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() Thread-Topic: [PATCH net v3 5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() Thread-Index: AQHaIwq5NbchQV0OhUGi+YoyKvWVRrCSg2Aw Date: Thu, 30 Nov 2023 08:27:00 +0000 Message-ID: <52a03c3217704bfa8051c9d4006a99a4@realtek.com> References: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> <20231129132521.net.v3.5.I1306b6432228404d6e61b2d43c2f71885292e972@changeid> In-Reply-To: <20231129132521.net.v3.5.I1306b6432228404d6e61b2d43c2f71885292e972@changeid> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.22.228.6] x-kse-serverinfo: RTEXMBS05.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 00:28:09 -0800 (PST) Douglas Anderson > Sent: Thursday, November 30, 2023 5:25 AM [...] > > Delay loops in r8152 should break out if RTL8152_INACCESSIBLE is set > so that they don't delay too long if the device becomes > inaccessible. Add the break to the loop in r8153_aldps_en(). > > Fixes: 4214cc550bf9 ("r8152: check if disabling ALDPS is finished") > Reviewed-by: Grant Grundler > Signed-off-by: Douglas Anderson Acked-by: Hayes Wang Best Regards, Hayes