Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp148858rdb; Thu, 30 Nov 2023 00:28:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHy+dLQySQC+eLuluLJePrTptBYoDH7cv3D393XsrRcqZZkVgzypsQXsw0Xh38KupIggEr9 X-Received: by 2002:a05:6a20:8f01:b0:18c:a983:a5f6 with SMTP id b1-20020a056a208f0100b0018ca983a5f6mr13763091pzk.23.1701332895899; Thu, 30 Nov 2023 00:28:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701332895; cv=none; d=google.com; s=arc-20160816; b=X0BLogmOpKOokqjzHI1HhD2RhzJJLtZO5LU2hG4hmoPfN+9zQmxuTDNUKgOIfV5JQk FdI+Q012g5uIVAA49O45C0xoLM3MmjWZnXQ34wWj1NYeHguBXWi+/T/dP+V3wBrMjf/G 4k49ybfMYCCnFZDXTQ8GGdyG9TU7QI26HIIRmKZQLSTKIkMEZQuzc8p9pd4RAoszu92x Er1ns50CMb9KoPRP2eF2cf5gzournVao2ZaIwjmmvfFAEiZEmxlWKaKbc/isIXubncwI L1Y/EojRhXpQJLm1YoIDw5ZcH8POV55znccY2+TkTT5KSjIWfn5KaevY9SiqOB8dQDP1 e7kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=21o5mFe5yXu/Zpf6EU+UHoh+jLfGD1loSkybquOECXY=; fh=5dauYr43MyeJceOzgMQ1bTY8AmlWR9OVX/bIwqJLE3w=; b=JAcR2FbmM/EepCax+vaMmGlHCysod91fa2pm10UmyzsP2iB+NLPjisnIu0M1G8Y5RP bWN5TlVV68EvHa1yQFt+k3u4yz+GJ6pUxcloqYM+d/Dat+pvb7hmc+oNbuYwRROdruxV qIlOavvZUcom+3G0WYguOmNviSpQ3RJE02zy0Z/03NN1Y9zItzCv97Un/mSyW7Tfaeo3 q6U9BInyMQbXbJ2YUrUGHxa/Zr6Txzax5K34/8pPdq4L8pyFj4TkSrlGDYm6S+yH7TR4 cNmotUfYNt0JF2/2j5Tmj6RNio7JBhMEt4aG972bJQ10P3s34lsWmYR2LDbXXy8mpI03 CsiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id lk15-20020a17090b33cf00b002810355fb4dsi3206670pjb.107.2023.11.30.00.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 00:28:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 23D42802A6DB; Thu, 30 Nov 2023 00:28:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234988AbjK3I16 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 30 Nov 2023 03:27:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231788AbjK3I1r (ORCPT ); Thu, 30 Nov 2023 03:27:47 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041D710F1; Thu, 30 Nov 2023 00:27:51 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AU8R2pnC3390730, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AU8R2pnC3390730 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 30 Nov 2023 16:27:02 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 30 Nov 2023 16:27:02 +0800 From: Hayes Wang To: Douglas Anderson , Jakub Kicinski , "David S . Miller" CC: "linux-usb@vger.kernel.org" , Grant Grundler , Laura Nao , Edward Hill , Alan Stern , Simon Horman , =?iso-8859-1?Q?Bj=F8rn_Mork?= , "Eric Dumazet" , Paolo Abeni , "Prashant Malani" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH net v3 4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() Thread-Topic: [PATCH net v3 4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() Thread-Index: AQHaIwq35N8GSRZ2oE2NWLdoNe1FyLCSgvTA Date: Thu, 30 Nov 2023 08:27:00 +0000 Message-ID: References: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> <20231129132521.net.v3.4.I9c7bfe6fb76850f0323b3996e25a10ef0281fb7a@changeid> In-Reply-To: <20231129132521.net.v3.4.I9c7bfe6fb76850f0323b3996e25a10ef0281fb7a@changeid> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.22.228.6] x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 00:28:14 -0800 (PST) Douglas Anderson > Sent: Thursday, November 30, 2023 5:25 AM [...] > > Delay loops in r8152 should break out if RTL8152_INACCESSIBLE is set > so that they don't delay too long if the device becomes > inaccessible. Add the break to the loop in r8153_pre_firmware_1(). > > Fixes: 9370f2d05a2a ("r8152: support request_firmware for RTL8153") > Reviewed-by: Grant Grundler > Signed-off-by: Douglas Anderson Acked-by: Hayes Wang Best Regards, Hayes