Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935231AbXK3Q10 (ORCPT ); Fri, 30 Nov 2007 11:27:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756877AbXK3Q1P (ORCPT ); Fri, 30 Nov 2007 11:27:15 -0500 Received: from sacred.ru ([62.205.161.221]:58276 "EHLO sacred.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761232AbXK3Q1O (ORCPT ); Fri, 30 Nov 2007 11:27:14 -0500 Message-ID: <475038F3.9010209@openvz.org> Date: Fri, 30 Nov 2007 19:23:15 +0300 From: Pavel Emelyanov User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: "Serge E. Hallyn" CC: "Eric W. Biederman" , Herbert Xu , Andrew Morton , Daniel Lezcano , Cedric Le Goater , Linux Containers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller Subject: Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure References: <4742C73C.3010904@openvz.org> <20071130161856.GA10588@sergelap.austin.ibm.com> In-Reply-To: <20071130161856.GA10588@sergelap.austin.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-3.0 (sacred.ru [62.205.161.221]); Fri, 30 Nov 2007 19:23:17 +0300 (MSK) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 37 [snip] >> + &namespaces, path, table); > > Hey Eric, > > the patches look nice. Agree ;) > The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > does make it seem like nsproxy may not be the best choice of what to > pass in. Doesn't only net_sysctl_root->lookup() look at the argument? > > But I assume you don't want to be more general than sending in a > nsproxy so as to dissuade abuse of this interface for needlessly complex > sysctl interfaces? > > (Well I expect that'll become clear once the the patches using this > come out.) > > Are you planning to use this infrastructure for the uts and ipc > sysctls as well? I have sent some patches concerning uts and ipc already. I'd appreciate any feedback on it :) > thanks, > -serge Thanks, Pavel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/