Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Yangtao Li <frank.li@vivo.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     Yangtao Li <frank.li@vivo.com>, Wenbo Hong <wenbo.hong@vivo.com>,
        linux-f2fs-devel@lists.sourceforge.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v2] f2fs: add support for an i_version counter
Date:   Thu, 30 Nov 2023 02:04:09 -0700
Message-Id: <20231130090413.1291703-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/95NXehUiSFeYfNM2pcz7wc1NRxW5gCpEn5E7YNhM+OdcTfwJdosUS5NBvxR?=
 =?us-ascii?Q?JS/QbvKlJCWZ2+f8lHUTrFnXw1f7nbrX/mWZumBBqu7HS8bfLvY2/AfQfSBS?=
 =?us-ascii?Q?l2kfeese0zf8IkAkaG0+rsDm+TgGz0oPj8alRUUU+g5AE07UuQMO63eNa5Yv?=
 =?us-ascii?Q?rKOGGxRpiV9Xu4FkYjehlNVIMCGjg5LXkL6+ff5+Pz6ns6AE9OYaj4z6Vniy?=
 =?us-ascii?Q?LlmOGomNyU2az9ThQyrKWZbv+6lfgWsC6EhCCO36/eN+cA818w38uUwyNYqN?=
 =?us-ascii?Q?UDkvIiDIIHION29KqUcXMXj44LzHrtOvLYEPdRDX11ncjex9uMHVr348rCwr?=
 =?us-ascii?Q?ir6XAw3nifPBmMMlITt/Pyr1DMABnsCmyR/ckcVNZWaOBGBcbLVgZulWN4qn?=
 =?us-ascii?Q?50ywcifZsYHbINGnXCwuIsa7aT6K2MS1idL/FmJhZ65Uu5Ag5sFFYXAHRmpU?=
 =?us-ascii?Q?aZy6XHNa9IMLSDGAKnJ6xUIDIn2ZvItses5TnTNFuyaHSsbKv5uTI6KQkG0N?=
 =?us-ascii?Q?2LChtzbb+BIdrptMMikGBvL1UcTtJ+qMp0pSDeuDg/3RsgOd+h3IuVrmi9oE?=
 =?us-ascii?Q?YiXtrKeUOOn05OrBdhYQDZlOOTDLMoGwimgMPOro0lalp49ZUex1K7kl4TR6?=
 =?us-ascii?Q?CegJmCdEPY/vyJYrOtJ0tr63S7SmFQ+hyk4YgShpT/6CbP+JTNCL+Wj3P8bC?=
 =?us-ascii?Q?nB+g/YWRh6sFEYSmX7yIP7GKx4T76M4xWboyUSMeeiUA8sU+HAYIO2cgp8P4?=
 =?us-ascii?Q?PHWCCDXHDuGPBYJvPrgt6KaIEMZv70OKSJ9C8S/P7UtVAsuAP0IG5bWPeP2G?=
 =?us-ascii?Q?1pRbJEWjIn0cxnH8UBFISnDuhCcnso+nTHcbisb7IQ3a3yKQZ1L9O/lsDmj2?=
 =?us-ascii?Q?85TnZ5QPt6TnhGss0IqBOowAasDlXQTNd4bIEnDVdEHFA+RMo+RgcI7Qhcaq?=
 =?us-ascii?Q?UVVQmaVVAiNPIMBQdEgkowXhM7IqoVehtJrgk4pLde34lNvurY4hQCUPty/C?=
 =?us-ascii?Q?laM2bSglQwKkQDn6lb6JXauqaLbF7Ng88cRuFPgzqF0FLhRrs5o6nNAfNoYU?=
 =?us-ascii?Q?zmOSJjra4qOvHUOpzUKm2UoS1QAvxrf/fivvUT/lkLK9Psg9BPl0cXMm7UsR?=
 =?us-ascii?Q?6H9mJqhCxbpmbGltky1OtRpmOpzfKJlgH2JB8IdB4TP+ryjMZboeWQ508FYS?=
 =?us-ascii?Q?121E1AgaSlF/HWYGsmArlCZ5HVxhKsIX5Co4z2UvKg3pPQT9lQjfNbrg2usM?=
 =?us-ascii?Q?PEJayqtOFnhhBvzfc9DIt9fpBID6QRjo6pSBsC6XtvhDH+ZLLPZgvNmjSKUz?=
 =?us-ascii?Q?WsyokW5G/R9sKlPtGi2aqRjpik1Vbaujdf204arFzZkQNORP6wqoC8g/01o4?=
 =?us-ascii?Q?01ZOsca3i21dJHoo38NOk/iINf1AGd+BE4p9SYEQ05Z2902+gG44VNBPcwBl?=
 =?us-ascii?Q?4Ibne8ELwagFcLNcVuB9qkTxyuMp2uku3hn9MYy/2vR7jLgCCziEPN16q7jM?=
 =?us-ascii?Q?ilsprxEtPAfsu+wWDeasWs7E/THtK4601soK5xRf5mZU6YjbNl3tJxFaHJTs?=
 =?us-ascii?Q?4QN3D86pgjDtElkNlB029/pt0Fqp58gA5VljHMq+?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba562a7-e6a8-414a-0d96-08dbf182020d
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 08:54:48.8659
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XrvhRa3wP7UNAoTjIAGDOdslz0+wvNUCqZUG1x7SNmjfDaFjGx6KrfK9f58oTh1iUu8F+YFxTIjeQiWD2ztOAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5353
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 30 Nov 2023 00:55:11 -0800 (PST)

NFSv4 mandates a change attribute to avoid problems with timestamp
granularity, which Linux implements using the i_version counter. This is
particularly important when the underlying filesystem is fast.

BTW introduce a new mount option to enable the iversion functionality,
and disabling it by default.

Signed-off-by: Wenbo Hong <wenbo.hong@vivo.com>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 Documentation/filesystems/f2fs.rst |  2 ++
 fs/f2fs/f2fs.h                     |  1 +
 fs/f2fs/inode.c                    |  2 ++
 fs/f2fs/super.c                    | 17 +++++++++++++++++
 4 files changed, 22 insertions(+)

diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
index d32c6209685d..eac23bc0bb92 100644
--- a/Documentation/filesystems/f2fs.rst
+++ b/Documentation/filesystems/f2fs.rst
@@ -367,6 +367,8 @@ errors=%s		 Specify f2fs behavior on critical errors. This supports modes:
 			 pending node write	drop		keep		N/A
 			 pending meta write	keep		keep		N/A
 			 ====================== =============== =============== ========
+iversion		 Enable the feature of updating the inode I_version field.
+noiversion		 Disable the feature of updating the inode I_version field.
 ======================== ============================================================
 
 Debugfs Entries
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 9043cedfa12b..68fd2ef35104 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -28,6 +28,7 @@
 
 #include <linux/fscrypt.h>
 #include <linux/fsverity.h>
+#include <linux/iversion.h>
 
 struct pagevec;
 
diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index 560bfcad1af2..b741eea7e724 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -32,6 +32,8 @@ void f2fs_mark_inode_dirty_sync(struct inode *inode, bool sync)
 	if (f2fs_inode_dirtied(inode, sync))
 		return;
 
+	if (IS_I_VERSION(inode))
+		inode_inc_iversion(inode);
 	mark_inode_dirty_sync(inode);
 }
 
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 033af907c3b1..adae708e869c 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -180,6 +180,8 @@ enum {
 	Opt_memory_mode,
 	Opt_age_extent_cache,
 	Opt_errors,
+	Opt_iversion,
+	Opt_noiversion,
 	Opt_err,
 };
 
@@ -260,6 +262,8 @@ static match_table_t f2fs_tokens = {
 	{Opt_memory_mode, "memory=%s"},
 	{Opt_age_extent_cache, "age_extent_cache"},
 	{Opt_errors, "errors=%s"},
+	{Opt_iversion, "iversion"},
+	{Opt_noiversion, "noiversion"},
 	{Opt_err, NULL},
 };
 
@@ -1334,6 +1338,12 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
 			}
 			kfree(name);
 			break;
+		case Opt_iversion:
+			sb->s_flags |= SB_I_VERSION;
+			break;
+		case Opt_noiversion:
+			sb->s_flags &= ~SB_I_VERSION;
+			break;
 		default:
 			f2fs_err(sbi, "Unrecognized mount option \"%s\" or missing value",
 				 p);
@@ -2152,6 +2162,11 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)
 	else if (F2FS_OPTION(sbi).errors == MOUNT_ERRORS_PANIC)
 		seq_printf(seq, ",errors=%s", "panic");
 
+	if (sbi->sb->s_flags & SB_I_VERSION)
+		seq_puts(seq, ",iversion");
+	else
+		seq_puts(seq, ",noiversion");
+
 	return 0;
 }
 
@@ -2196,6 +2211,7 @@ static void default_options(struct f2fs_sb_info *sbi, bool remount)
 	F2FS_OPTION(sbi).errors = MOUNT_ERRORS_CONTINUE;
 
 	sbi->sb->s_flags &= ~SB_INLINECRYPT;
+	sbi->sb->s_flags &= ~SB_I_VERSION;
 
 	set_opt(sbi, INLINE_XATTR);
 	set_opt(sbi, INLINE_DATA);
@@ -2574,6 +2590,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
 	limit_reserve_root(sbi);
 	adjust_unusable_cap_perc(sbi);
 	*flags = (*flags & ~SB_LAZYTIME) | (sb->s_flags & SB_LAZYTIME);
+	*flags = (*flags & ~SB_I_VERSION) | (sb->s_flags & SB_I_VERSION);
 	return 0;
 restore_checkpoint:
 	if (need_enable_checkpoint) {
-- 
2.39.0