Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Frank Binns <Frank.Binns@imgtec.com>
To:     "dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
        Sarah Walker <Sarah.Walker@imgtec.com>
CC:     "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        Donald Robson <Donald.Robson@imgtec.com>,
        Matt Coster <Matt.Coster@imgtec.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "airlied@gmail.com" <airlied@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [PATCH 2/2] drm/imagination: Fix IS_ERR() vs NULL bug in
 pvr_request_firmware()
Thread-Topic: [PATCH 2/2] drm/imagination: Fix IS_ERR() vs NULL bug in
 pvr_request_firmware()
Thread-Index: AQHaI2zty10S9X9860OzH9Sodb/+iQ==
Date:   Thu, 30 Nov 2023 09:09:31 +0000
Message-ID: <5a1d8121d85858653b646f8f73845627cb70198b.camel@imgtec.com>
References: <384288de-a779-46c7-869d-b3c63462e12b@moroto.mountain>
In-Reply-To: <384288de-a779-46c7-869d-b3c63462e12b@moroto.mountain>
Accept-Language: en-GB, en-US
Content-Language: en-US
user-agent: Evolution 3.36.5-0ubuntu1 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U2hRbFlaWDByZHJTWU05bnNDS2NiQmRyVnE3ZkZqTUlVN2tWb2dWTXNKaWxJ?=
 =?utf-8?B?U3prZVlSU2o2VVRYcVR4dTY0blNIQ0p2OVdZMjNmOXpSMG5UWDljQkhxc3h3?=
 =?utf-8?B?VWVTWXp4M2RXV2J3YzRsMkpPQkNaRndYSElHZVdBVUVJYkpwTkpMMXdkNXVI?=
 =?utf-8?B?MDFJUGwvNXFtUjJMbXpPQTJlWFFnSW14RjlWdEtFUWt5ZjVkNlczcG5DT0tm?=
 =?utf-8?B?UUk5VmRqWVMzeXREOVJrV2lQVCtBem5QaFMrL3dwWEk2Y2pCaytXOGlQZjRs?=
 =?utf-8?B?eU5pRzJMUmpER3JybitWYlN4SFZiWnlKTjNaTWJkUXNiN0ttazNuNTNPWVQ2?=
 =?utf-8?B?Q0xBSkdKNTNJNE41bGpsb0wrQ3h1YnNRSjFETmE2ZU54bHBiU2JvL0tjbnls?=
 =?utf-8?B?akYyUFZtNjJtZExORVdHMWFRbVdjL2llQnBtMWl4Zkxkc2FUWUxJWjVXcmhw?=
 =?utf-8?B?VGNkUXVoaGgzU1Jmem11NFNrMEVhTWVKeUZYdVRzbVdvaHFxYnc5ZnZXaHA2?=
 =?utf-8?B?a1Y3L29VMDROVFQ4MzBaN3F6dmlrY0ZFV0hnbmdwOEhBQTBHRW5DVGM5MXpy?=
 =?utf-8?B?NlRmdGNhbXNRYW0xcHB5OUpJQWVjeStiSC96VFVBeCtBZUIrWlk1MTNhMGp1?=
 =?utf-8?B?QStuMXBabDd0dWMrb205SmRRd0ZpZXlhNmtQT240LzZ4K0JnV3FhL0FZUFJ1?=
 =?utf-8?B?dGQwVU9KN1FscjJqMGp1Z2lXMXNrUFl0RVJXSDh5M3ZYbjRSMFVIWHUzTERG?=
 =?utf-8?B?bTZWR01mbUx2OFJudzdOVlVham1HZ0M4K3ZHSjB1L3JOeVhFVE5Nbm4rUUpC?=
 =?utf-8?B?d1U0YkRvWEZXMUs5MGdaY0FidDBsN1dUT0t3Y3JKeHJMa0JLMWRQay9aL0RQ?=
 =?utf-8?B?WVpiM3hWVjVKQVhRTHRSOCtXY0lsNzdsd0JlNU5rRVFhZlgycHIyLzFRMWNL?=
 =?utf-8?B?T0NpQ2JtYVBNd2x1Nlh6aGMyZnF4c2R4WU5wdUJEcEs5OXk4a1lpSVR1ZElM?=
 =?utf-8?B?VXcrZExBV0o4SEI3ZE9TUjBTMS9LL1BxZEFxQWx6ME1nVzA5czRBOWZQNzQw?=
 =?utf-8?B?d1gwRFJDK0Vvc1VJYjZCQnJReUtlWmY3ZUFKTlVIOGM0TVdEazNOREJ1UnlR?=
 =?utf-8?B?Y2dxUzFDeC9UbExlMThKN0wzc2JqVTJJNmlBc0pWcEZySVVHZ0d0QlBTVEdq?=
 =?utf-8?B?TEN1RENRNzVCN1lxSjJyWjRFMXNjaDBuY2Z0MFlkZCt3TFI3UjBVTEo4WlJi?=
 =?utf-8?B?RDRTamF1QWs1eVppaXRIbjRwb29DSWFNbjNzbVQ4a3pSd0djTmF5S2dxbThX?=
 =?utf-8?B?K2RvWTNpVHpPbm1iSTdxcnVXc0xhWXRmdk1BcWo5cForZndiV2tCeE5IdmEr?=
 =?utf-8?B?aW8wMWV4YlNldG9wVnpJMFNlZ3VoTUp4QnRnZkdFdHB1Q3FEbmV1Q2RKT2ow?=
 =?utf-8?B?OHJISFBRdjJrOGdGV2tpZThGRTRVUDNxSThSc3YvZ3JabU1OWHl2L0tDUDBl?=
 =?utf-8?B?V3lCYVkrLzFVd2lGWXNQUXMrRDdXNGJmNUYydzUwMVdyVGxOOTdRbDI2NGxm?=
 =?utf-8?B?SU5XeU1RN3ljUlB1RFVLZE5UVjJoK0F3MkZGV1hZM3ZncndITHk1MUJYQWRi?=
 =?utf-8?B?dXpWVXFwQ2ZpSnh6TGFtYlV2ZElTK2duZHRIUjhUOGlZK3pzT3Z5eEx4VFN0?=
 =?utf-8?B?ZnpxVmxxY3lFYTJvbjQ0d0NqU2dpdlBxSmhjSCtXc1E1QXpNNmhmd29rY1g4?=
 =?utf-8?B?MmhVa1NDVkFsQVBmUTFKSlg1NVRDR2NGN2MwZXBBbGFwUVo1eW9lOGFCaUdz?=
 =?utf-8?B?K0piYmk1UGJGYmxQRS9BM2tiL1g4RUdmalhwZkxyMnAvVktybStNSHFVendC?=
 =?utf-8?B?N3M1L2R3UUpUZFVaQks0Q2EwT29aemt1SzNTM25BajRkY3owaklZZHQyL2ZC?=
 =?utf-8?B?MFA2a2FJUStHdlVySDVFeHErcm9FSUlreXNLVmRQYjBoMjJUWGdiUS94Z1lV?=
 =?utf-8?B?VkdLdSt3VVBPcStQNUdjc3Fsc09LaHFvYjZ4aUVMdzVyd3U2UWNadUZGYzBS?=
 =?utf-8?B?MC9FWVBkcDlmNFFaMzluOUlhcTFHblF6LytvZ3poeXY3bC82MU1ZZWNUY294?=
 =?utf-8?B?VVArNWRDMlEwOHk1Wm94V2VJMkFuRmJoSWE5T1NwUjhHOW5XYzdxMGFqalVX?=
 =?utf-8?B?TlE9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <C1BD185F0862744D9ECFC85C99E68A79@GBRP265.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LO6P265MB6032.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 67f189da-8bbc-4cfb-5ad8-08dbf184104c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 09:09:31.3891
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d5fd8bb-e8c2-4e0a-8dd5-2c264f7140fe
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jX0rBk+3cU203KkMZfPsYV0AONU+L2PxcUBinRE1H5bPbspv7iB24Y6zeMufKirIZShWTxrhE51F+Z1uLspnrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5925
X-OriginatorOrg: imgtec.com
X-EXCLAIMER-MD-CONFIG: 15a78312-3e47-46eb-9010-2e54d84a9631
X-Proofpoint-GUID: rXJeunkmfkjQeiIkNJfnKP5tvSPv13js
X-Proofpoint-ORIG-GUID: rXJeunkmfkjQeiIkNJfnKP5tvSPv13js
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 01:09:59 -0800 (PST)

T24gVGh1LCAyMDIzLTExLTMwIGF0IDEwOjI3ICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K
PiBUaGUgcHZyX2J1aWxkX2Zpcm13YXJlX2ZpbGVuYW1lKCkgZnVuY3Rpb24gcmV0dXJucyBOVUxM
IG9uIGVycm9yLiAgSXQNCj4gZG9lc24ndCByZXR1cm4gZXJyb3IgcG9pbnRlcnMuDQo+IA0KPiBG
aXhlczogZjk5ZjVmM2VhN2VmICgiZHJtL2ltYWdpbmF0aW9uOiBBZGQgR1BVIElEIHBhcnNpbmcg
YW5kIGZpcm13YXJlIGxvYWRpbmciKQ0KPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxk
YW4uY2FycGVudGVyQGxpbmFyby5vcmc+DQoNClJldmlld2VkLWJ5OiBGcmFuayBCaW5ucyA8ZnJh
bmsuYmlubnNAaW1ndGVjLmNvbT4NCg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9pbWFnaW5h
dGlvbi9wdnJfZGV2aWNlLmMgfCA0ICsrLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv
bnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2ltYWdpbmF0aW9uL3B2cl9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9pbWFnaW5hdGlvbi9w
dnJfZGV2aWNlLmMNCj4gaW5kZXggZTFkY2M0ZTQyMDg3Li41Mzg5YWVhN2ZmMjEgMTAwNjQ0DQo+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pbWFnaW5hdGlvbi9wdnJfZGV2aWNlLmMNCj4gKysrIGIv
ZHJpdmVycy9ncHUvZHJtL2ltYWdpbmF0aW9uL3B2cl9kZXZpY2UuYw0KPiBAQCAtMjg2LDggKzI4
Niw4IEBAIHB2cl9yZXF1ZXN0X2Zpcm13YXJlKHN0cnVjdCBwdnJfZGV2aWNlICpwdnJfZGV2KQ0K
PiAgDQo+ICAJZmlsZW5hbWUgPSBwdnJfYnVpbGRfZmlybXdhcmVfZmlsZW5hbWUocHZyX2Rldiwg
InBvd2VydnIvcm9ndWUiLA0KPiAgCQkJCQkgICAgICAgUFZSX0ZXX1ZFUlNJT05fTUFKT1IpOw0K
PiAtCWlmIChJU19FUlIoZmlsZW5hbWUpKQ0KPiAtCQlyZXR1cm4gUFRSX0VSUihmaWxlbmFtZSk7
DQo+ICsJaWYgKCFmaWxlbmFtZSkNCj4gKwkJcmV0dXJuIC1FTk9NRU07DQo+ICANCj4gIAkvKg0K
PiAgCSAqIFRoaXMgZnVuY3Rpb24gdGFrZXMgYSBjb3B5IG9mICZmaWxlbmFtZSwgbWVhbmluZyB3
ZSBjYW4gZnJlZSBvdXINCg==