Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp175442rdb; Thu, 30 Nov 2023 01:28:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqOYPqln6GNN+f9soqjQHlckpMdh9h+Kxwfq4qXJyxinbYjMrvqpndd+VC/BOkrUh67XOz X-Received: by 2002:a05:6830:1c4f:b0:6d8:322e:d8a7 with SMTP id o15-20020a0568301c4f00b006d8322ed8a7mr9941697otg.12.1701336500156; Thu, 30 Nov 2023 01:28:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701336500; cv=none; d=google.com; s=arc-20160816; b=HNhEMUaIdlEVZ/jUBGd58+lvd/DCC0fLp2X+2Dg1yURqjunUquQXIIczN/SqcXozsG Gc2Xu/18b4JS4+tk1NGgotRSr+nzpimTGnajmOr+UIKbMANyMWIWAKcNuRUbP4YrqkNp R1G3/YFIA75YbFpOUi4MKQ0brFV2x+rxCCDY2YGJScJX1pkGaD70HHZMUNc1/s4eHG4i laUAo+a4BrD4DX36vkuL5A4WSejuGLEGu72OBv14SAt1VYeg5lw9KDiX0oOa6lf1EjZu 1WgkuO/YyOCdSpes5I6AielO7r7ILWRp6/VwWLtqIrqCWbQC7F7hiWl9D/SaHtqkP+Y4 qKhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Y40c7C5K4pqWqN0+ur797YDI/9mVEZ6Ks1ldvsmx7Xw=; fh=p7br4aKyVFHad3wDGnC36UG9lnEH5KN4GgDlZZrXGDw=; b=fDQ9IQdxyfPtMfdQu9j2rpdOVj3xW/EW5azEXP8dxatkoVq34YTg3Y28jAPm0Kl77H X+grUFPYAzcGPWJo8ynxhvPQ8tC6PfGKiwP7LAR6u8J0FE5gD8o+SpN9ryy6dwgJI7yU OJ2v9uFTHOxScWd93DpsAGX+70JhD/hjE4JToFT2kF9joAo6NK2bzKZd8GwA3m/2Bbnq W6LgcMP5wT52YWvLFquUOF39dHLRaD4GXGRCAPP11QAHHqOWI9PwWtQyzl0UxZ9N/CPF ae1ZNAr90EWpTWLl7pu7LKFN5YKBbVMS/5OI9UHXt53b34IxS7/Hy/YI2FpwZ3Yb2AP0 tj/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lSmW7sAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id bs63-20020a632842000000b005bd6897634dsi899477pgb.249.2023.11.30.01.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 01:28:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lSmW7sAI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B29B48040D6E; Thu, 30 Nov 2023 01:28:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbjK3J2D (ORCPT + 99 others); Thu, 30 Nov 2023 04:28:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjK3J2C (ORCPT ); Thu, 30 Nov 2023 04:28:02 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B8C28F for ; Thu, 30 Nov 2023 01:28:09 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF0BC433C8; Thu, 30 Nov 2023 09:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701336488; bh=Y40c7C5K4pqWqN0+ur797YDI/9mVEZ6Ks1ldvsmx7Xw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lSmW7sAIr40qs7sVpiByKw3836RtLyslE4Z2pCVp3ew1G0O1xzzAsFv4yur2AXeyx sXP+tyITN0rH4VVwwj07rJQMQqgZHYVE5dP4QVUa0VcZmX2RZGLgfkM/feLGuQ9lOx 1c0dLsarzcFBOlZGBwJg8kX15ElE/1TcrEB4X3E9uiYvuVMxW5yUp9XZyFnGorT7r/ np56DQaUUst/8Kp3878aen7ewEQrTWEevW0RVYwLcdBO5jqS9grXW64J8x3ZzNcXNY eekN+VtCQ3H7pWBk0NeOO7e6HN24GuVu41fRuJ9H7gXv5ATVSIevXADeREdTktXfXI 2+N3DUq05FyEw== Date: Thu, 30 Nov 2023 10:28:05 +0100 From: Maxime Ripard To: Donald Robson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, matt.coster@imgtec.com, frank.binns@imgtec.com, boris.brezillon@collabora.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, kernel test robot Subject: Re: [PATCH 1/5] drm/imagination: Fixed warning due to implicit cast to bool Message-ID: References: <20231129153703.162642-1-donald.robson@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ochkfrngyobckdx7" Content-Disposition: inline In-Reply-To: <20231129153703.162642-1-donald.robson@imgtec.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 30 Nov 2023 01:28:17 -0800 (PST) --ochkfrngyobckdx7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Donald, It looks better, thanks :) On Wed, Nov 29, 2023 at 03:36:59PM +0000, Donald Robson wrote: > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202311241752.3iLyyFcA-lkp@intel.com/ > Fixes: 1ff76f7a5b45 ("drm/imagination: Add GPU ID parsing and firmware loading") > Signed-off-by: Donald Robson However, we'll want some commit logs for all of these. You can have a look at Arnd's which are very good example of what we expect, but some small description of the issue, the fix and the warning from the compiler is usually what we go for. Thanks! Maxime --ochkfrngyobckdx7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZWhVpQAKCRDj7w1vZxhR xaS3AQDeq06UyHiu9THDsZTzr/zSZGHR12FDZ6s2HLy2D8THJAEAri1zu23eIU61 pAxOLvvYxy90pzq5U0RpJXweNGo/HwI= =Naf4 -----END PGP SIGNATURE----- --ochkfrngyobckdx7--