Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp183687rdb; Thu, 30 Nov 2023 01:46:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGM0zjQ8RjQrouuVYT+A3xdz0MiXl3m7OjrrArtnHC36sq2xNLZwKtW2ttvSpnPJmYmilRC X-Received: by 2002:a17:903:246:b0:1cf:6c5d:f0c6 with SMTP id j6-20020a170903024600b001cf6c5df0c6mr25797246plh.10.1701337567555; Thu, 30 Nov 2023 01:46:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701337567; cv=none; d=google.com; s=arc-20160816; b=Y4ckOxvFVCsB05kMndiupsftNO2V+s9j2zDwppl6p/j2v3IJwt+G9EwXHpES4d0cZk hJB4R85AvGQZ9w3CwNQVwKXyaHP9zCtiDEWJ/owAMjI/mqwwzDafqunlhluZCKX7P/J/ 77KuxB7MEdU1pfgDwzxnFSzwivBXxmf2RDtjbKLl6mK45ptsZgog5UhM509VjBOZiCCz 1NY+G2lM2F8lbz8p9JVI5BOorY3pbv8oNbRIfJ9jPNq+Gm+hllkWsya1kP5/UU88xS1Y vuXTNouMsRx5vzbbY8X3nQxHnfhkl4qNnxdtaN0fNaJ2MzQHR+l6aqh2hLAzR2x+dGM3 zevw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YO+eUicdGS2pZ2Ie3ssAa26usrHD4L24X+MClLSc5hc=; fh=Mt/vOFHJoQQ6VRaAKWK3UZolvK9Eoez4aLgGO6NjL4w=; b=LynE47znyk+PJ0auk6PX4r5GBWemtPQxOnGSgxPnnFuuFGSRauetGOcJQWNIgzMb6M bFyhPeyGUfX2ii4jMT6hjHhngp6wX01uJY4ShJb4CvN2OYU7iwj8IR62V1i8RYjf7MHK bbjtc0jJlgQztyZElmGwcwuecdPF0QLeYIbvQ0+k/ipFQ1G5Z503eyn2eLjPDlxXETUK EklPTdtbp9xmseSqYfcuA9HiviSjwdxHmdxjvpeXx1F67hENNvthn1IPLXqd7hg1TO9d OfUurlq0E5Pg9HvKm7+xClH0bKhZuZvbdqm/7sglIzndObrRLXL8jDC95nAe6Mp5a5HY ISag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id y9-20020a170902b48900b001cc59201d1esi867822plr.172.2023.11.30.01.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 01:46:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C3DAE81F391F; Thu, 30 Nov 2023 01:46:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231844AbjK3Jps (ORCPT + 99 others); Thu, 30 Nov 2023 04:45:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231784AbjK3Jpq (ORCPT ); Thu, 30 Nov 2023 04:45:46 -0500 Received: from zg8tmtyylji0my4xnjqumte4.icoremail.net (zg8tmtyylji0my4xnjqumte4.icoremail.net [162.243.164.118]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8F9EBD50; Thu, 30 Nov 2023 01:45:49 -0800 (PST) Received: from hust.edu.cn (unknown [172.16.0.50]) by app2 (Coremail) with SMTP id HwEQrABHp8SdWWhlDIwaAA--.25716S2; Thu, 30 Nov 2023 17:45:01 +0800 (CST) Received: from susu-virtual-machine.localdomain (unknown [10.12.173.52]) by gateway (Coremail) with SMTP id _____wBnUT+NWWhlIfEuAA--.57589S2; Thu, 30 Nov 2023 17:45:00 +0800 (CST) From: Yu Sun To: Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Mark Gross , Vadim Pasternak Cc: hust-os-kernel-patches@googlegroups.com, Yu Sun , Dongliang Mu , Dan Carpenter , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] platform/mellanox: mlxreg-lc: Check before variable dereferenced Date: Thu, 30 Nov 2023 17:44:07 +0800 Message-ID: <20231130094409.3963-1-u202112062@hust.edu.cn> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: HwEQrABHp8SdWWhlDIwaAA--.25716S2 Authentication-Results: app2; spf=neutral smtp.mail=u202112062@hust.ed u.cn; X-Coremail-Antispam: 1UD129KBjvJXoW7Jw4kJw13KryxtrWUtr1kZrb_yoW8Jr4kpF W3Cw4S9FWYkF109w4Ut34Y9F48CayfXrWjyryFy39xAFnIqa9rZrZ8Jw1ktFZFkrWDZ3Wj kw48ta4Fv345X3JanT9S1TB71UUUUjDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUQIb7Iv0xC_Cr1lb4IE77IF4wAFc2x0x2IEx4CE42xK8VAvwI8I cIk0rVWrJVCq3wA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjx v20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK 6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1ln4kS14v26r 126r1DM2vYz4IE04k24VAvwVAKI4IrM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI 12xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj64x0Y40En7xvr7AKxV W8Jr0_Cr1UMcIj6x8ErcxFaVAv8VW8uFyUJr1UMcIj6xkF7I0En7xvr7AKxVWxJVW8Jr1l Ox8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxkF7I0En4kS14v26r126r1DMx AIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIEY20_GFW3Jr1UJwCFx2IqxVCFs4IE7xkE bVWUJVW8JwCFI7km07C267AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7Cj xVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0_uctUUUUU== X-CM-SenderInfo: rxsqjiarsqljo6kx23oohg3hdfq/ X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 30 Nov 2023 01:46:04 -0800 (PST) there is a warning saying variable dereferenced before check 'data->notifier' in line 828. add "for(data->notifier)" before variable deferenced. Signed-off-by: Yu Sun Reviewed-by: Dongliang Mu Reviewed-by: Dan Carpenter --- drivers/platform/mellanox/mlxreg-lc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c index 43d119e3a473..e92add40750b 100644 --- a/drivers/platform/mellanox/mlxreg-lc.c +++ b/drivers/platform/mellanox/mlxreg-lc.c @@ -824,9 +824,12 @@ static int mlxreg_lc_probe(struct platform_device *pdev) return -ENOMEM; mutex_init(&mlxreg_lc->lock); - /* Set event notification callback. */ - data->notifier->user_handler = mlxreg_lc_event_handler; - data->notifier->handle = mlxreg_lc; + + if (data->notifier) { + /* Set event notification callback. */ + data->notifier->user_handler = mlxreg_lc_event_handler; + data->notifier->handle = mlxreg_lc; + } data->hpdev.adapter = i2c_get_adapter(data->hpdev.nr); if (!data->hpdev.adapter) { -- 2.42.0