Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp195774rdb; Thu, 30 Nov 2023 02:11:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKGb7/gKIZCc1izVu2i+HB+HM6939Bobx5mdzyrBSwHpgxqHWXcMWBkAJ2QMRHNfJFHJei X-Received: by 2002:a17:902:ea0c:b0:1d0:3b8b:96e1 with SMTP id s12-20020a170902ea0c00b001d03b8b96e1mr537509plg.61.1701339096088; Thu, 30 Nov 2023 02:11:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701339096; cv=none; d=google.com; s=arc-20160816; b=Og0V2qnuO0iajGeRkR3CCsQA5Sx6+NBGUcYFuIJr8rfwUeQ34XIIOE+roMVSEJ3vLb rrJNZYsXBQVYD0//40tFkbNnjOgE8GYeTOTkgH/oLtQizH+aqKvegtg6jHxu6RfeIkzO 9HSNFW9umbeZah3AMYvt5sslQPOiZfsmPRpIj8yLevjaw19OU0Gt6JBjc/J9hFaq9to1 yFak0MKSaaNtqaKpU8i+yly7SAtb0W+dzr5uxjCHhFpem2SaX0PdMIiU6C7zDLBwWMZF QwL1Ydt6Z1BtrMAiV8DRszEv1avcld2PgUIPRqCR3xl2B9R1qbwD1Lcsmalqo2a6WNG0 FBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=BQKXf1q2OEZnZ3kEZQU0tyP5ahd6SKR/Xu20SNGKyvI=; fh=HJCxKJrADEEWLw8a8FFNCrPY3LoVAy30QIjXpzIzSNs=; b=P2e99A+8HcCMeYe0/8rIn1cUG37SUlzynB4Nc9a4NO+9x9gI3oOAiZjXh3s1LhwcpL I8pW7eUyd3opef83XNRViLOvu/E3tb+gaQFZrPfs2ZnYQPRrse4HN4TIzKrtEQQSHKEE W32sATubW33ZuZBPfmbzFA+AsyMEqqU793jL4nXNS60jwpvwMOmAufHlpgelKlSpjPZE 6JCLQpdi6UCHXkVzlu9x7S9V0YXKWXtXqtVBR+ok2jx7jNW0Fgtsj5W3F98h1V11jjdr kqcC5oSfvSWz+9nL3Of64xeCAKJpEJHB11ZuR+Yg3nxLOyyYo9iYhh216LeNgjLuzmui ZnhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0m9yJqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id bf9-20020a170902b90900b001bc162f3318si835723plb.640.2023.11.30.02.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:11:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q0m9yJqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 168F9802F7CE; Thu, 30 Nov 2023 02:11:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231854AbjK3KLT (ORCPT + 99 others); Thu, 30 Nov 2023 05:11:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjK3KLR (ORCPT ); Thu, 30 Nov 2023 05:11:17 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1313F10C9 for ; Thu, 30 Nov 2023 02:11:24 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-54af4f2838dso693845a12.2 for ; Thu, 30 Nov 2023 02:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701339082; x=1701943882; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BQKXf1q2OEZnZ3kEZQU0tyP5ahd6SKR/Xu20SNGKyvI=; b=q0m9yJqtu2DQf/EE1EwzftGf3pDLx3OYr3s10XvOXPS10UzyY8L+o6cnbyHBy0PsNd pTbRkUPYlkzJ0uKboXQcbRYzQ+7NwHaJ9k+3UbXaEK5tl6e6/5kOyau5TIfa4TLOO/Te 4CF4dXl14h/0TLvAhPgqtlJJXNA+rejXHhePeS5SxDvVjq9N3ZhqsqXEzxNh7e1tAD3R NIeG1as7ZFCN56gnlXZ0jG2GZ3EOUFS6+Gp8Jd5n9UiT+5dAq0gW1xY+0T/w21qxKfAL rPfqIRTqr6VC8aKhmXo7IHzfAlYtwTaaca0CXJ2gZWz9ZYxb5A7TfQ2E0AIrCBTd16dP zgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701339082; x=1701943882; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BQKXf1q2OEZnZ3kEZQU0tyP5ahd6SKR/Xu20SNGKyvI=; b=lGjoahD+a3qviM0AchV+EFJrd8AzeDTMYLBsa6PjwFW0Cu5RaGtYJX91WvMuXjq4Ap vVXf7EbfnsyNgFhjNH3n9WWZpjZxgH5/aTo+MOZlmMP511PsMEeS600bcwgFRsRAuUQX q9vER3t5Bz+8Iw3EzER6pzmpPIfdWnYnkVY9JxHVqBaKa7WDcNX+L38uZ13wkWMJtfOq 1ll2u+59vOEn51J/Hwo2iwCOO6255N88g16oph0+Z3gy1wGBs+HB6rHYu/KCktvauf5+ U6zjYWZ8RMq49fIAUjcxMEpW9pON//fz0rRPxY42z/8NylHSnfTYFuNHx+C+ne5F7UC5 k/tg== X-Gm-Message-State: AOJu0YxOAtmJ+wCScPjQwwxkNcn228d1KkAiBXqtA2C0mXaoY8Ov8CdA 0WQ7Pd7ktPk3IkMm9w6LiQ2m5I/TfM0rlr8dWbg= X-Received: by 2002:a17:906:2756:b0:9bd:9bfe:e40b with SMTP id a22-20020a170906275600b009bd9bfee40bmr13385846ejd.75.1701339082444; Thu, 30 Nov 2023 02:11:22 -0800 (PST) Received: from [192.168.209.83] (178235187166.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.166]) by smtp.gmail.com with ESMTPSA id r21-20020a170906281500b009fca9f39e98sm504965ejc.26.2023.11.30.02.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 02:11:22 -0800 (PST) Message-ID: <1e014d8c-9a46-4a99-bca2-9f84598bd614@linaro.org> Date: Thu, 30 Nov 2023 11:11:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Neil Armstrong References: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> <20231129140537.161720-2-krzysztof.kozlowski@linaro.org> <3ec70fd9-11a3-4bd3-bd8c-a73c3d44dcde@linaro.org> <0be610ed-ac95-4de1-9639-d634cf979359@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <0be610ed-ac95-4de1-9639-d634cf979359@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 02:11:33 -0800 (PST) On 30.11.2023 09:06, Krzysztof Kozlowski wrote: > On 29/11/2023 15:35, Konrad Dybcio wrote: >> On 29.11.2023 15:05, Krzysztof Kozlowski wrote: >>> The TX Soundwire controller should take clock from TX macro codec, not >>> VA macro codec clock, otherwise the clock stays disabled. This looks >>> like a copy-paste issue, because the SC8280xp code uses here correctly >>> clock from TX macro. The VA macro clock is already consumed by TX macro >>> codec, thus it won't be disabled by this change. >>> >>> Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers") >>> Reported-by: Neil Armstrong >>> Signed-off-by: Krzysztof Kozlowski >>> --- >> Interestingly, downstream 8550 has >> >> qcom,use-clk-id = ; >> >> which doesn't seem to be used in techpack > > In which node? I see it in the va-macro node, not the tx-macro. You're right, I misread this. Konrad