Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp207009rdb; Thu, 30 Nov 2023 02:37:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IGel+pVO2d5DPLX0ZK2uOoNTZp2ndglN0jp/bV34lucoZKbaGzJorRvTehD2aujnz6O6XUM X-Received: by 2002:a05:6a00:1387:b0:6cb:634a:c83a with SMTP id t7-20020a056a00138700b006cb634ac83amr26210412pfg.33.1701340648655; Thu, 30 Nov 2023 02:37:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701340648; cv=none; d=google.com; s=arc-20160816; b=OFhdbloYxkUq0qEZVRySvCRxYdUGqZxH6qG8zl8ULsiWP4YhQqq2QvG5kGuBHxs2oL zVAt0LbVP87vNytR+fDH0PlNQSzyLSTRGDqqLelZVTd8/u88H8bq4MaPgdUfrJB9g1d9 o3qJqOFYtf1OW3s6THIQIvDpdeEVXaFFDYuoetIHB75So/Ff6WiXErUtb7yjmw0BGUWi Tddgnye3cw1e+hZ5pMcgDst3rRLiq6lr+TDx6hW/VoV6Wof0zNXpXEyaD7r8o0tjo8TW f1JON0wBQIYljVdJrmnTkxBc5z3dkHgIihv9M7KiBd4xmnWwCA6P30VKXEgoDJGPMkxs R3Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=v0R0X/tEDAFQ1Cw6FG8BvYToNksRWGXJ4ydPG09Sl/s=; fh=xsG2tQu8CEORfzNsNSHIIqJ9PCEVdWonZ7p+zzc4p2Y=; b=YuqpbeF7t1n27JYoM163sG+t0KgN8Pu1HxCNfs+GwPhuxR1IVRagj3gAaOom7eBIdK QGFKXHpGfVLQpAxEizNIC6+OLvfBNLOi7au3VB5eS4/H7lHGhxu3AQ+6PCY38Is3+BP5 GN92eg+g8Ip7+qQLeWzaqMM5Vr/cqNvxE0rq6yClBP8EJ+L9O7r0S5Iy9D3fsgqKDaDv L7IVjpu+00gVtJDJD+4+Aibw1ZpbOYWPcOtbT/cqXdTZ1FbkFKpPuakiahccdhMTwsCT +H/8Ziu+bQDkySBPxDDsPkFjbRk1Ejf4vZ2/OtDr3JPBN13DXpTZwWIW/FLfO8EwW8fZ rLew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QBpeFecd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j11-20020a056a00130b00b006cb4c6074c8si974132pfu.311.2023.11.30.02.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 02:37:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QBpeFecd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8190E802F701; Thu, 30 Nov 2023 02:37:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235154AbjK3KhA (ORCPT + 99 others); Thu, 30 Nov 2023 05:37:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235140AbjK3Kgr (ORCPT ); Thu, 30 Nov 2023 05:36:47 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B5AE1719 for ; Thu, 30 Nov 2023 02:36:52 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-54b89582efeso774726a12.0 for ; Thu, 30 Nov 2023 02:36:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701340611; x=1701945411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v0R0X/tEDAFQ1Cw6FG8BvYToNksRWGXJ4ydPG09Sl/s=; b=QBpeFecdLMjmXMPxxBjS+RKUyRx/1TErLBi0eGPtknqV6gAwtALp13XooUOP1tk5F4 XNumcPgn8VH9poJm7cajRSmyWJJVr5QtIa22jKsi8RFip+hsJMcuFj78YzmYQR1+v0b5 i/9stUgfPpOy4e7ZpWROCCbHTnJYptDxzByUJygL4i3UVNt/PDEZp1E9mPWuZqc3Rf9R PlefZ9OpCrnCOkOFDs+t78x0Z/HUeWj9NCeWpVPsakGsVQ6EOxNqpybHB2eqSe4+XURh BoJCjgawPrPVN6l1zGNUVW2qvsPflCXqFIuOqkJpNoqYkQgFCFsp3Tjq/xmoqWqkDBoU LFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701340611; x=1701945411; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v0R0X/tEDAFQ1Cw6FG8BvYToNksRWGXJ4ydPG09Sl/s=; b=iuQpslozmydrR+XkKO+mtpiNafb/n/DfQSbR+Y1frkuTPZO50VV6ewiliiAO09D87v BeKivhR4NnE8qXt4v+B9uTzgHL0QEfi4njAa50vSrb1hlt0NMFS0by3Ovlh9U7Op5t97 GcZvJWiJOwQ49aQOH8P06AY4c1yxqm1iwM9VUjQxv17R/bOiffjkLE7PiPNC1TffX9cy qVDHhuz4+DCeiGouUMUOM/Gz+70E7ldqb5Fz3aweJtMb9zHsQ6zoVOIJ9EUpCsrhSEPW cG8oZ2gIDN4dBELMscMAj5udEV4WEiP7vxFld1ipbKDmvR1LZOCk/0Zv9Gqg2wo4VlHf x/Mw== X-Gm-Message-State: AOJu0Yw2AKKjDfGR6ZZYtkmjjkJVk7jf67hMfK59wfMGlS09n9lG0WSx a1RBg3EkLMfSvEtwAlBAjcF1guYaO+S3P7OPa9E= X-Received: by 2002:aa7:c68f:0:b0:54b:a930:b4c4 with SMTP id n15-20020aa7c68f000000b0054ba930b4c4mr5283992edq.15.1701340611019; Thu, 30 Nov 2023 02:36:51 -0800 (PST) Received: from [192.168.209.83] (178235187166.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.166]) by smtp.gmail.com with ESMTPSA id v9-20020aa7d9c9000000b0054b1fca00c7sm417277eds.74.2023.11.30.02.36.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 02:36:50 -0800 (PST) Message-ID: <34afe467-bf18-4328-8325-0f2cce4982d3@linaro.org> Date: Thu, 30 Nov 2023 11:36:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void Content-Language: en-US To: Tengfei Fan , andersson@kernel.org, agross@kernel.org, linus.walleij@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@quicinc.com References: <20231130024046.25938-1-quic_tengfan@quicinc.com> <20231130024046.25938-4-quic_tengfan@quicinc.com> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231130024046.25938-4-quic_tengfan@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 02:37:21 -0800 (PST) On 30.11.2023 03:40, Tengfei Fan wrote: > Use .remove_new() instead of .remove() for converting to platform remove > callback returning void. > > Signed-off-by: Tengfei Fan > --- You misunderstood me, this series now introduces a driver with known issues and patches them up right away in subsequent changes. What you should do in such situations is squash the fixups into the newly added driver (e.g. by running git rebase -i baseofyourtree and changing 'pick' to 'f' (for 'fixup') on the last two patches). Konrad