Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp217783rdb; Thu, 30 Nov 2023 03:02:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IF85lOVrfhmCwqBbUQxnVnMFkO3S52VOl1z5SAMkaZT0y9vPjHrlvoq+o2pEPZMp5I/t5A7 X-Received: by 2002:a05:6a21:328a:b0:187:15e2:fdd9 with SMTP id yt10-20020a056a21328a00b0018715e2fdd9mr21840971pzb.39.1701342145856; Thu, 30 Nov 2023 03:02:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701342145; cv=none; d=google.com; s=arc-20160816; b=G2Ss/i7liAzsK6rITitjVR+V5mmRlWhgXXJgGfnH4ZVXZodSuAa3yoVeSx7vUMvjl2 c3Y/zlhVuly7QiJfYGJv7+SxxLTyN53B4WoD6YqJ3NJvZ2M7Qinq1GxYG1HkyBI5R2SI 5vR0ZlUEPhxwWSzQDyVCHIhiUQrllIZc9bExV4nR1epcUlIxlDfhe+Uwvy0eX/19k/pK 0WNshA1rmbZgaP5t/b7/1UO3tdUb34x/rGsyAYMKmL30T8n+9M0/SyoCLtnyGFQVzVrC j1+zJGDxHCYO8CH3CbB0deEem79pokHt2XiA74xOy9mLi/eDuRACZxgXY23em+lCO0Dz ZHgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=twBiByV0Ya8Og8m9kgEJ71MT4XpVwLM2wlySX/ANoEA=; fh=xdIClvGFRVyhf4fQQBj75tpTj0KguYr4ZF3SZ/9+VRw=; b=masGbuvkg/+fBcyQxZnIrlRnMkQ40kBjLO4V1XHwM5qgVIZ2zdsdIyXq+aS7plMVRa aFjyBVTGAKOPIGqpERHqJBQ+R8inRKFfQ30NmV/Wx/Q6ssphW0cj4lOtrDyZAB7wFd8o 6W1iseOTbKWgHdlPyY2LgAnj9j3RqSOpHeK4u3GrQG342g0YEoHBr4MmZ3jcREM5GGpq FFhgDt0uBc2WEXNOY06jBtBAB51v2idC2UcyeXWyDsJ5JkgYJJxXYC52KjjuBqpKnsaW lk9eWguZDclrv1GOgNMXfWe8hre72/jaAwu8AhQJXInuLFIGq9joj7ltQ7VuDUmfe3nH rXkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id qe10-20020a17090b4f8a00b00285a152fd31si1203985pjb.62.2023.11.30.03.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 03:02:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D1FF98025166; Thu, 30 Nov 2023 03:02:21 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231881AbjK3LCF (ORCPT + 99 others); Thu, 30 Nov 2023 06:02:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbjK3LCE (ORCPT ); Thu, 30 Nov 2023 06:02:04 -0500 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A053FD50; Thu, 30 Nov 2023 03:02:10 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R241e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=guwen@linux.alibaba.com;NM=1;PH=DS;RN=20;SR=0;TI=SMTPD_---0VxRQVSY_1701342127; Received: from 30.221.130.31(mailfrom:guwen@linux.alibaba.com fp:SMTPD_---0VxRQVSY_1701342127) by smtp.aliyun-inc.com; Thu, 30 Nov 2023 19:02:08 +0800 Message-ID: <319ca57a-c89b-ba37-c5ca-e1eafc73392f@linux.alibaba.com> Date: Thu, 30 Nov 2023 19:02:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH net-next v2 1/7] net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity To: Wenjia Zhang , wintera@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com, jaka@linux.ibm.com Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, alibuda@linux.alibaba.com, tonylu@linux.alibaba.com, raspl@linux.ibm.com, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1700836935-23819-1-git-send-email-guwen@linux.alibaba.com> <1700836935-23819-2-git-send-email-guwen@linux.alibaba.com> <298442c7-40f0-42ab-b5cb-07603d8689f5@linux.ibm.com> From: Wen Gu In-Reply-To: <298442c7-40f0-42ab-b5cb-07603d8689f5@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.9 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 30 Nov 2023 03:02:22 -0800 (PST) On 2023/11/29 20:50, Wenjia Zhang wrote: > > > On 24.11.23 15:42, Wen Gu wrote: >> Rename some smc_clc_first_contact_ext_v2x type variables to 'fce_v2x' >> to distinguish them from smc_clc_first_contact_ext type variables. >> >> Signed-off-by: Wen Gu >> --- >>   net/smc/smc_clc.c | 26 +++++++++++++------------- >>   1 file changed, 13 insertions(+), 13 deletions(-) >> >> diff --git a/net/smc/smc_clc.c b/net/smc/smc_clc.c >> index 0fda515..c41a249 100644 >> --- a/net/smc/smc_clc.c >> +++ b/net/smc/smc_clc.c >> @@ -418,15 +418,15 @@ static bool smc_clc_msg_prop_valid(struct smc_clc_msg_proposal *pclc) >>       return true; >>   } >> -static int smc_clc_fill_fce(struct smc_clc_first_contact_ext_v2x *fce, >> +static int smc_clc_fill_fce(struct smc_clc_first_contact_ext_v2x *fce_v2x, >>                   struct smc_init_info *ini) > > Since this function is only used by v2.x, IMO, this function name could also be changed to e.g. smc_clc_fill_fce_v2x. Thank you, Wenjia. The function name will also be changed.