Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Thu, 30 Nov 2023 11:32:54 +0000
From:   Lee Jones <lee@kernel.org>
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Expand led_colors[] array
Message-ID: <20231130113254.GI1470173@google.com>
References: <20231030054757.3476-1-jszhang@kernel.org>
 <20231123105620.GG1184245@google.com>
 <ZWS80c/ZQvaGIM96@xhacker>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZWS80c/ZQvaGIM96@xhacker>
Precedence: bulk

On Mon, 27 Nov 2023, Jisheng Zhang wrote:

> On Thu, Nov 23, 2023 at 10:56:20AM +0000, Lee Jones wrote:
> > On Mon, 30 Oct 2023, Jisheng Zhang wrote:
> > 
> > > commit 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID
> > > definitions") expands LED_COLOR_ID definitions for dt-binding. However,
> > > it doesn't expand the led_colors[] array in leds core, so if any of
> > > the newly expaned LED_COLOR_ID definitions is used, the sysfs will
> > > emit null in the led's name color part. Let's expand the led_colors[]
> > > array too.
> > > 
> > > Before the commit:
> > > /sys/class/leds # ls
> > > (null):indicator-0
> > > 
> > > After the commit:
> > > /sys/class/leds # ls
> > > orange:indicator-0
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > ---
> > >  drivers/leds/led-core.c | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > 
> > This already exists as:
> > 
> >   a067943129b4e leds: core: Add more colors from DT bindings to led_colors
> 
> well, my patch was sent earlier than this one... When I sent out the
> patch there's neither fix in mailist nor in your repo.

What makes you think that?

The applied patch was submitted 8th October.

https://lore.kernel.org/all/20231008144014.1180334-1-megi@xff.cz/

Yours was submitted 30th October, 3 weeks later.

https://lore.kernel.org/all/20231030054757.3476-1-jszhang@kernel.org/

-- 
Lee Jones [李琼斯]