Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <5ef0372a-2b9d-4a19-bbb4-2c6ce29dbe79@quicinc.com>
Date:   Thu, 30 Nov 2023 21:12:56 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: msm8996: Fix 'in-ports' is a
 required property
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Tao Zhang <quic_taozha@quicinc.com>
References: <20231129143815.7892-1-quic_jinlmao@quicinc.com>
 <20231129143815.7892-2-quic_jinlmao@quicinc.com>
 <3527d540-3e3f-4edb-b5f2-6ac481132c06@linaro.org>
 <591e1aca-20ca-4d42-809d-12cd12ddadb3@quicinc.com>
 <35916812-af55-4b2a-99e5-8566e945cb6e@linaro.org>
From:   Jinlong Mao <quic_jinlmao@quicinc.com>
In-Reply-To: <35916812-af55-4b2a-99e5-8566e945cb6e@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/30/2023 8:06 PM, Krzysztof Kozlowski wrote:
> On 30/11/2023 12:15, Jinlong Mao wrote:
>>
>>
>> On 11/30/2023 4:55 PM, Krzysztof Kozlowski wrote:
>>> On 29/11/2023 15:38, Mao Jinlong wrote:
>>>> The inport of funnel@3023000 connects to a source which is not supported
>>>> in current linux kernel. Remove the device tree node of funnel@3023000
>>>> to fix the warning. It will be added once the driver support to the
>>>> source is added to linux kernel.
>>>
>>> Thanks for the changes, but that's not correct reason to remove DTS
>>> code. What kernel supports or not, should be irrelevant for the DTS. DTS
>>> for example is used in other projects - did you check if they have the
>>> same issues? Anyway, DTS describes the hardware, so how current kernel
>>> support defines what is and what is not in the hardware?
>>>
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> The funnel dt node must have in-ports node. It is to describe the input
>> connection of funnel HW. But there is no dt_binding doc to describe the
>> DT node of the HW connected to funnel@3023000. So remove the funnel to
>> solve the warning as of now. The funnel will be added back once driver
>> and dt_binding are added for the HW.
>>
>> Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> 
> Why we cannot add now the binding for the connected hardware? It's not
> really related to the driver.
> 
> Best regards,
> Krzysztof

Do you mean yaml file can be added before the driver code is merged ?

Thanks
Jinlong Mao
>