Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp298268rdb; Thu, 30 Nov 2023 05:18:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/nKYx5ScT4myqv0ybIBHg3s6PfbRsVb14SMTf291qv8XmUDEzJsR1tkFBx6JAvHZfDeVB X-Received: by 2002:a05:6808:1c5:b0:3b8:490c:1750 with SMTP id x5-20020a05680801c500b003b8490c1750mr24887271oic.21.1701350295884; Thu, 30 Nov 2023 05:18:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701350295; cv=none; d=google.com; s=arc-20160816; b=J50AOwJpDQbwy3ymGNFPWk0BWOjfy/yPr//4JK1whaYnx0QDTLWHRkkj6jFcfsIxYp UFjAPNN/Qn5Vb+ANZiVGVgR1uoywpmeqIqh8OgUBap6pOUqFaXZSIJ7+qMTEy+/wnypM Nn3Bwykh4dlrIbJscpMTl6oHna/gIsjpJP8rozPnBmB0ad4oONXb1hgu32sodV/EW4uO /BVMPLlMwDYdy9WCjUZPnFMQxdg3aJK/mp6bw2PF2gbWfpRqwJgDjjDL63uLyZAuTrmS vldVFK7RJ45zDjPuCSprS7OO20d4NvZMe1rLMtayWsELHBfU08gnFZdCDYsNQBtmkGID 5Flw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=vlXcJnJfbzP+KHmyRlwotOspPMF9m/kv8lEKSowqPVA=; fh=wIHqZpOIuzcidDZ82yQbOZuyHJty7uvaWDEh/efoVzA=; b=FtncVrD4qVfWAIQ1h6uv45njOUQGpjPqgA3mCD6on4Ngyx034zlU6PTcN1ZHk0wFUx xQNvQPdRwTO9PzaxAlPllNvlfggMicRo8f5eu/qsunArnf1XxW7MaTU6F2xHKnmA3xJN Z+neLoC7MXsrUTRM5glVAXSSFMkxfhi0fq5zuqBTzpgj4/Ck29ZP7Nj9HSyfF7DlYDDo 3WY48vNwuERbKGfcW9VWC4ABTxtMJG/3cinRRQvgxvoprTZHFuxDQPUOjCEJ87A0g9/C udaPx2lrVivSyQ9aMjs8DEXqhcmv34OkLLiNUSckzAHEFuOWwnEft5SCFJKrJ6WDmDWU +6jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=iN9F0Z6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m13-20020a634c4d000000b005b96d038729si1204265pgl.728.2023.11.30.05.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 05:18:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@salutedevices.com header.s=mail header.b=iN9F0Z6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=salutedevices.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0648D802A83A; Thu, 30 Nov 2023 05:18:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345497AbjK3NR5 (ORCPT + 99 others); Thu, 30 Nov 2023 08:17:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbjK3NRy (ORCPT ); Thu, 30 Nov 2023 08:17:54 -0500 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77D87B5; Thu, 30 Nov 2023 05:17:58 -0800 (PST) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 250B5100003; Thu, 30 Nov 2023 16:17:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 250B5100003 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1701350275; bh=vlXcJnJfbzP+KHmyRlwotOspPMF9m/kv8lEKSowqPVA=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=iN9F0Z6Ef1WJZLQeMkqojSwFwuTO9Obc7sccnv+seh+l4vPOoutrn7y7YyfUSRN1R gY8SAs38cduW37dP+B9vgJYqH/FcTxI0dXIWrzXiuqYo2xf+hEvUEMqLAmHLCuHIvX hQYNIjVTdmR4U+4mi4+hcfOhkpG2CUxdOYLkWYIGXnTJdLU0xijBXpUanR7V/WeIFd hr3789b2vZ14VsiQp/5E/lQjjsF3iZOkBNtr5kAUjzwkSZrTUZClSuchP5QIP3dwLc 2KoEI+NKwDG8ArCX5B1w0943kgNqfS1h+KhJ//jAF1f2DUQBosvge68SmW6CipoRC/ QHBtehsHtiSJQ== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Thu, 30 Nov 2023 16:17:54 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 30 Nov 2023 16:17:54 +0300 From: Arseniy Krasnov To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Jason Wang , Bobby Eshleman CC: , , , , , , Subject: [PATCH net-next v5 0/3] send credit update during setting SO_RCVLOWAT Date: Thu, 30 Nov 2023 16:08:37 +0300 Message-ID: <20231130130840.253733-1-avkrasnov@salutedevices.com> X-Mailer: git-send-email 2.35.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181736 [Nov 30 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: avkrasnov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 5 0.3.5 98d108ddd984cca1d7e65e595eac546a62b0144b, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;100.64.160.123:7.1.2;git.kernel.org:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;salutedevices.com:7.1.1;lore.kernel.org:7.1.1, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/11/30 10:41:00 X-KSMG-LinksScanning: Clean, bases: 2023/11/30 10:41:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/30 11:05:00 #22583687 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 05:18:13 -0800 (PST) Hello, DESCRIPTION This patchset fixes old problem with hungup of both rx/tx sides and adds test for it. This happens due to non-default SO_RCVLOWAT value and deferred credit update in virtio/vsock. Link to previous old patchset: https://lore.kernel.org/netdev/39b2e9fd-601b-189d-39a9-914e5574524c@sberdevices.ru/ Here is what happens step by step: TEST INITIAL CONDITIONS 1) Vsock buffer size is 128KB. 2) Maximum packet size is also 64KB as defined in header (yes it is hardcoded, just to remind about that value). 3) SO_RCVLOWAT is default, e.g. 1 byte. STEPS SENDER RECEIVER 1) sends 128KB + 1 byte in a single buffer. 128KB will be sent, but for 1 byte sender will wait for free space at peer. Sender goes to sleep. 2) reads 64KB, credit update not sent 3) sets SO_RCVLOWAT to 64KB + 1 4) poll() -> wait forever, there is only 64KB available to read. So in step 4) receiver also goes to sleep, waiting for enough data or connection shutdown message from the sender. Idea to fix it is that rx kicks tx side to continue transmission (and may be close connection) when rx changes number of bytes to be woken up (e.g. SO_RCVLOWAT) and this value is bigger than number of available bytes to read. I've added small test for this, but not sure as it uses hardcoded value for maximum packet length, this value is defined in kernel header and used to control deferred credit update. And as this is not available to userspace, I can't control test parameters correctly (if one day this define will be changed - test may become useless). Head for this patchset is: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=f1be1e04c76bb9c44789d3575bba4418cf0ea359 Link to v1: https://lore.kernel.org/netdev/20231108072004.1045669-1-avkrasnov@salutedevices.com/ Link to v2: https://lore.kernel.org/netdev/20231119204922.2251912-1-avkrasnov@salutedevices.com/ Link to v3: https://lore.kernel.org/netdev/20231122180510.2297075-1-avkrasnov@salutedevices.com/ Link to v4: https://lore.kernel.org/netdev/20231129212519.2938875-1-avkrasnov@salutedevices.com/ Changelog: v1 -> v2: * Patchset rebased and tested on new HEAD of net-next (see hash above). * New patch is added as 0001 - it removes return from SO_RCVLOWAT set callback in 'af_vsock.c' when transport callback is set - with that we can set 'sk_rcvlowat' only once in 'af_vsock.c' and in future do not copy-paste it to every transport. It was discussed in v1. * See per-patch changelog after ---. v2 -> v3: * See changelog after --- in 0003 only (0001 and 0002 still same). v3 -> v4: * Patchset rebased and tested on new HEAD of net-next (see hash above). * See per-patch changelog after ---. v4 -> v5: * Change patchset tag 'RFC' -> 'net-next'. * See per-patch changelog after ---. Arseniy Krasnov (3): vsock: update SO_RCVLOWAT setting callback virtio/vsock: send credit update during setting SO_RCVLOWAT vsock/test: SO_RCVLOWAT + deferred credit update test drivers/vhost/vsock.c | 1 + include/linux/virtio_vsock.h | 1 + include/net/af_vsock.h | 2 +- net/vmw_vsock/af_vsock.c | 9 +- net/vmw_vsock/hyperv_transport.c | 4 +- net/vmw_vsock/virtio_transport.c | 1 + net/vmw_vsock/virtio_transport_common.c | 27 +++++ net/vmw_vsock/vsock_loopback.c | 1 + tools/testing/vsock/vsock_test.c | 142 ++++++++++++++++++++++++ 9 files changed, 183 insertions(+), 5 deletions(-) -- 2.25.1