Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp304869rdb; Thu, 30 Nov 2023 05:28:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHckOWLuc3ioamACMplGBuS+8fDjld68rc2AIv12p1OAOeYCSyOw0BVY/82Po3Erk1YD2RR X-Received: by 2002:a17:90b:4b0e:b0:285:a273:6822 with SMTP id lx14-20020a17090b4b0e00b00285a2736822mr23345302pjb.6.1701350921992; Thu, 30 Nov 2023 05:28:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701350921; cv=none; d=google.com; s=arc-20160816; b=m8auLdMBNDAluciNnMEWoZWWDa9O+IZxEHeE5lIRFt/7Z/J7xYFKCOqbPlVLIp1H+t YEuT5BHqUVBWMmWtGOLy+YDwrezuzxI+ZhevyUPQCclDBrltXBU84DPWLTdKeL658wRT sT+u9+6G9PaHG48M0g6lskAwAE5u0E9IqpKf3LF6U+5xI6CxSvAUhl+D5P49Y2ddGI5w 9tQkqWMJinsVU+4qYAmq6JbDVLVU6P27CDyY4elxwLeRLfje6kzKXfJ7a9929DhKDPez a0Rhoff1gbp+I+Mow+Os0ZiTlWRpIuQQHXU9HRV8vdyott0m0t3mbmc1sHP93wioFvln LKlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=OMBgnZg82HyYnOpguDgqJnKoMa2D/EW1CFG4f3G91z0=; fh=I2AWSLlCg8dmI3TKuHDOsU4PzReJYJX6bLy21/NLBWw=; b=f0Pfi9mmgaY/HU4Mw9WPD9XeVwjAAwBcEAEUH9cwHCYXwoPFCh6rGsv19oo51dOq1y mdMLsnULn6GLb7lh+wHLULQ8XYNl5X1pDTJgUJ1ZzPkE0e37Zqd2858sQ/c/f+6QyjIq vtFOqm3PRxpANdTbVIywKTks8NOtCpgO6Jf9sBJTtDCcq9wUeUPZb3CyR76l4HClROjV 9Yz4y7G0NpLIPcyJUdsnChbXGqZTDNkqAPLKIPK9irG7sb8Y2O+j3IMYg3KN+KlQmpuA D/OwIcjQuNWoOnJFOhLzRgtx2MuDOZc9Jp2YvTDa4TeUO5k0QLjslQVQz1OwccnUcpR2 w+Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JZRyFXkw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id bn4-20020a056a02030400b005b8f9dbbd5fsi1401796pgb.409.2023.11.30.05.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 05:28:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JZRyFXkw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id AD1C780CBF34; Thu, 30 Nov 2023 05:28:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345484AbjK3N2T (ORCPT + 99 others); Thu, 30 Nov 2023 08:28:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232159AbjK3N2S (ORCPT ); Thu, 30 Nov 2023 08:28:18 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5F0D48; Thu, 30 Nov 2023 05:28:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701350904; x=1732886904; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ghr+ezRKo3dkSi3M8C6UorBjmizIlKFEixhMc9v7FuQ=; b=JZRyFXkwsJor42bwB5QyvAtMoZHpMHeRfnh6aranOBz8kQ+60+XoL3mU MJorakhkFM2nUFqX4cfKI7ucOdKInV7ujDUdHjBIKVMYHnhmvB0QMYLOe Gys9Zxm5+UmyHmHU85qBXEbwt7RfQsQuucJcI/0corgE35Z5mBYxvJhgy 92nlzCRWz8iwbr8nhOKYwG+qyhs4whS36lEhFauexnx02NCgfehW+3Mt4 nQxD2AtweapRMhe96HAxvm6ElXjNw/tph6fVGmM82g5nzz3JDpU09qstX BnCOUgKK3kTXd6TPEGaXrVK5oAgWiFRTEdmBB4Ck1I2esdibEFKmsT9Io A==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="392187071" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="392187071" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:28:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="769307685" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="769307685" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:28:21 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r8h5W-00000000ht8-1SQQ; Thu, 30 Nov 2023 15:28:18 +0200 Date: Thu, 30 Nov 2023 15:28:18 +0200 From: Andy Shevchenko To: Andi Shyti Cc: Mario Limonciello , Jarkko Nikula , Herbert Xu , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Jan Dabros , Philipp Zabel Subject: Re: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe() Message-ID: References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> <20231120144641.1660574-20-andriy.shevchenko@linux.intel.com> <20231129232151.ueum2axn74qzuzes@zenone.zhora.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129232151.ueum2axn74qzuzes@zenone.zhora.eu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 05:28:38 -0800 (PST) On Thu, Nov 30, 2023 at 12:21:51AM +0100, Andi Shyti wrote: > Hi Andy, > > On Mon, Nov 20, 2023 at 04:42:01PM +0200, Andy Shevchenko wrote: > > Since i2c_dw_probe() is going to be extended, uninline it to reduce > > the noise in the common header. > > where is it going to be extended? It's not in thie series. I'm > fine with the patch anyway as it cleans up the header file. It's used to be in the previous versions of the series where I have device_set_node() API to be used. -- With Best Regards, Andy Shevchenko