Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <c7c7295a-ae5e-420a-837e-5bc6e18ee90c@intel.com>
Date:   Thu, 30 Nov 2023 21:28:02 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 05/26] x86/fpu/xstate: Introduce fpu_guest_cfg for
 guest FPU configuration
To:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC:     "Gao, Chao" <chao.gao@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "john.allen@amd.com" <john.allen@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mlevitsk@redhat.com" <mlevitsk@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>
References: <20231124055330.138870-1-weijiang.yang@intel.com>
 <20231124055330.138870-6-weijiang.yang@intel.com>
 <742a95cece1998673aa360be10036c82c0c535ec.camel@intel.com>
 <e8b77875-d7a2-4898-94d2-248e32b6ebf4@intel.com>
 <a8ee5217a98b261a2eace9a0b543e43796607156.camel@intel.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <a8ee5217a98b261a2eace9a0b543e43796607156.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUdqbkZqNUFYeFRHMGFGcnlPVnAvRnAyYXNJZWZJZ1ozT0FpcHB1aS91UG8x?=
 =?utf-8?B?MkUraDhzN2RoeVJHNHV6ZVlmdGpkaVlCRHJEenRLbllwTllkVjdYUTBjdE82?=
 =?utf-8?B?b2dYU21tZ01sTklqVzBwZDBsL3F1b2o2NllJb0J5c3hOcGxyVTVRM3hldnRB?=
 =?utf-8?B?dm1uVENQKzBYK01qemRDaS9iamVUaW85ODlBTlhsQU1wbHQ5cVRwRCt3V1FJ?=
 =?utf-8?B?bm12SWdicmhIMVJSbnBQd3B0Z2pRL1F5bXNpZmhqNnU3dU1Ba1pMQnZwTlRh?=
 =?utf-8?B?QUx3STJxc3gzSlA4d29kSys2NC9uK3QzZDNBQ0xwa3FGcDkzalczOW8zTkQ0?=
 =?utf-8?B?Ky9XdjZTN1VkWW5EN0o1bFNjdTdlVy81aUxUK1FwcE9iQ3JlNFFTRVNrTC91?=
 =?utf-8?B?L0FyMkcxNzhoVG4rYndJVFZwYnBuTWdscGxBM2hFNythcVQ0NlEwUEpvdHRu?=
 =?utf-8?B?WVNvSi8rOHh5dVg2U0VVbTN1TGR6S0ZLcW9UMkxra2tpOVBJd2tnczQ5OEcz?=
 =?utf-8?B?WlVlazNncTgrQ1dIUHVGY2g5aDJRelA4L1RKdGw0Q2NDK0lFbFl5ZHFIcTU3?=
 =?utf-8?B?cHVjWXhzQU1oQVZPTGhRdi9hWkwwQnZXNnJtZVNpQjhnUlJmbGdOSVM2Z2x1?=
 =?utf-8?B?cmhlWEZQU0R6UmRONFlJUVJMMTg1Vml2RURRZk50Vi9PSzc0SnpBQkZJTDQ0?=
 =?utf-8?B?bXgyWjRxM2ppQ3VLOXlGSjRqN2padXZVUHZGSXBCNnRWb2hzSkM3ZURZZGNo?=
 =?utf-8?B?TWxDT2VKQTJyZFlwYkZwRytJWndaNzgwU0JNVC9lcjB5Q0ltYzJOMVV2KzVk?=
 =?utf-8?B?V0p1L3loWFM5YWQwMVQ5YzdwVGk0aG5pSU93RUlTQ1o5eDBudSs4N0o5Qk1y?=
 =?utf-8?B?aEk3QTNPRjQ5V2cvYk1Sd3hueitEditPVFRCd2pVbFR4OUVKZFh3c3RWZjZs?=
 =?utf-8?B?ZHdNaWhZMUpsSmxtYWk4T0t3QmJoVURHa3BaMTYyVW1GSzlXa0VJVlR5d3pl?=
 =?utf-8?B?SVlIWnMwWEpkSzVLWFVNaXdIK3Jua2c0U3pua2t3NGtoYjIwa2Zwem1IZEU1?=
 =?utf-8?B?SkdWUVdwVE5yUXdyazA0VDdLbUpsUktRK1VrS1dydlhuT1ZsUmNlZElrazlk?=
 =?utf-8?B?VkpyTmVaSHRTa1lkWVpqTS8wRnpzV3ZOQ2xmVlA3ZWZrc3RObzJTeENLYTN1?=
 =?utf-8?B?VnFPckowMlJxQXdTZnp3R296MGtmNVEwTmJzdnRPVWFwVkNaK2FGQ3gyOHNQ?=
 =?utf-8?B?TW96anpWVFVvZ0ZsbUJEV09XRVRpMkJldE85dlMrVkM3dUtBWTZ4dkN0Tm9K?=
 =?utf-8?B?bHdwY3NCVDVITzBaZm1OamQ1MTNWcld6TmVkcFpzVCsra3BPb2JTajErcVdM?=
 =?utf-8?B?dDVPMHVsQjkvbUY0RmpRVjRhTUpXQTBqbzJOVkxtSW5DR09LU0VqbGR3aXFJ?=
 =?utf-8?B?cSt1NkFFbnhnNm80MVBjbUMxWEMrbTVYSXdYMjlyaHF3bzd2Z0dRVXZMWStI?=
 =?utf-8?B?aENvaE9LMmZXelp5OEQvWHZibVF2TkduYTh5RGk5Z0NnTDIxQ1RKSnBqR0F0?=
 =?utf-8?B?TzBvRTFwTFNVNFZHTHFySEttUW9LY0o0UnU2YXY4ZWhleHk5dDdNZGI0eGI0?=
 =?utf-8?B?SVJYUEFXUXUrOWcxY1FoRW1kOVByOTNWQkE3WGVsakt0Q1hHcUJxUWFVZTVF?=
 =?utf-8?B?dGVPa0FMdEU0QzlRNmlNVVJJc0x0Tm4yd0pvT3FKWU16YlFGb3RoWDJ6cWpW?=
 =?utf-8?B?MFYwY0ppckNGUzdUT1pKblI0SWhSR3A4MGN3SWlKMFBra3VOMlAwVzl4a0ov?=
 =?utf-8?B?VitvcVlOMVhsQU8xbFdwdDQvRDZITk0vOWZhRzNOa1BHMEpEZy9zMGJMT2RI?=
 =?utf-8?B?ZC96SS9qRGphNHJkNW81dCtPOGE0S0RHWlN6UzlaU3NReHRXN1p5enFCUGwv?=
 =?utf-8?B?Y1JGQVZJRGFwRURKOXQ5NUN5Y1JjUFhoaW9TZ3habmZDcXZtMTNyQ0xDT0Zr?=
 =?utf-8?B?Q0JwQWVjMXc0V05va05YdHo4dXNCbWNPa0dXQyt2cW9CWVQ3SCtGdldhVDV4?=
 =?utf-8?B?V0ZoeWFVYm4xSzNIMkRoeVA4Q3QwRVlRN0Q0NnZiYTFTVS9CWWJUcEJPazdO?=
 =?utf-8?B?UW82WHJIOVZrQ0xycnRUem8xWTJzTFZjL1JvT3RWems1d2ZxaTVlT1JVODVi?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e2ad79-37d8-414c-d709-08dbf1a832d7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 13:28:11.6639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xq4UEhslau6TDlPEcCXFXh5Bw+0WRJeBnUKWmCOTwlS09VdAbuVuqQUiUSZyWS+NYhD4DvsRsTjrKL7fzQDOvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6951
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 30 Nov 2023 05:28:46 -0800 (PST)

On 11/30/2023 1:08 AM, Edgecombe, Rick P wrote:
> On Wed, 2023-11-29 at 22:12 +0800, Yang, Weijiang wrote:
>> On 11/28/2023 10:58 PM, Edgecombe, Rick P wrote:
>>> On Fri, 2023-11-24 at 00:53 -0500, Yang Weijiang wrote:
>>>> +       /*
>>>> +        * Set guest's __user_state_size to
>>>> fpu_user_cfg.default_size
>>>> so that
>>>> +        * existing uAPIs can still work.
>>>> +        */
>>>> +       fpu->guest_perm.__user_state_size =
>>>> fpu_user_cfg.default_size;
>>> It seems like an appropriate value, but where does this come into
>>> play
>>> exactly for guest FPUs?
>> I don't see there's special usage of this field for vCPU in VMM
>> userspace(QEMU).
>> Maybe it's mainly for AMX resulted usespace fault handling? For vCPU
>> thread,
>> it's only  referenced when AMX is enabled via __xfd_enable_feature()
>> .
>>
> In that case the "so that existing uAPIs can still work" comment seems
> misleading. Maybe "this doesn't come into play for guest FPUs, but set
> it to a reasonable value"?

Ah, I mistook it for uabi_size and added comments. Will reword it properly.
Thank you for bringing it up!