Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp330565rdb; Thu, 30 Nov 2023 06:07:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IElhWA3cfE/XqUTUx3gJgDY2iOjo0u+WIeD7MBt1LxgsgKzUb7oKiDnpOeng52oiJUHSetc X-Received: by 2002:a05:6870:568d:b0:1fa:26b3:4411 with SMTP id p13-20020a056870568d00b001fa26b34411mr21613141oao.7.1701353224404; Thu, 30 Nov 2023 06:07:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353224; cv=none; d=google.com; s=arc-20160816; b=jYqqfSmv709eAa5WCejJkALosoU7bral/6tWP5xMGZ4rU5oomoxqibhBUVv+1hu5hH I6t4vJMnYyueQtuwQmr8P0VO3N6jStHE1o9/dRCBTgGtgGhoQCZP3/zYZ3wSOYxlUb+y ELFzDEysWczv7Lb2XouNjJz5Rxi+X1/lOTm8P/LiQg3Ay4AwG00cngCvrGC+ekJU5rKN +f6BiRfg4tWPnXG+ZOhSv07Gv6ve84KphShYLH3qcCflAUARgZGNpVU7tcE0eMlLdOp0 WS3HnVBQi2vYzSp3frxCtJ8qHV6N4BUP1KT1/Do/oeRxLNOMs/UcLHpWSdqeuKD+d3jg g80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=KO4D/Y9f6b7OmQpSmTDdRPeWTcziTTmxSeOnVLG2oSs=; fh=Bc3XfRN5bgDSwmwTyv2b1udbrmFvn98XPqfXYDgY+v0=; b=j+QUZNCnaDd9pAwnwplIPmHZZbeIaZUo5nkQQeAqpFcO0r2P3H8tXtLPGgxEyA/OXh fi16hoDdAC8g9i3+JKH0CJaYlx7gQOC/3usvDqRxaLethRCrOvqdsiIZOMNeFeCSQhN2 Imn39T2djOcsbysWn47fqykseR07+KFVee3h1X3Z6FPeNb6Pq9vXCJqjRoNs+Gpl54sC vlDmF0O+FHwfMSQFo6X/lJziCZqMVpGtI4mgB/bcpxLWjmYvqBsCfPMKSJ0nqkpbFDEq JWPIjS6ZVBvat2UJGmNNbTA2yt2IzWookUdXgOxD0ikAiXHoq4tMQbFiBzgne7mruyeA rLUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id b21-20020a05687061d500b001fab36fa73esi424674oah.325.2023.11.30.06.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:07:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 74E088028531; Thu, 30 Nov 2023 06:06:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345800AbjK3OGg (ORCPT + 99 others); Thu, 30 Nov 2023 09:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345768AbjK3OGf (ORCPT ); Thu, 30 Nov 2023 09:06:35 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7C2E196 for ; Thu, 30 Nov 2023 06:06:41 -0800 (PST) Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r8hgb-0001aa-DR; Thu, 30 Nov 2023 15:06:37 +0100 From: Philipp Zabel To: Vivek Gautam , Dmitry Osipenko , Mark Brown , Geert Uytterhoeven Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org In-Reply-To: <2440edae7ca8534628cdbaf559ded288f2998178.1701276806.git.geert+renesas@glider.be> References: <2440edae7ca8534628cdbaf559ded288f2998178.1701276806.git.geert+renesas@glider.be> Subject: Re: [PATCH] reset: Fix crash when freeing non-existent optional resets Message-Id: <170135319678.682649.10186168762521739609.b4-ty@pengutronix.de> Date: Thu, 30 Nov 2023 15:06:36 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-5c066 X-SA-Exim-Connect-IP: 2a0a:edc0:0:1101:1d::54 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:06:52 -0800 (PST) On Wed, 29 Nov 2023 17:55:33 +0100, Geert Uytterhoeven wrote: > When obtaining one or more optional resets, non-existent resets are > stored as NULL pointers, and all related error and cleanup paths need to > take this into account. > > Currently only reset_control_put() and reset_control_bulk_put() > get this right. All of __reset_control_bulk_get(), > of_reset_control_array_get(), and reset_control_array_put() lack the > proper checking, causing NULL pointer dereferences on failure or > release. > > [...] Applied to reset/fixes, thanks! [1/1] reset: Fix crash when freeing non-existent optional resets https://git.pengutronix.de/cgit/pza/linux/commit/?id=4a6756f56bcf regards Philipp