Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "'marc.ferland@gmail.com'" <marc.ferland@gmail.com>,
        "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "marc.ferland@sonatest.com" <marc.ferland@sonatest.com>,
        "jeff.dagenais@gmail.com" <jeff.dagenais@gmail.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 4/5] w1: ds2433: use the kernel bitmap implementation
Thread-Topic: [PATCH v3 4/5] w1: ds2433: use the kernel bitmap implementation
Thread-Index: AQHaI5Se1RHZ/iJZnUSiQqCBTHupzLCS8aAQ
Date:   Thu, 30 Nov 2023 14:52:10 +0000
Message-ID: <d123196b2c5d486cbf3b2e7e4b1fc774@AcuMS.aculab.com>
References: <20231130135232.191320-1-marc.ferland@sonatest.com>
 <20231130135232.191320-5-marc.ferland@sonatest.com>
In-Reply-To: <20231130135232.191320-5-marc.ferland@sonatest.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: marc.ferland@gmail.com
> Sent: 30 November 2023 13:53
> 
> The ds2433 driver uses the 'validcrc' variable to mark out which pages
> have been successfully (crc is valid) retrieved from the eeprom and
> placed in the internal 'memory' buffer (see CONFIG_W1_SLAVE_DS2433_CRC).
> 
> The current implementation assumes that the number of pages will never
> go beyond 32 pages (bit field is a u32). This is fine for the ds2433
> since it only has 16 pages.
> 
> Use a dynamically allocated bitmap so that we can support eeproms with
> more than 32 pages which is the case for the ds28ec20 (80 pages).

Dynamically allocating seems excessive.
Why not just make the maximum a compile-time constant (say 96 or 128)
and just check that the actual size isn't too big.

> As an added bonus, the code also gets easier on the eye.

and slower :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)