Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Thu, 30 Nov 2023 14:58:41 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Michal Simek <michal.simek@amd.com>
Cc:     linux-kernel@vger.kernel.org, monstr@monstr.eu,
        michal.simek@xilinx.com, git@xilinx.com,
        Conor Dooley <conor+dt@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels
Message-ID: <20231130-power-rubbed-fbf64a8c6978@spud>
References: <441d9babc7042892350a58ba4300df4761876ae3.1701334008.git.michal.simek@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BPoyXFuPPPfwP3S7"
Content-Disposition: inline
In-Reply-To: <441d9babc7042892350a58ba4300df4761876ae3.1701334008.git.michal.simek@amd.com>
Precedence: bulk


--BPoyXFuPPPfwP3S7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote:
> arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels
> that's why increase it.
> But AMS binding defines 51 channels
> Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> that's why increase number to 51.

Please write commit messages for bindings in terms of how they relate to
some hardware. In this case I think it would be sufficient to say that
the Analog Monitoring system has 51 channels, the opening sentence about
the dts as justification provides no actionable information.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>=20
>  Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml b/Doc=
umentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> index e5b24782f448..be5c7d4579bb 100644
> --- a/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/iio-hwmon.yaml
> @@ -19,7 +19,7 @@ properties:
> =20
>    io-channels:
>      minItems: 1
> -    maxItems: 8 # Should be enough
> +    maxItems: 51 # Should be enough
>      description: >
>        List of phandles to ADC channels to read the monitoring values
> =20
> --=20
> 2.36.1
>=20

--BPoyXFuPPPfwP3S7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWijIQAKCRB4tDGHoIJi
0lICAQC1KW3GVEI4tqQWELA4CLCh/wITQ8ofp4IPCooF4IJVWQD+NKt3+qwCkPnx
L96KirOZwabT/HBwdu4dRpfvte7q4Ak=
=DlYh
-----END PGP SIGNATURE-----

--BPoyXFuPPPfwP3S7--