Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20231130135232.191320-1-marc.ferland@sonatest.com>
 <20231130135232.191320-5-marc.ferland@sonatest.com> <d123196b2c5d486cbf3b2e7e4b1fc774@AcuMS.aculab.com>
In-Reply-To: <d123196b2c5d486cbf3b2e7e4b1fc774@AcuMS.aculab.com>
From:   Marc Ferland <marc.ferland@gmail.com>
Date:   Thu, 30 Nov 2023 10:10:41 -0500
Message-ID: <CAMRMzCCW9dsCLL0karbWOsbunCO=JGaiDEcT4ZD50O7wRqCfsw@mail.gmail.com>
Subject: Re: [PATCH v3 4/5] w1: ds2433: use the kernel bitmap implementation
To:     David Laight <David.Laight@aculab.com>
Cc:     "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "marc.ferland@sonatest.com" <marc.ferland@sonatest.com>,
        "jeff.dagenais@gmail.com" <jeff.dagenais@gmail.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 30, 2023 at 9:52=E2=80=AFAM David Laight <David.Laight@aculab.c=
om> wrote:
>
> From: marc.ferland@gmail.com
> > Sent: 30 November 2023 13:53
> >
> > The ds2433 driver uses the 'validcrc' variable to mark out which pages
> > have been successfully (crc is valid) retrieved from the eeprom and
> > placed in the internal 'memory' buffer (see CONFIG_W1_SLAVE_DS2433_CRC)=
.
> >
> > The current implementation assumes that the number of pages will never
> > go beyond 32 pages (bit field is a u32). This is fine for the ds2433
> > since it only has 16 pages.
> >
> > Use a dynamically allocated bitmap so that we can support eeproms with
> > more than 32 pages which is the case for the ds28ec20 (80 pages).
>
> Dynamically allocating seems excessive.
> Why not just make the maximum a compile-time constant (say 96 or 128)
> and just check that the actual size isn't too big.
>
> > As an added bonus, the code also gets easier on the eye.
>
> and slower :-)
>
Sounds reasonable to me. Thanks for the tip!
Marc