Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <30a76402-894a-4fe3-82ae-491b0890aa8c@kontron.de>
Date:   Thu, 30 Nov 2023 16:46:00 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Remove video_pll1 clock rate from
 clk node
Content-Language: en-US, de-DE
To:     Adam Ford <aford173@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     aford@beaconembeded.com, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231128045415.210682-1-aford173@gmail.com>
 <20231128045415.210682-2-aford173@gmail.com>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20231128045415.210682-2-aford173@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3RqSDZrUUIwRExBaFdVNmxXOVZmcVNDb09CakdKVlNzMkVVR3dOVldyUXd4?=
 =?utf-8?B?U3VlL29aYnFPdS9mbElybzVQSnVjcEFCQnJ4S3UvM2lvUTlRTmNmRjBNT3dG?=
 =?utf-8?B?VnFmVnNCZ2NWQWJJVlR1eXhGOGR0ckQvR2IzRW1IWGFaS3d5V3RUc25BZSt5?=
 =?utf-8?B?aVF2N0p4RDhqZURiMWtFSFRYdS9jL1d2NWVKRzVlbVBYMFlvK1ZXK204OFpE?=
 =?utf-8?B?cjE2M2xhRVZBTnBtSDY3TWRuSW9lUWpUWENqSnNEaFB0bFJCc0FWS1BEa1Y2?=
 =?utf-8?B?ZEthT2wycE51a2l1YWFsWE05N21sOXlTdEZ6NlZacTMraWR4QlZ3U1FSM1dS?=
 =?utf-8?B?bG8yekhyK0xsd3N3ZTk4NENTWThhb0RSNDJxUDdVM3BBK0kzL25pY0xWNzRi?=
 =?utf-8?B?U0R4WnZyd0tFYkRWYUo3b2s1QXoyclZXbHkrSm9VS0Z1NXFVcVBEM2tyVVJO?=
 =?utf-8?B?cDBLdUtIVWxFMkRqN1Y4R1liemk3NkhpZ2ZhQ2FQUHBCZEorT0JJdXE5R1dM?=
 =?utf-8?B?V3VGRTZ2Q0N4c0l0V0xvckNPUDMzU3hxeE9ZUW8xZHBnS1Zhcm13V3BrL0tN?=
 =?utf-8?B?ZDV5L3kvWndVQjI2Y0s1SC9PWmpKK2UxVmQ3cElzWEFuNjJRcmhldzh2QWk4?=
 =?utf-8?B?MlZxTUtYVTI4TEllWHNpZGRENU5PbDJwdTFCcVBxOWJpVXpXZXkycFFOV1ow?=
 =?utf-8?B?WVZqbENMaFJnWkxKNDlzazBNcXBFT1RGSXZmV0NmTEZ3ODdQS0w0RDF5WlR6?=
 =?utf-8?B?dStISzJvZ2RTdThZb0g0ZDNmZ2JOOG1XTFQ0aGpwWm9ILzdreDM5ZFIyV0FZ?=
 =?utf-8?B?V1hGcm5FSkIva1JieHdwelY5Myt0VndLZS84OGszRm5hYm14WVN6a0dXYmFh?=
 =?utf-8?B?cGdOWTgyc0dXbHBYYjljekZqSGRkNFI4RnMyZ1NsY1N4N0h2TGxPN0NQRm9x?=
 =?utf-8?B?dytRS2Z2OGFEbEJpcGRDckp0dUN5RFl1aUsycDJ4QXQwNW1SRVpZdGc2ZWtt?=
 =?utf-8?B?STZzOEQ2OHNtUThwWENiRkdoeEJtYWZvTXZOZmExN21CZms1VUxTdDBHU3R4?=
 =?utf-8?B?c3kxOXRTZ2hZbkpPTEhGZHFvdUZTdHV4Q2RYcFplMy9OYTdQaHBQZ1lrL2tI?=
 =?utf-8?B?aWRlWWltUHBMQXIzVnBmL2kvMEJqVFFxT3RKM0dUOExaSlJOTUczeTV1OGNw?=
 =?utf-8?B?ZVVmU1VUcjdpWE5DMXVudmlOZU11NlFkY3hEdkFMZjRyVmRvZWViL2FpTEw1?=
 =?utf-8?B?Q3ZDY0pobjhMNnRVNldGcFZTSU5ENzlGb2ozMlJGdnFNUWZza1NZek04aytk?=
 =?utf-8?B?QzRVVGpVUDhkaWlzQUM0Tjl5dzBHdnZtajdDM1RXMHladDk3UDJFMVRsRTlh?=
 =?utf-8?B?T3pEdDM1dlpnN0w2bWk3SzUvcGk4Mk13OWYwTmNoNUJtWkUxcGRGbzd5Yml3?=
 =?utf-8?B?MldSSEtrWnRPYlROeUJVK1p0WVhmVmVmUlB6eEYrb052M3M0SlJBUHg0M0Z5?=
 =?utf-8?B?d01EZnpVMkF6N3Y2dEp6TEUwNi9SOFp4S09uSTdEb0hkLzVVajl5V0ZOdTVP?=
 =?utf-8?B?RHcxNitxcERzbDJnTDUwdW5PcUtRK1hmRkpwZUNheTdVK3NiZ3ZtWWM3cXMr?=
 =?utf-8?B?REVSMnh4OWVkalVpdnY1WHlNY3B6ODY3VWlMY2lMeE5oY1BnQWpTTmliK0J2?=
 =?utf-8?B?ZW1aV1dJV09XdFhXZ1JTRlQyVUwyUEk3NmdCSnpvT1gzY0h2SlBSTnlhZlNQ?=
 =?utf-8?B?NlJINENaa3FzTkdBL2ZQc1d6S29GSEJqSGVVajJST0dHczRuODZZR2lTVDVo?=
 =?utf-8?B?aVRuNjZZazA5UmpRNGp0dVBINHQwai9nTVRoYTN4SGkxUWJGL29PVEZoQ1dz?=
 =?utf-8?B?cG4xeTIzczg4VGlhNUVUY0hsRjVmRFdma0NWRGlGUHRKckRyM0g2WFNwWXdF?=
 =?utf-8?B?YVA5UHNZdUQ4Q2hiOXlPa0JxWHEzNXhMaUZ1aGdzNWhVTzJUeVBJSW9vRmJ0?=
 =?utf-8?B?dlpKU2JzaEVzc1hPb2NkR3p0V0ZQZDdQNkVKSnRIbXVQQld3dlRTWlA5bVJZ?=
 =?utf-8?B?WHpWOXdGS09KM1daallhbFBGRDU2WDl0NUNWQ2xmQktUQmNaUVhTcVE4TGhE?=
 =?utf-8?B?cCtoaGFmTUNCbVBXekl6WmJvWnlCSTNPMWF5WWZkdHNicExEQ1FTZWY2T2Y1?=
 =?utf-8?B?N1E9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: fc47ad48-5898-4155-a06f-08dbf1bb74f7
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 15:46:02.7822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BWprLXhMuB3BZ9r2h2pAyJv55I9vUpeAhFEMG8JJpbgbFCX99h5QdB5WPqSnPoI6oi3bvn2Bn2z7sRQvTGI5nUs7voY8p1N2ZDXe6GFT0wI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR10MB4069
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 30 Nov 2023 07:46:13 -0800 (PST)

On 28.11.23 05:54, Adam Ford wrote:
> There are two clock-rate assignments for video_pll1, and the
> only one it should really have belongs inside the lcdif node,
> since it's the only consumer of this clock.  Remove it from
> the clk node.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 8d872568231d..a3dae114c20e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -647,7 +647,6 @@ clk: clock-controller@30380000 {
>  						<&clk IMX8MM_CLK_AUDIO_AHB>,
>  						<&clk IMX8MM_CLK_IPG_AUDIO_ROOT>,
>  						<&clk IMX8MM_SYS_PLL3>,
> -						<&clk IMX8MM_VIDEO_PLL1>,
>  						<&clk IMX8MM_AUDIO_PLL1>;
>  				assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_800M>,
>  							 <&clk IMX8MM_ARM_PLL_OUT>,
> @@ -657,7 +656,6 @@ clk: clock-controller@30380000 {
>  							<400000000>,
>  							<400000000>,
>  							<750000000>,
> -							<594000000>,
>  							<393216000>;
>  			};
>  

Thanks for the cleanup!

Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron BL
i.MX8MM