Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Saleem, Shiraz" <shiraz.saleem@intel.com>
To:     "Li, Shifeng" <lishifeng@sangfor.com.cn>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>, "leon@kernel.org" <leon@kernel.org>,
        "gustavoars@kernel.org" <gustavoars@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "Ding, Hui" <dinghui@sangfor.com.cn>,
        "lishifeng1992@126.com" <lishifeng1992@126.com>,
        "Li, Shifeng" <lishifeng@sangfor.com.cn>
Subject: RE: [PATCH v2] RDMA/irdma: Avoid free the non-cqp_request scratch
Thread-Topic: [PATCH v2] RDMA/irdma: Avoid free the non-cqp_request scratch
Thread-Index: AQHaI2VMij7Wu/sLOUSI2c9e66wXdLCTAQ6A
Date:   Thu, 30 Nov 2023 15:46:35 +0000
Message-ID: <MWHPR11MB00298A90BFA2BCF9E7180BF1E982A@MWHPR11MB0029.namprd11.prod.outlook.com>
References: <20231130081415.891006-1-lishifeng@sangfor.com.cn>
In-Reply-To: <20231130081415.891006-1-lishifeng@sangfor.com.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6uuBtuRaOf/t3W2wEVusvKc6xy7CD8QDWYQ2NP7ryUMKl3FcNmawyGiKWD69?=
 =?us-ascii?Q?McyFSbfNb4YM08bx83s2Xdvg8p8RouU0LhoEnAPmXRhKZ5oYES79gt6mc8Zs?=
 =?us-ascii?Q?P69eph2Sf1dj1poTrV0KrHCehodhMqCjDO5WrNqEUJZjrtXt6CNQUrebqJAR?=
 =?us-ascii?Q?b0LoklEoqept4qVNmEHpyrFw7zTFMX9taY578nldxQGLPUmYhG6LkAH7VI72?=
 =?us-ascii?Q?oPJADho8m6XCE7uLJhyr3GGwSzRIDKlZ2TDdUYO/HnKYMPPJ1uyhsRhyQ/iS?=
 =?us-ascii?Q?th2JmIVqJplX15rtNsDWJxClPl1g0nOSeTCXmtrNvsnFzmQwwqg34VBUmwM1?=
 =?us-ascii?Q?4U1wUtNJskBgr62HCX8PUEjQLb0SzjfZaZ5H9s5V18suoOuVs1TnSzjfLoK9?=
 =?us-ascii?Q?lJvNQ1bmLV64KEAqCRvafVUSUN4p85YLnTa5C6ZK92kQ6RHR3MLI+wmC3Bnn?=
 =?us-ascii?Q?kJXXnh6n6TD8ZQc88T39Kv6ktkRSHRNM0DIqAOXDbKYjjz1FZ0GUlAOj2O/I?=
 =?us-ascii?Q?S4Me8La24/HjZJ175zbaEAQEEbeabNeV85ru+BDALI9wtmREhOkru8ElnuTd?=
 =?us-ascii?Q?pmodXko1d5RLfnc+aS+JTQ0s2zGgKerzGdbz9hCmcuo+4SP6TbLXt73ys8qu?=
 =?us-ascii?Q?QAOUNrX4i5jBj20GH6794/Ba/4edpO/NFhc3+kty8ppZ5kAya05MGoQVYz38?=
 =?us-ascii?Q?c3D38MjgM69Wl2vEnFQvH9MADGihRoxjbtoZvFOG/dG8F+LZgNYkC6kelkVK?=
 =?us-ascii?Q?YLUdXWMSuLsZmfkqLCqg/bYZpSku/07il8YXNPJcP9lOxgMcqg4k5WjCjcUo?=
 =?us-ascii?Q?iH9RewBcQJqgtLneQN0bux7OgUyPJjb5W4XNIAtBcCM72Q6ctWr2nW2EnicP?=
 =?us-ascii?Q?jH/hnp1Uambu2pvRFnhPCxaUODSTcko9SYa0iri6fJJKwIZgb56+pbMjQazw?=
 =?us-ascii?Q?fPtQhOBGhUDN+jTTbPJq+VVW6AcoRHgpkxGFKmZfmrBF2Aat2zUFFOYx0i40?=
 =?us-ascii?Q?5HkyrdxWkcncs5IujGrGokHceHu31CHGZYBdcY3PCR2ot/sf8qQhggIefZ9i?=
 =?us-ascii?Q?evTFykLJQbFQNWrsg4Idut2ps8QxaEgEu9JSM/+2beSfI246Xds147bh2LHW?=
 =?us-ascii?Q?GswSooXkMTuzhq3NKEPQghL+NScz0O//pFSiXlNGFKK8Dx92l++OA6C4gIjb?=
 =?us-ascii?Q?S76DrVIvsRhjx2p/lOq6xpD58BmkEMsrO9OgWpwHAHo8SOACqzU8dr9ymeyJ?=
 =?us-ascii?Q?uHOD4QBuE9qXmgE8PTj95cYKCIdwUbEeLyaOD/+dcbNh0M80PudbBQp8Y6Gz?=
 =?us-ascii?Q?Tyc5VO0M29bOt+UIlsTzMxtKo9aJn6namcM6WjlgFi1orV6lzHmtnPoklVfb?=
 =?us-ascii?Q?cqJZ4g1TF4tvfKV4JvdXEnpKerkFz7sPZ4Djhkiz8V3em10jx18ycfddIdwS?=
 =?us-ascii?Q?AiCGEGvHu866Y2VrwRBtwb6j/5Wo9YIvzrc7w4oObMLXMq1veYZtSK2xlGyd?=
 =?us-ascii?Q?v5MFhovlRG7qA3CCMOMe9puC2Kqv6ieGBDzAw6JpW45LasGGWOl/RuBaY1kF?=
 =?us-ascii?Q?rz9qHv6sYSvREwiqy5xJSz8Ls2SqzfeLaOfZpZqH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0029.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b3b28a2-9a6c-4f16-d52e-08dbf1bb88c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 15:46:35.8876
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HOFbFz00A/Isjot3+6NoqJ6JGJbnadJWaMGqMZJVVyeLPJ88frc0uCFK7asd1+uxnPk8wnU9ZyZ27TazAGfk5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5711
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 07:47:00 -0800 (PST)

> Subject: [PATCH v2] RDMA/irdma: Avoid free the non-cqp_request scratch
>=20
> When creating ceq_0 during probing irdma, cqp.sc_cqp will be sent as a
> cqp_request to cqp->sc_cqp.sq_ring. If the request is pending when removi=
ng the
> irdma driver or unplugging its aux device, cqp.sc_cqp will be dereference=
d as
> wrong struct in irdma_free_pending_cqp_request().
>=20
> crash> bt 3669
> PID: 3669   TASK: ffff88aef892c000  CPU: 28  COMMAND: "kworker/28:0"
>  #0 [fffffe0000549e38] crash_nmi_callback at ffffffff810e3a34
>  #1 [fffffe0000549e40] nmi_handle at ffffffff810788b2
>  #2 [fffffe0000549ea0] default_do_nmi at ffffffff8107938f
>  #3 [fffffe0000549eb8] do_nmi at ffffffff81079582
>  #4 [fffffe0000549ef0] end_repeat_nmi at ffffffff82e016b4
>     [exception RIP: native_queued_spin_lock_slowpath+1291]
>     RIP: ffffffff8127e72b  RSP: ffff88aa841ef778  RFLAGS: 00000046
>     RAX: 0000000000000000  RBX: ffff88b01f849700  RCX: ffffffff8127e47e
>     RDX: 0000000000000000  RSI: 0000000000000004  RDI: ffffffff83857ec0
>     RBP: ffff88afe3e4efc8   R8: ffffed15fc7c9dfa   R9: ffffed15fc7c9dfa
>     R10: 0000000000000001  R11: ffffed15fc7c9df9  R12: 0000000000740000
>     R13: ffff88b01f849708  R14: 0000000000000003  R15: ffffed1603f092e1
>     ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0000
> --- <NMI exception stack> ---
>  #5 [ffff88aa841ef778] native_queued_spin_lock_slowpath at ffffffff8127e7=
2b
>  #6 [ffff88aa841ef7b0] _raw_spin_lock_irqsave at ffffffff82c22aa4
>  #7 [ffff88aa841ef7c8] __wake_up_common_lock at ffffffff81257363
>  #8 [ffff88aa841ef888] irdma_free_pending_cqp_request at ffffffffa0ba12cc
> [irdma]
>  #9 [ffff88aa841ef958] irdma_cleanup_pending_cqp_op at ffffffffa0ba1469 [=
irdma]
>  #10 [ffff88aa841ef9c0] irdma_ctrl_deinit_hw at ffffffffa0b2989f [irdma]
>  #11 [ffff88aa841efa28] irdma_remove at ffffffffa0b252df [irdma]
>  #12 [ffff88aa841efae8] auxiliary_bus_remove at ffffffff8219afdb
>  #13 [ffff88aa841efb00] device_release_driver_internal at ffffffff821882e=
6
>  #14 [ffff88aa841efb38] bus_remove_device at ffffffff82184278
>  #15 [ffff88aa841efb88] device_del at ffffffff82179d23
>  #16 [ffff88aa841efc48] ice_unplug_aux_dev at ffffffffa0eb1c14 [ice]
>  #17 [ffff88aa841efc68] ice_service_task at ffffffffa0d88201 [ice]
>  #18 [ffff88aa841efde8] process_one_work at ffffffff811c589a
>  #19 [ffff88aa841efe60] worker_thread at ffffffff811c71ff
>  #20 [ffff88aa841eff10] kthread at ffffffff811d87a0
>  #21 [ffff88aa841eff50] ret_from_fork at ffffffff82e0022f
>=20
> Fixes: 44d9e52977a1 ("RDMA/irdma: Implement device initialization definit=
ions")
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Shifeng Li <lishifeng@sangfor.com.cn>
> ---
>  drivers/infiniband/hw/irdma/hw.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20

Other than the suggested-by tag being incorrect, looks good to me.

Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>