Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <12a5af2d-c58f-4b4a-a994-49a935f59693@suse.com>
Date:   Thu, 30 Nov 2023 17:59:33 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/ia32: State that IA32 emulation is disabled
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <20231130155213.1407-1-bp@alien8.de>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231130155213.1407-1-bp@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXhZcHZmUlpCOFNXUXYvSlExU0Q0ZFVhWHZRTUZ4NmxwamZqRVFtWnU3cHh5?=
 =?utf-8?B?SXlkUVExZU9nMm9qZHl3bWVBYUVoU1c5VXh2UGxJOU81MDBDMGZIdU1MdzVq?=
 =?utf-8?B?V0REK1RrNFNxUUl6VVBsa1hnd2JlcGVsVDJIYlVuQ0NwOXI2L1h4Zi83NjNP?=
 =?utf-8?B?OEg0UzlYNHI2S1dNd3JtdEpLSEJ3WVBYWVB4SEdUbVBsUmo5eU8zaVhSajJ0?=
 =?utf-8?B?dWJCckNFWER3M3dKeWIxOXlyNjJZendKcnRSbnp6aSt2VmRSd3gwTW5Da2pw?=
 =?utf-8?B?ZkhSRmtGL2pqVUNldjVNOTZLOXVJaW5YenNFcXcyTk9HYWlPMVQ2RWwwcUJt?=
 =?utf-8?B?bjMza0ttOXNNZUVhVGdLMmdSVDBFVzVna2pBM3JRNGhuNkg3S1lHdmYraENh?=
 =?utf-8?B?aEdPQjdiVVlKN0UwZkYyT3lGWndIK1JheXo4OFEzSEFEREN2enNlYVZMRVRy?=
 =?utf-8?B?VjY4ZklQUWdVMk5Vb09mTDBySncvYXFFMUdXWG9hMXBTMGdsZmRTK2tDVVNz?=
 =?utf-8?B?aHMwSG5FSUFQVkhPMzBoYXZzNC9RaEN2ZkJWUVl5V3dEdytZZW5sVkJNMk4z?=
 =?utf-8?B?QUtyNHU4YTcyK3JSZU5XT2RhOGlWendPUjE0ZjM5aGN4bUozSU41MDJCa3FX?=
 =?utf-8?B?MjVuRHE5ZzBYSTdwMVJrV1kralRXU2hORS9uakNTT1FkbXNwazhGN0F5M0tW?=
 =?utf-8?B?S1lPd2Fha0Z3UmlUUDd2VW9FM2poUm9JNlNOQUU0Uy92WFJlNHFCWlQ5UHZq?=
 =?utf-8?B?SFBrK0Y0SDNVUHVwOE5sMk9BV3o4K3NJZTNPWkhxT2pZSUYrc2VpMXgzZmRt?=
 =?utf-8?B?MHQvR0xQTDFxWU5aVjNvZHRGWGI3YmlqQkdYRVZmOEc3N09vS1QyNVQwUXhZ?=
 =?utf-8?B?cHVLOGlUYVpUSEFWaGkweWdwaEJzWVVRdk5vSGtKZVEvZDQ4SWNROHdJVzRW?=
 =?utf-8?B?VmlWa1FuMThJcEgwSzBodkw1VTJ4cGdMalVuTVR4ZmQraWJDamxaUEpWbWdM?=
 =?utf-8?B?ODhtMy9TajRDdXpaanRIU1VPNUIyK0dhVE9PdDdsMGptZG1UWTVRY0FWMmdE?=
 =?utf-8?B?OGxxTjVFK3JZcEhkVXdUL0tuRkZnTHhJWFJSVU1RMFNPNTRCc1VrbUpJYlpq?=
 =?utf-8?B?TGNIOWlENDNlUW4yeC9oeWc0Q29DYm1oRTFjMmx2WUdKWDB6Q0V3VW1PRDlQ?=
 =?utf-8?B?dnQ5RitOeXJWWTBPMExKSytMd1BabjRaWTBnVXdSNG5CcVVrclNLUlZNNFR3?=
 =?utf-8?B?d1BTQWFJdmFnRGdwVVRrL0w1NFlMRDJueDhVYVpXdWRPY1JPK0xnOGFXeG9F?=
 =?utf-8?B?OENnb3pOL0pFOGJsMTI1OTlEMzRDd2M4djRIaGxJdVR3aUJJTzJuS0wyMTdt?=
 =?utf-8?B?OFpvREpKZXk3QUQ2enowOXhpL2hteDJpVk9OZEt1TW40ZjBHN2c5T1dRc0RT?=
 =?utf-8?B?d0xFUkk3K1FyR25FdFNkZGFxNHNDVnNPS1VOeHluc3dFZkFtd2s1UlFKR0VH?=
 =?utf-8?B?Kys5VU1MUGp5cnAvN0NFUU1MNS8rc2V2NGZyclN4WUNKU3RvYVZFVXlUdlA5?=
 =?utf-8?B?bXFJaHByK0pCUlEwUks2WFFsZGh2QWR3cjFJNk91ZEhNWnhJUUo2S3h0OWxh?=
 =?utf-8?B?VlU3QXlBTE1NdzN3OGkwZGV4RmV4cjBUbUtPd2hSeGNEcGhadGo1VWM1cE9W?=
 =?utf-8?B?SDFaVnBpQXJxbkdPbDlMOGptU0tlMDFyMjI0L3lHMTRKL3RIemVlYktIcTYv?=
 =?utf-8?B?YWJVR21GS3dxMHEwY0pKOGZsaFo2c3M3STFwOXBkcmhQcENXb3pxOVZ0MWJm?=
 =?utf-8?B?Ni9XU29qRFdlNjlPMmlNWVFacHpsVUlJLzgrV1pHL2laSWlxUWx0NVpreStm?=
 =?utf-8?B?dEQyWDFBOTcxWFZhWWE5Nzd0N0wvN0hiZUdOSml1MUIxa2ovMnVsR0xKcXNB?=
 =?utf-8?B?bHFMd3ZWSHdqNXZPU2pHU1l3Yzhuc1AybVFuTDdUbDZtWSsyZ0dXNHovQzA5?=
 =?utf-8?B?b05IU0N1L0JmVkR5T3VMVUJzWW0yU1NXd2JraHJNTSttOGpSdlZqL3BZbThC?=
 =?utf-8?B?MTJGeFMrQVFNUm5ZdkZGOFN4N3FrYnZaSzl4R05nWVdPZmtmbXQzajJLSFFH?=
 =?utf-8?B?NnBNMFZIeXYzNVh4bXpMTzd4Z0RaU0tKNVlJcUs5SVpibm1tZEpFN1VsMkdT?=
 =?utf-8?Q?QMjrE52VN3+tHdZ4d99YfsvNDWaX9Lp6QbTJ31nvFrcZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4b9e533-3926-412e-0905-08dbf1bd59b9
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 15:59:36.0906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: URjkK9cL6BiQlehellF99sUrLZEa6JNZ5cuxCXz7r+Jc+RGO3WrXaOrFk89T/UYg3RTsiZIrngjVBBEgSFFl1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7288
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 30 Nov 2023 07:59:59 -0800 (PST)


On 30.11.23 г. 17:52 ч., Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> Issue a short message once, on the first try to load a 32-bit process to
> save people time when wondering why it won't load and says:
> 
>    -bash: ./strsep32: cannot execute binary file: Exec format error
> 
> No functional changes.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Nikolay Borisov <nik.borisov@suse.com>

LGTM:

Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>

Would have liked for this function to replace the non-verbose variant 
but since it's used in syscall it might be easier to miss.

> ---
>   arch/x86/include/asm/elf.h  | 2 +-
>   arch/x86/include/asm/ia32.h | 9 ++++++++-
>   2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
> index a0234dfd1031..1e16bd5ac781 100644
> --- a/arch/x86/include/asm/elf.h
> +++ b/arch/x86/include/asm/elf.h
> @@ -150,7 +150,7 @@ do {						\
>   	((x)->e_machine == EM_X86_64)
>   
>   #define compat_elf_check_arch(x)					\
> -	((elf_check_arch_ia32(x) && ia32_enabled()) ||			\
> +	((elf_check_arch_ia32(x) && ia32_enabled_verbose()) ||		\
>   	 (IS_ENABLED(CONFIG_X86_X32_ABI) && (x)->e_machine == EM_X86_64))
>   
>   static inline void elf_common_init(struct thread_struct *t,
> diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> index 5a2ae24b1204..43e02b52ad19 100644
> --- a/arch/x86/include/asm/ia32.h
> +++ b/arch/x86/include/asm/ia32.h
> @@ -2,7 +2,6 @@
>   #ifndef _ASM_X86_IA32_H
>   #define _ASM_X86_IA32_H
>   
> -
>   #ifdef CONFIG_IA32_EMULATION
>   
>   #include <linux/compat.h>
> @@ -84,4 +83,12 @@ static inline bool ia32_enabled(void)
>   
>   #endif
>   
> +static inline bool ia32_enabled_verbose(void)
> +{
> +#ifdef CONFIG_IA32_EMULATION
> +	pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
> +#endif
> +	return ia32_enabled();
> +}
> +
>   #endif /* _ASM_X86_IA32_H */