Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <f01e7e91-08f1-4548-8e73-aa931d5b4834@intel.com>
Date:   Thu, 30 Nov 2023 17:01:23 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        "David Christensen" <drc@linux.vnet.ibm.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231124154732.1623518-1-aleksander.lobakin@intel.com>
 <20231124154732.1623518-14-aleksander.lobakin@intel.com>
 <e43fc483-3d9c-4ca0-a976-f89226266112@intel.com>
 <20231129062914.0f895d1c@kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20231129062914.0f895d1c@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEdYN0dYRGtYN3owTm9aYUZpYmlsYXhZYStWL2Ixenh0S0RFZ1JJblJ0bm9M?=
 =?utf-8?B?M3k4bU1Qc3pRdm1EakYzWnk1Wk5CVnpxSGE2YmFwb3JKbUhCcS9LU3kvZURa?=
 =?utf-8?B?VW5QbUptMjFDQUJjU09JOFBYNS9qcU9sWWVVcjRUOENuZ1lFZVA3Q1J6M2Na?=
 =?utf-8?B?RlZxTTRRbzFQSng2VG0rdG9JcUM4TWhkR0xBcWhSbmpzeHlXc01ZVWRJeTlU?=
 =?utf-8?B?K3NYVDRFdmZkSjhkQXkvS2ZMMU9MY2dJcUh0aTFOZ25ZT01nWlU2NlJMRnVu?=
 =?utf-8?B?cTUwZFZoSTRJZ2VHL2xsMWIvczlmL29iL1E2NTM3Yk1jMGE0TVdYci9KaTVX?=
 =?utf-8?B?TUFqVTlHTXN3VnBHc3VCdzBzWEY0Z3BqREJKTTYyWEhJY2JJQmtLb01DcWNq?=
 =?utf-8?B?ZW1SMjFyTDJuenJtdzhCeHJWbFprY1VqWm1pSS9BRXg1TzVtbUNGMkZPNEs2?=
 =?utf-8?B?dHlseHFWakh1L2lhNkYxdUhzazZZQ1g2Q2U4T2RNNlhVbDI2dnJYSTd3VlFE?=
 =?utf-8?B?SlZnK3hJM2YwVldjTFVCdmkrYUtJTGZZTzd0cHJQblA4NlRBQTVEWXN5SUU2?=
 =?utf-8?B?Ny8zZVFwOERMMVpwRnVpbVV4V0NOTG9Ta2xEaVo2N0RGUWdDMjVLcU9NaGJR?=
 =?utf-8?B?N0JtNEREelNPY3hZN2ZpR2Y3bitNYnpnb0xYcUEwVERkc3NzN28rb0lRdGlY?=
 =?utf-8?B?SENsM2NZN0xuZVhyRWx6ZHZEUTR2djZwVzRsVTNQTnVQUlg0bnMyNGs1SDFJ?=
 =?utf-8?B?d2dmbmNVYWZNYTc2UFB0UjdJUWVVVTlITnJuM0ZCYjJnaWg0OW96QTl0cmtX?=
 =?utf-8?B?UXFvTEFkMFdnaHFUY1hxUHFkVFFvcjU4OG50ZXJtREVMSWd6NDhTeUxFWVpY?=
 =?utf-8?B?Y3ZzTFVaQ2FxelJwaWlHbjdteTlBdHdpUFc0WGphUmtrdUVjTktWMlVoZTZ2?=
 =?utf-8?B?QnZDY3JMVnBJMDR4aEdTcVZqaG41OFF1cHd5Z1dpWDdqclduRzV6d0luY0xz?=
 =?utf-8?B?bWU1K20zUU00aDJmMnFEQisxeDNxZy9teFhHY3NvK1JRbjBlWnFzdGN2MnZy?=
 =?utf-8?B?cW8wM3oyRDYwclk0ZmdBdnlLNytXM3lKclFXVjlpZmdnZFFqL2lCeksvR3J2?=
 =?utf-8?B?OFFQSjZ2UUZvVnFITUxjSnZFQ21CZm1aWStvZ2xiQlJTUitlWnlqZU9EN0hx?=
 =?utf-8?B?VTJkTldHZ0VzS0Nna0xNcWtEM0w0MWhWVnF0Z2NpQ09kVUtDNFZiRlg3YWtF?=
 =?utf-8?B?cDFHdzk5M09aOWNsOEp0ZlZTM1FxUnlOT1ZDVDB0dGlFMWd4R3pDYnpodHZo?=
 =?utf-8?B?Wmx2NHB5MDBuVkc4VndqdVhraXBvU2FtNW1CcE5lNnhKREkvbVg1RGxhei9M?=
 =?utf-8?B?OHhRc0N6YXMyUFJGMzdHcjlmbWczNjBScjdCbVUrWVY5b2tkbGdOM1N6Vm5o?=
 =?utf-8?B?MXN6YitlbUdHOGVuMXk5bEZvUmxoajEwQjNuaWV6Um43RW05K2hlL1NnYTdq?=
 =?utf-8?B?SjBOU3AzdFlXdGdza3Z5K0ZSVVB2TEE0VnFId2Mwc3A2dTN4QVpYcDl6dWVW?=
 =?utf-8?B?dXpOaUlMY3dZdnJBemQ5TWlFcHVWTFVHRmtrU3B5c2IxN3NqUlpBYjZvTlA2?=
 =?utf-8?B?S3M0RlIyY2FlM0Q3bXVhb2daM09peG9CMkw1S3NlckxQRjNaM3JNN3ZpeVc4?=
 =?utf-8?B?K0VuLzRTbm5CaTlhNzY1OXRBaUhBT05yTTdseUJZell0N2luZU41SHN3OU9M?=
 =?utf-8?B?TGQyaHlOLzhBTEx6cm5sUmlvTU50SDljcnpGclVxV21pQ0NNWmhTL2tINGcx?=
 =?utf-8?B?aHU1VjRPaER6VjVMZVo4QXBTZ1RjYkR6Y0RMWEFwVFowTXVSMVhWNCtXWEdT?=
 =?utf-8?B?N3ZsNUZiaTZEZEFiVTJNZEozOFFxNWhYdnJsTnZTa3dYMHkzeWxqY1lkSEMz?=
 =?utf-8?B?K2g4eHpyMUI1YXNuWDhUcElsa1dFdkM0ZW83SHFQVldaM0hmNEpjNjV0djBq?=
 =?utf-8?B?MUplRCtWOC9YSmFjRCtxSzROaUVYUzhBQWhWczNGVytoRUtRa0tjV3d2Qm83?=
 =?utf-8?B?bWtsQjBoS2RaVFplNXUzSG1seEtVck16cnRibHFuMnFuWHRuSVlydTVzVkdk?=
 =?utf-8?B?d0I2a0NJZERRZlJ2UTNjWHN5OWdrNFR6WnVLM3djWWw3WFFKcHhGR2xPNjBt?=
 =?utf-8?B?WkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9402e759-85c6-49d6-3e4c-08dbf1bdb951
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:02:16.6160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: egH4tE00az/IF+dz4iACkrsQiwyEfMtyIa7OvbIsv2GCps5xO5wNJMD2lzMjD9DaYHpHrbEMZk88Pm4oRdAOehCRIvb+mFT+4zJ+Jh7AEdA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8363
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 30 Nov 2023 08:02:55 -0800 (PST)

From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 29 Nov 2023 06:29:14 -0800

> On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote:
>>> Expand the libie generic per-queue stats with the generic Page Pool
>>> stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is
>>> enabled. When it's not, there'll be no such fields in the stats
>>> structure, so no space wasted.  
>>
>> Do I get it correctly that after Page Pool Netlink introspection was
>> merged, this commit makes no sense and we shouln't add PP stats to the
>> drivers private ones?
> 
> Yes, 100%.

Meh, this way the stats won't survive ifdown/ifup cycles as usually
page_pools get destroyed on ifdown :z
In that patch, I backup the PP stats to a device-lifetime container when
the pool gets destroyed, maybe we could do something similar?

> 
> FWIW I am aware that better tooling would be good so non-developers
> could access to the PP Netlink :(  I'm thinking we should clean up 
> YNL lib packaging a little and try to convince iproute2 maintainers 
> to accept simple CLI built on top of it.

Thanks,
Olek