Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <6adeb081-33d9-47f5-b812-e867561e0ded@suse.com>
Date:   Thu, 30 Nov 2023 18:04:20 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/ia32: State that IA32 emulation is disabled
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, X86 ML <x86@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <20231130155213.1407-1-bp@alien8.de>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <20231130155213.1407-1-bp@alien8.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXoyWkJXZU44akdHSjJGTmNhUEk2RUFJMG9WTWg4ZGdnNkFUUVExVUdxc2pi?=
 =?utf-8?B?YlZ4T3U2bnZnNjczQy9RYnluNTMzZnpUc3BsQkRVOFNsM0M5c1ZCNXFTL0ZT?=
 =?utf-8?B?VkI2SHhYZXY3MEhwV3A5bXhaaS80dnIvUjBOcFFlVUdKVS93WmNNckl1dmVF?=
 =?utf-8?B?dk01ci9pbnVucnh4ZmQvV051UnBCWlFwelRTb2FkOWh5N0dMYUE0b3d6d2Jl?=
 =?utf-8?B?dnk2QmxMR2lWSUZ6V01BYWNtOGdRRDBTMjlkdy84cjhSbWhRM09ULzNNMk9H?=
 =?utf-8?B?UDNyT2IxdXVWU1lubjlyT29STldwWFkyY0hoSEtwbjZuK1pvandSZjV2bXdN?=
 =?utf-8?B?QXdTbE9jUHN4REVlSjZRdU1HZ2xreDBRTFRMUWwvejU0RWlGTTJPeVI5Um1s?=
 =?utf-8?B?Y1NXbk5qK2lXUjdCT21vV1Z1U3lIQ0Nva1ZYaFVNQ3BUeXZVMFlxUFVlMlhW?=
 =?utf-8?B?NmZvWEZBMTcrRE92c1V1bXJ1QTVSU1pkazRONGFKWjJHZnFaZS9oUUQrNENi?=
 =?utf-8?B?VWJnRXNQU0pZK0NmUEU2V2c3Z0xkYmpnaVNUK2RXQWpJL0JrcGRtMWJYcHhn?=
 =?utf-8?B?TUpRMzc1clBQTndqU1BQMWw0ZkhpZXhnaWZ4Q2paMWtuT2ZBZ1lQd214YVhH?=
 =?utf-8?B?UUVLMUpKbGxoRk04OGFvbDdwTUhuUEEreDd4S0ZySTJrY1QwbFlqWll2M1NX?=
 =?utf-8?B?MEtQME5IUXhLem5FanZlc3VOcmpycGJQM3U2aHNNVWJSRFJ1bUNFOElqK1dO?=
 =?utf-8?B?TkZXT1h2eVlZQ0ZoTHVYVWx5Qk1CSE5BbVVQSWp3d0FsUTFMcm12bGlVQ09U?=
 =?utf-8?B?VkNsakRnN2h3SC9RWW1tZXJkUE1LNWdPOUZlVVFSdk5MRVc2d09FY1RLOVlK?=
 =?utf-8?B?d2FCYlB0alp2MmlxYWIyQVNHVEVZWkpEeTVGbkdRRVRHSXY0NHJmZG02bEF1?=
 =?utf-8?B?MEMyK0ZIRUFqNmwveHRuLzdJa0RXQWp2QXNlWnpYZnIrUTVpYWxvSm5CWXpP?=
 =?utf-8?B?WThYTE4vL0sxT2phb3NqWGZDK0ZlY2h3K29NS09SR2lzY0c5dVFtc05lS1h0?=
 =?utf-8?B?VWRHRTNsYUhhblFlZGJrVGdGcmZNTnk5M3JuMDViSkhVd0p3QzhCMm9uR2Rk?=
 =?utf-8?B?TnM3eWVwZVhNUW9ncm9VcjRtdEZEVW5PUCs0Zms3b3l4bHRLK05sMjQyZkxD?=
 =?utf-8?B?dmU0UUF6TkxVQ1pSelJoeThGbnl0dXpTZldZbktJY0NFYW1uNGZHMldLbCto?=
 =?utf-8?B?c0p4NVAzemJMaGJpRTlnTFRxQ2l1ekRPQmhDRlo3TFpEb3M2Y1l5Rk9mSDQw?=
 =?utf-8?B?MDBwZTVIcyttZFpZK0w2YU5mRWlpOHR3UWhadXBMWVlweWxiNW94NW1ld3ZR?=
 =?utf-8?B?enhzSG1CNmZvbzFyQ2VBL0JxbGFJNEpwLzVmZVRrMkY0TTZUbnZUK0tkTy9R?=
 =?utf-8?B?bmt2UjJtU3A5VnljdW9xRC9FUGVudGJtWWJER1pvQytzaWJhWUErdGYrdnlv?=
 =?utf-8?B?V0dnRHhIWldqZ1duSlp0VitsczNGNTRlbHZHeDJncDFsV2FESGxUd2d4Q0VV?=
 =?utf-8?B?OXgwQzdGQkF6K0ttbXhvWDlVWHJZYnlyWlFNNVEwc2ZOZTV4ODlReG0xS0gw?=
 =?utf-8?B?azVKY0ljNHZRM2k3THljeXNsamJ4TTBtNDY2bW52cHloNEk1TytMZVdHUHpW?=
 =?utf-8?B?QWxDOEtseG93Zml2TVgzSVBCejdPYVU1WkhwYjRwSzlQV0VqQTAyL3dGb1Qz?=
 =?utf-8?B?Ly9sRnR4bjR5bDFsdy9pektpQVNkRXhmMFMzSVBrYSsveHg3RVRnQzRvYm5q?=
 =?utf-8?B?YUFXSXFtZ09HZm9ORXRPanZSMFNEaFF5L2tianNLN0VDK2N1Y1E1bkVueWE4?=
 =?utf-8?B?Y0M0NEM1ZG5SL3VKdGtmUHVmMjhvOTNTN1lYS2R0VngvSFZmMlZnWFpCM2Ur?=
 =?utf-8?B?WTFVemtrbjVBT2toV002aWxKSEJUOHdaaCtLcXl2VVdrOG5zWkpXZzF4OEFY?=
 =?utf-8?B?aWhtSlpMVDhjSjFiVGNndnV3WmhTQlQzR3NOQ0IraFp2MDBxY0NDTDNsdHNF?=
 =?utf-8?B?QjBqdmlheExxTjQxMGFnSFlHMVFmTG1XWFhSSFpxRHFhUGxXZHMyK1J1Tkdo?=
 =?utf-8?B?S3ZuQ2V5VXdqaWk3SzhHdTZRSVBZT0lPcGxtNk5ETzFhaGZZOXVUL3ErNnNn?=
 =?utf-8?Q?q/bTCbblzJeP0YUfMA5PW9Ydr30eSG1cOCDaYu/YHWUs?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf7cbfd-2703-406e-c30b-08dbf1be03f8
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:04:21.6945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BaTqPFqbVS7m9jYve8HK9brn5ABKQR9J7IE8QLcOGJ79c0+Kg6FHDnujFkHqni6zQiXHJRgzsHmita+s9MgvQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7712
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 30 Nov 2023 08:04:36 -0800 (PST)


On 30.11.23 г. 17:52 ч., Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> Issue a short message once, on the first try to load a 32-bit process to
> save people time when wondering why it won't load and says:
> 
>    -bash: ./strsep32: cannot execute binary file: Exec format error
> 
> No functional changes.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> Cc: Nikolay Borisov <nik.borisov@suse.com>
> ---
>   arch/x86/include/asm/elf.h  | 2 +-
>   arch/x86/include/asm/ia32.h | 9 ++++++++-
>   2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h
> index a0234dfd1031..1e16bd5ac781 100644
> --- a/arch/x86/include/asm/elf.h
> +++ b/arch/x86/include/asm/elf.h
> @@ -150,7 +150,7 @@ do {						\
>   	((x)->e_machine == EM_X86_64)
>   
>   #define compat_elf_check_arch(x)					\
> -	((elf_check_arch_ia32(x) && ia32_enabled()) ||			\
> +	((elf_check_arch_ia32(x) && ia32_enabled_verbose()) ||		\
>   	 (IS_ENABLED(CONFIG_X86_X32_ABI) && (x)->e_machine == EM_X86_64))
>   
>   static inline void elf_common_init(struct thread_struct *t,
> diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> index 5a2ae24b1204..43e02b52ad19 100644
> --- a/arch/x86/include/asm/ia32.h
> +++ b/arch/x86/include/asm/ia32.h
> @@ -2,7 +2,6 @@
>   #ifndef _ASM_X86_IA32_H
>   #define _ASM_X86_IA32_H
>   
> -
>   #ifdef CONFIG_IA32_EMULATION
>   
>   #include <linux/compat.h>
> @@ -84,4 +83,12 @@ static inline bool ia32_enabled(void)
>   
>   #endif
>   
> +static inline bool ia32_enabled_verbose(void)
> +{
> +#ifdef CONFIG_IA32_EMULATION
> +	pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");

	Actually this will result in a false-positive, even with the 
DEFAULT_DISABLED but booting with ia32_emulation = 0 so it's best if 
it's predicated on the output of ia32_enabled. This means we'll always 
pay the price of the branch even if it's disabled but removes a spurious 
notice in a certain case.

> +#endif
> +	return ia32_enabled();
> +}
> +
>   #endif /* _ASM_X86_IA32_H */