Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Thu, 30 Nov 2023 17:09:03 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     X86 ML <x86@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [PATCH] x86/ia32: State that IA32 emulation is disabled
Message-ID: <20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local>
References: <20231130155213.1407-1-bp@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231130155213.1407-1-bp@alien8.de>
Precedence: bulk

On Thu, Nov 30, 2023 at 04:52:13PM +0100, Borislav Petkov wrote:
> +static inline bool ia32_enabled_verbose(void)
> +{
> +#ifdef CONFIG_IA32_EMULATION
> +	pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
> +#endif
> +	return ia32_enabled();
> +}

As Nik rightfully points out offlist, this should rather be something
like:

---
	bool enabled = ia32_enabled();

#ifdef CONFIG_IA32_EMULATION
	if (!enabled)
		pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
#endif

	return enabled;
---

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette