Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <289bf666-b985-4dc4-bf0a-16b1ae072757@intel.com>
Date:   Thu, 30 Nov 2023 17:45:10 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 13/14] libie: add per-queue Page Pool stats
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Michal Kubiak <michal.kubiak@intel.com>,
        Larysa Zaremba <larysa.zaremba@intel.com>,
        Alexander Duyck <alexanderduyck@fb.com>,
        Yunsheng Lin <linyunsheng@huawei.com>,
        "David Christensen" <drc@linux.vnet.ibm.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231124154732.1623518-1-aleksander.lobakin@intel.com>
 <20231124154732.1623518-14-aleksander.lobakin@intel.com>
 <e43fc483-3d9c-4ca0-a976-f89226266112@intel.com>
 <20231129062914.0f895d1c@kernel.org>
 <f01e7e91-08f1-4548-8e73-aa931d5b4834@intel.com>
Content-Language: en-US
In-Reply-To: <f01e7e91-08f1-4548-8e73-aa931d5b4834@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y29VTEZ0aTB5YXhFMTFSM3VSbkVjVFdSaFkzMGVEWDRlbUE4OXVLMDFwTW94?=
 =?utf-8?B?T09OQ041djFrYTdhNStnbkx0RC9PMFdtSzZnZGxTZmNyQ2hUcWFWVC9Kajlu?=
 =?utf-8?B?dTBlY09vbTB6QjFtLzNxd0p0clpJa2pKcHNEMEtYb2hRRDhUTVVsKzZOb3E4?=
 =?utf-8?B?ajE4N0x1cE1GNERUanhDN3BZOGxLMGlCTnJpLzFGWEt5VUxxbENZVHY2SWlu?=
 =?utf-8?B?a1VEakVGUy9PeFhMaWRnYTV5aEZBd1hoYmdocG5YVVBHcnRGRW85RmZVMTUr?=
 =?utf-8?B?ZThtU2ZnOHZsNTRua2FiUmhMT3lRTWF4OW9EQWVDVWxyMHFxMFYvcEtmaUpi?=
 =?utf-8?B?djBaUWdINjVXT1hjS3ozdDAyaG9CUUhxeHRNQ2l6MVEwTnFCbXBhNGZQelRE?=
 =?utf-8?B?REVMMmxGamFHVnBjS0RCWEtMQU9wTCtzd2JpSkdCWVR2cWo1UEJrUE9CdUdW?=
 =?utf-8?B?MnFQY29nRzRSeldCc0ZyUmc3Y1lWZlZVYUJtei9teVBWYWxqSnhUV1Z6OWhT?=
 =?utf-8?B?YzZiZGoxeGVkRXlBd1FvVmZrSDJ6enM1a2pGT25EcExlMXUxT1RrTk1UajYv?=
 =?utf-8?B?dEhIV3FNUEE3VVY1dlBCQnoxZytEZGlWQXBZc1BPUkFVa3htdWRLcTJyM0Nx?=
 =?utf-8?B?dkhDOGs0SlAvaEFXemRkNEdPL29qZXljSE9Rck9uSUtWV1V0QjgyYVpBYW1t?=
 =?utf-8?B?U1lCYmpyRTgvbld2OWhWeFYveUE3c0prZ3o0OXl5cm9RUGFReXB0QzR1cWhv?=
 =?utf-8?B?ZmJqREZmN1NveWJqNnN4eGxZOWZ5dlpVSE1FaGJCdHd1ekJlSi9XcHBxYWxn?=
 =?utf-8?B?Y1VFaGZleFRCMENzRXZmRnQzR2NrQldudDdvN2FPVkc0NFNRU2J1RHY3S2RZ?=
 =?utf-8?B?UXMzbzZZU1hCRk5KREQvT0NKcWV5V2JaMzlFOEl6ZW90VVVEbXE5eE5CWnJi?=
 =?utf-8?B?ZFJGS29EUWRVdytKaFpCTmVqaWY4V1Q5Zll1K3paV0k3YWUxZm11MWZhMUM3?=
 =?utf-8?B?WEdFQUNaaEEzYkJSK1IrQ2owWndROG5obmJrRHhOUkJpT1p1ZFFoSVRHQ0ps?=
 =?utf-8?B?VkN0OVJxVGJmZ29PSmsyelNuQUFLK1pkaFg0d28xTnNsTExNdndiUEtsREpT?=
 =?utf-8?B?am5JOWJJbkk1VlpsUFZERkJ5YTJBME9IcmE0aHgvMndrRzlqUTZER2dBSXpC?=
 =?utf-8?B?ZHZyN0MzaUdQTjV2bHhFcTVwR29jelVuUzgxL3dGZE51QWVmUkNQZWRKUWNW?=
 =?utf-8?B?UnlzdE9rZG5SNVdOakx3UTBMVGpIek1aK045RXZJRzVrSERPeXNjSXpFTWZP?=
 =?utf-8?B?SktNYkh1K1I5Ynp2UWUyQnV2ZWVwcDFlWTFqVFVwbUFjL3FPZk94ZHZsVGlC?=
 =?utf-8?B?a1hRNnhQaXlqVzFqajN2VnRjczZMWml3ZmtuL0tVZVNmZVcyaExyQ0I4Q2l1?=
 =?utf-8?B?WnZlek80YzQ5V1Bpc092NVdDUEZ2eUhHamxqcStVRzF0VHdyVXVOTnhPK1JC?=
 =?utf-8?B?WFlWUlVPaG9FaDRGZVhxSU83SkF1ZnNMUTFwbTZaaEl1dGMxZFE3RXVSSjAz?=
 =?utf-8?B?WWJWU0tEOW5saHczQy9uWVdsM2NSclJGL3VVOVl2R3dHV21KVzdHbU5VRkRk?=
 =?utf-8?B?M2xFa2M0N00zZFMxUk9RZXBzdTFON0JZTGNzQU9rZE9FOEE3Ump4d1hSQ2FQ?=
 =?utf-8?B?N202RUJmaDRwZWtqcGcxYnhLNFpoSWZHTzZ2QXNJeGhMZ20wbG9NcE1Kbkkx?=
 =?utf-8?B?clY5VjVoNEFKb2l4RnVubGhNREhsUk5ZTEQ2Q29HcGNwd2RMWG95M1c2UVdu?=
 =?utf-8?B?OVNYK0V6dnIxeFZsWGwrWFdBNmNXeUlIMm82cHFxT1Avc3VIazNHYWdPVDRP?=
 =?utf-8?B?UEw1MmpHakVLd0hZaHd1dm5wZGVkV3VLaWMyTVRaOHBobjQ1QUJ2YTl1WTZS?=
 =?utf-8?B?TUlTMEs0aHNpQ1QraG9NNjdib0RnNGdYbXJyTG9sb20rMGY3T25QRFRTWDhU?=
 =?utf-8?B?RWVpbVZDNG0xV2xtMUNIUnE4LzR1U0NyeTEwUlBaZDNpNTRvUEcyNzluTG8v?=
 =?utf-8?B?eVZ6aXJ0MHluZW5SejFpYU14TXdJakFQY2tuZXFXZVBJY2M5cG9PL0pkL1VC?=
 =?utf-8?B?MmRzMmE5NE1zS0Vmc3ZaM0ZFUDB6S0Y1bHp6SEYzRTV5ajV4Y0V5YXdYMlFt?=
 =?utf-8?B?ZHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 168ff1e3-c086-4946-a8aa-08dbf1c3d683
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2023 16:46:02.5775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ys1TSeGNfgzk0ymw72feSavBaj9n4zSV+OTi/4HNhM+hFPgzsBOqeSNXoIowRULoH/XvH2Xft1YbN7jdaYUYkPg1LkZlh5hh2CGmYIBrXGo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5790
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 30 Nov 2023 08:46:25 -0800 (PST)

From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: Thu, 30 Nov 2023 17:01:23 +0100

> From: Jakub Kicinski <kuba@kernel.org>
> Date: Wed, 29 Nov 2023 06:29:14 -0800
> 
>> On Wed, 29 Nov 2023 14:40:33 +0100 Alexander Lobakin wrote:
>>>> Expand the libie generic per-queue stats with the generic Page Pool
>>>> stats provided by the API itself, when CONFIG_PAGE_POOL_STATS is
>>>> enabled. When it's not, there'll be no such fields in the stats
>>>> structure, so no space wasted.  
>>>
>>> Do I get it correctly that after Page Pool Netlink introspection was
>>> merged, this commit makes no sense and we shouln't add PP stats to the
>>> drivers private ones?
>>
>> Yes, 100%.
> 
> Meh, this way the stats won't survive ifdown/ifup cycles as usually
> page_pools get destroyed on ifdown :z
> In that patch, I backup the PP stats to a device-lifetime container when
> the pool gets destroyed, maybe we could do something similar?

I still can pull the PP stats to the driver before destroying it, but
there's no way to tell the PP I have some archived stats for it. Maybe
we could have page_pool_params_slow::get_stats() or smth like this?

> 
>>
>> FWIW I am aware that better tooling would be good so non-developers
>> could access to the PP Netlink :(  I'm thinking we should clean up 
>> YNL lib packaging a little and try to convince iproute2 maintainers 
>> to accept simple CLI built on top of it.

Thanks,
Olek