Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231130155213.1407-1-bp@alien8.de> <20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local>
 <CAMzpN2j5xYq0YCzXxU8srha=1um0JSWMM2YWkUG-qFA891xVHQ@mail.gmail.com>
In-Reply-To: <CAMzpN2j5xYq0YCzXxU8srha=1um0JSWMM2YWkUG-qFA891xVHQ@mail.gmail.com>
From:   Brian Gerst <brgerst@gmail.com>
Date:   Thu, 30 Nov 2023 11:47:16 -0500
Message-ID: <CAMzpN2hPCwuR9ydEKybJSTvzeATYq1ovaMVM7Z1S8GCXpeyjmA@mail.gmail.com>
Subject: Re: [PATCH] x86/ia32: State that IA32 emulation is disabled
To:     Borislav Petkov <bp@alien8.de>
Cc:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Nikolay Borisov <nik.borisov@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 30, 2023 at 11:42=E2=80=AFAM Brian Gerst <brgerst@gmail.com> wr=
ote:
>
> On Thu, Nov 30, 2023 at 11:09=E2=80=AFAM Borislav Petkov <bp@alien8.de> w=
rote:
> >
> > On Thu, Nov 30, 2023 at 04:52:13PM +0100, Borislav Petkov wrote:
> > > +static inline bool ia32_enabled_verbose(void)
> > > +{
> > > +#ifdef CONFIG_IA32_EMULATION
> > > +     pr_notice_once("32-bit emulation disabled. You can reenable wit=
h ia32_emulation=3Don\n");
> > > +#endif
> > > +     return ia32_enabled();
> > > +}
> >
> > As Nik rightfully points out offlist, this should rather be something
> > like:
> >
> > ---
> >         bool enabled =3D ia32_enabled();
> >
> > #ifdef CONFIG_IA32_EMULATION
> >         if (!enabled)
> >                 pr_notice_once("32-bit emulation disabled. You can reen=
able with ia32_emulation=3Don\n");
> > #endif
> >
> >         return enabled;
>
> The #ifdef isn't necessary, as ia32_enabled() will always return false
> in that case.

Scratch that, I misread it.  If compat is disabled at build time you
don't want the message to appear, or at least would want a different
message.

Brian Gerst