Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp448430rdb; Thu, 30 Nov 2023 08:49:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEU/M054JweZMSAmTKlBbm0XkfMjl1/EDWhtMVyLMvNIBx/18PYuBB/lpm/DvwtxCcYT6AC X-Received: by 2002:a05:6a20:9145:b0:18b:5a8a:4333 with SMTP id x5-20020a056a20914500b0018b5a8a4333mr23690223pzc.19.1701362976723; Thu, 30 Nov 2023 08:49:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701362976; cv=none; d=google.com; s=arc-20160816; b=0i8QHQeshDBJHGGm35rz1nbtwMF9NtSIxYApfzIoUE5xs+fVVnQsZ+mESFLznr1QAm CRXkCVCwEmv9o848ARKLwnoJQFSHAjyQaYzQUSsxFQH/ybXR99ICqjrsgdBmVPbhPTqb 3liJmV+GJRcmkRicHFDYeffgUzQXwSUVsy/Su/LbrvOoZ+I06G4mqYnBLRaE26vwZcaL /V+3W+n6A5JnkSK3Y32ZzfY1/8GOO6zBIlP0IZEgqbWPIKIdeN2PZaU40rTtYz6VOVHN WA9TYXklmMwz/z2tbfGkxFbj7TItiPUF2xfd4VZQl51jH0m7rofvDH3LX5iFDCpDvWcc g8Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=Okl7E5RbOiaBPy/D3bFqKrLE7cqPmZB8UcTyRJCpbtg=; fh=2Q+7c5ze2gR7JI11YIoHExIrGL+hOgtpLKYVOCMzais=; b=J0fzKNQhyv89W4fRobjw8morVwRVPYMIshDPqE709Rx4/OXf1X0pPGd4uTfQr9KYoZ I+jXYc4ShUyQZTjF7yKFBnmYUQkYYWMgtOlLo/nhJFMTQ3bUmuo4yiEJfeBx5yzaxq0T ayix9p69M6/X/fIyc+bqXzhTE3T9bsHzeSu1S/x7Vi26KA2IkPq9ctYQD0xjs78nFyzz 93ktGypuhCTXvILant8nY9eG4/+w1bkMA6vOwVqqy4MAtRQI/bfzmfQMK8lY6VxIbp9E SHBECnZCBv4aqgUfHZXJH4mopCBsxNTPBB4G3v2vM1oyJQ+9OdWROJ1rpTCQ0lXa9FHW C8jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id x21-20020a63f715000000b005b7160263f2si1660529pgh.154.2023.11.30.08.49.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 08:49:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 82FBC802582B; Thu, 30 Nov 2023 08:49:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345699AbjK3QtZ (ORCPT + 99 others); Thu, 30 Nov 2023 11:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbjK3QtY (ORCPT ); Thu, 30 Nov 2023 11:49:24 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F90710EA; Thu, 30 Nov 2023 08:49:30 -0800 (PST) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sh2Dl6T5Sz6K90L; Fri, 1 Dec 2023 00:47:51 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 89151140B67; Fri, 1 Dec 2023 00:49:28 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 30 Nov 2023 16:49:27 +0000 Date: Thu, 30 Nov 2023 16:49:27 +0000 From: Jonathan Cameron To: Russell King CC: , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse , Huacai Chen , WANG Xuerui , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Len Brown , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH 05/21] ACPI: Move ACPI_HOTPLUG_CPU to be disabled on arm64 and riscv Message-ID: <20231130164927.00003b96@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 08:49:35 -0800 (PST) On Tue, 21 Nov 2023 13:44:15 +0000 Russell King wrote: > From: James Morse > > Neither arm64 nor riscv support physical hotadd of CPUs that were not > present at boot. For arm64 much of the platform description is in static > tables which do not have update methods. arm64 does support HOTPLUG_CPU, > which is backed by a firmware interface to turn CPUs on and off. > > acpi_processor_hotadd_init() and acpi_processor_remove() are for adding > and removing CPUs that were not present at boot. arm64 systems that do this > are not supported as there is currently insufficient information in the > platform description. (e.g. did the GICR get removed too?) > > arm64 currently relies on the MADT enabled flag check in map_gicc_mpidr() > to prevent CPUs that were not described as present at boot from being > added to the system. Similarly, riscv relies on the same check in > map_rintc_hartid(). Both architectures also rely on the weak 'always fails' > definitions of acpi_map_cpu() and arch_register_cpu(). > > Subsequent changes will redefine ACPI_HOTPLUG_CPU as making possible > CPUs present. Neither arm64 nor riscv support this. > > Disable ACPI_HOTPLUG_CPU for arm64 and riscv by removing 'default y' and > selecting it on the other three ACPI architectures. This allows the weak > definitions of some symbols to be removed. > > Signed-off-by: James Morse > Reviewed-by: Shaoqin Huang > Reviewed-by: Gavin Shan > Signed-off-by: Russell King (Oracle) Reviewed-by: Jonathan Cameron