Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231130143822.17173-1-2023002089@link.tyut.edu.cn>
In-Reply-To: <20231130143822.17173-1-2023002089@link.tyut.edu.cn>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 30 Nov 2023 18:13:42 +0100
Message-ID: <CANiq72nS9_uPXNXc6mORtWsBEUB7JBWeUW+aAQ0Osqnca3vaVA@mail.gmail.com>
Subject: Re: [PATCH] scripts/show_delta: reformat code
To:     Hu Haowen <2023002089@link.tyut.edu.cn>
Cc:     gregkh@linuxfoundation.org, akpm@linux-foundation.org,
        masahiroy@kernel.org, ndesaulniers@google.com, n.schier@avm.de,
        ojeda@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 30, 2023 at 3:49=E2=80=AFPM Hu Haowen <2023002089@link.tyut.edu=
.cn> wrote:
>
> -                               if string.find(rest, base_str)=3D=3D1:
> +                               if string.find(rest, base_str) =3D=3D 1:

If this is changed, shouldn't be others like:

>                 if arg=3D=3D"-b":
>                 elif arg=3D=3D"-h":

be changed too?

In other words, it seems this was done manually. Should we instead
introduce/use something like Black or Ruff if we are going to do this
sort of changes?

Thanks!

Cheers,
Miguel