Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp465996rdb; Thu, 30 Nov 2023 09:14:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IH03gjIx+3bO/h+Kr6HdSOXokIa0ZYai58fyCOeuQdF6X4YWK5K4hPVcwhtQpBlJp1gYt1+ X-Received: by 2002:a05:6a20:258c:b0:186:58d6:ca65 with SMTP id k12-20020a056a20258c00b0018658d6ca65mr29144627pzd.32.1701364443954; Thu, 30 Nov 2023 09:14:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701364443; cv=none; d=google.com; s=arc-20160816; b=J0PQDHbgyllGCYg+P7ozZ2bbk2Hqwr2u9Filh84p321cCTODRm+D0yWnj+64tYIT7x bWBnlWNiP213g1mXPtfDNXJugdcjtHMi1AMwUUkhM6xvthEzIGjQLMl3twc94Apoq6xG iJSFwapZWaaUuhDg2Xwncb69srFJ6zL86OcLiwhdAtmd9baZQW9OdoSijjj3rjwTiFHb WST+Kyv+RIuZ7mfDmbfDTMaZa8+tTv777QSSqlkkP2iCnlFHs84CqEeqJVOdfJSfJp7K Hg80gDkvDopvZyKnon+mbXFfaZXdSqJFfXFZP5fbYwdV4tB7Mey+eF4VwNyadO/ivwXr vY3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vzlJCOdzYY0S9xdvlV/r00h+Y+Hsy8vTAOUbTtv8S8E=; fh=nZdtkTAmODF4H+ZpJpkf6ih5SaQ2BE9Cc2HAbA+97r8=; b=UPugTF4HQ+yeGca0MBLW0D4jfpgMo4DXaI7F4/dS90ikw+zR5SyZl2Fpfcjmy1WQoH GOxp6zPIvldQWaW8tRmhHyJuLSHDjg1kCQxKAkTgE+OxtsdYxI4NW2jZZoKn+zmm1rbH quDcDy+K29/gOsrxC+Xas7kfgVWww6n7yZQAIfvurEWLTLXF5gIswp7jTvkajXEcqJ9B EadsGhg3CC7ybTqDhMvbb8+PapsYpx+WHU5fYvhlYxXwYVq+xrkG2w4ANC4DOVQGZPXg 0nHUzdXsaxkocQS7Y18ZlUu2D3wnFayir83CNvesDZWtUNJCWRzhGKXGmM5WEdEoZic4 Br+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=P+pOwfVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id fj17-20020a056a003a1100b006c0febe4496si1603383pfb.205.2023.11.30.09.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 09:14:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=P+pOwfVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C57F48043907; Thu, 30 Nov 2023 09:14:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345576AbjK3RNv (ORCPT + 99 others); Thu, 30 Nov 2023 12:13:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbjK3RNu (ORCPT ); Thu, 30 Nov 2023 12:13:50 -0500 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A7F910D4 for ; Thu, 30 Nov 2023 09:13:55 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 0A68240E025A; Thu, 30 Nov 2023 17:13:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id s8GQOz-K4puh; Thu, 30 Nov 2023 17:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1701364430; bh=vzlJCOdzYY0S9xdvlV/r00h+Y+Hsy8vTAOUbTtv8S8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P+pOwfVt69RJZdTA9cIV3XESp5PwKivysKj8n/TuagO85XAfDy6mxFnDdbr3MaK4g 7DaSsXXsjGRIDoQvEbxErw7Cvv/IcTm4OmMn1oGthUTEN4aYTm6+8i/q1NNOoWq1mN t8lxN+knOrbL5BX1r7653OZBL+4MQ19QCMBhcNghwFhkkJ4aHqUtrrIi1U/7rCC3We Bg1XWSLpIM6qOTofOWLlZRDJCwQryznoKWD//8uk0HpRK9i87SWnLsqSJz86WXXaqN BKV6LxzLkUrVVmxLRBqLUew63HLzn+PfqBEbiZ4wxcm4bbqGePvELisSSPHvw65ZRN rjju3QaHYWLx7jSgOywd2GsVvdEln/WjZbgEAJWAU9fHlJyy93eZheum7pY65rXjAt 9pxoGHZhZeMlPGhr0KX0VxLmZFcNOBK23vMowTWkYogZ8iWjKNqiZUROMHHusKtv8U tIRZOwKwoyXHq9lbtI6wqkAGQ4DBSZOQhowEWTb36/wcl9L5CoPCvyLNC9ydaY/XBA 0ynh4iPLwtHeCuSzePu8YGK+U4Kq1ECRE2F+PFTNwHMFC2vTgkDZ7pbdHhy7uZRAPh 8synulD3r6+Nokw/UIGvYRFWLGoDjUYeCG5yweGdoThw/trGBIbQit2yRI0e71Jxy0 4Fs9gZkdCcRKL2muKmt6QR50= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AE4B140E0030; Thu, 30 Nov 2023 17:13:47 +0000 (UTC) Date: Thu, 30 Nov 2023 18:13:42 +0100 From: Borislav Petkov To: Tom Lendacky Cc: X86 ML , LKML Subject: Re: [PATCH 01/13] x86/CPU/AMD: Add ZenX generations flags Message-ID: <20231130171316.GLZWjCrHGHl+VVp724@fat_crate.local> References: <20231120104152.13740-1-bp@alien8.de> <20231120104152.13740-2-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 09:14:01 -0800 (PST) On Thu, Nov 30, 2023 at 11:05:14AM -0600, Tom Lendacky wrote: > Previously just being family 17h or 19h would get X86_FEATURE_ZEN set. With > this, if the model check doesn't match, you won't get any X86_FEATURE_ZEN* > set. Should you do set X86_FEATURE_ZEN here, e.g. lowest common denominator > for the family? My assumption/expectation is that those WARNs should never happen because they will be caught early enough in enablement and I will get patches. Besides, X86_FEATURE_ZEN means only Zen1 now. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette